linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: "Matthew Wilcox \(Oracle\)" <willy@infradead.org>,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH 04/11] f2fs: Use a folio in f2fs_write_compressed_pages()
Date: Thu, 28 Nov 2024 04:58:19 +0000	[thread overview]
Message-ID: <20241128045828.527559-5-willy@infradead.org> (raw)
In-Reply-To: <20241128045828.527559-1-willy@infradead.org>

Remove accesses to page->index and an unnecessary reference to
page->mapping.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 fs/f2fs/compress.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 494baa1e8bd3..0b55b2695c9b 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -1282,6 +1282,7 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc,
 		.encrypted = fscrypt_inode_uses_fs_layer_crypto(cc->inode) ?
 									1 : 0,
 	};
+	struct folio *folio;
 	struct dnode_of_data dn;
 	struct node_info ni;
 	struct compress_io_ctx *cic;
@@ -1293,7 +1294,7 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc,
 
 	/* we should bypass data pages to proceed the kworker jobs */
 	if (unlikely(f2fs_cp_error(sbi))) {
-		mapping_set_error(cc->rpages[0]->mapping, -EIO);
+		mapping_set_error(inode->i_mapping, -EIO);
 		goto out_free;
 	}
 
@@ -1320,7 +1321,8 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc,
 			goto out_put_dnode;
 	}
 
-	psize = (loff_t)(cc->rpages[last_index]->index + 1) << PAGE_SHIFT;
+	folio = page_folio(cc->rpages[last_index]);
+	psize = folio_pos(folio) + folio_size(folio);
 
 	err = f2fs_get_node_info(fio.sbi, dn.nid, &ni, false);
 	if (err)
@@ -1343,7 +1345,7 @@ static int f2fs_write_compressed_pages(struct compress_ctx *cc,
 
 	for (i = 0; i < cc->valid_nr_cpages; i++) {
 		f2fs_set_compressed_page(cc->cpages[i], inode,
-					cc->rpages[i + 1]->index, cic);
+				page_folio(cc->rpages[i + 1])->index, cic);
 		fio.compressed_page = cc->cpages[i];
 
 		fio.old_blkaddr = data_blkaddr(dn.inode, dn.node_page,
-- 
2.45.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2024-11-28  5:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28  4:58 [f2fs-dev] [PATCH 00/11] f2fs folio patches Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 01/11] f2fs: Use a folio in f2fs_all_cluster_page_ready() Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 02/11] f2fs: Use a folio in f2fs_compress_write_end() Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 03/11] f2fs: Use a folio in f2fs_truncate_partial_cluster() Matthew Wilcox (Oracle)
2024-11-28  4:58 ` Matthew Wilcox (Oracle) [this message]
2024-11-28  4:58 ` [f2fs-dev] [PATCH 05/11] f2fs: Convert submit tracepoints to take a folio Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 06/11] f2fs: Add F2FS_F_SB() Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 07/11] f2fs: Convert f2fs_finish_read_bio() to use folios Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 08/11] f2fs: Use a folio more in f2fs_submit_page_bio() Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 09/11] f2fs: Use a data folio " Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 10/11] f2fs: Convert __read_io_type() to take a folio Matthew Wilcox (Oracle)
2024-11-28  4:58 ` [f2fs-dev] [PATCH 11/11] f2fs: Remove calls to folio_file_mapping() Matthew Wilcox (Oracle)
2024-12-16 13:59 ` [f2fs-dev] [PATCH 00/11] f2fs folio patches Matthew Wilcox
2024-12-16 16:11   ` Jaegeuk Kim via Linux-f2fs-devel
2024-12-16 14:39 ` Chao Yu via Linux-f2fs-devel
2024-12-16 16:40 ` patchwork-bot+f2fs--- via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241128045828.527559-5-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).