linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: wangzijie <wangzijie1@honor.com>
To: <jaegeuk@kernel.org>, <chao@kernel.org>
Cc: wangzijie <wangzijie1@honor.com>,
	linux-kernel@vger.kernel.org, feng.han@honor.com,
	linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH 2/2] f2fs: fix infinite loop in __insert_extent_tree()
Date: Wed, 10 Sep 2025 21:58:35 +0800	[thread overview]
Message-ID: <20250910135835.2751574-2-wangzijie1@honor.com> (raw)
In-Reply-To: <20250910135835.2751574-1-wangzijie1@honor.com>

When we get wrong extent info data, and look up extent_node in rb tree,
it will cause infinite loop (CONFIG_F2FS_CHECK_FS=n). Avoiding this by
return NULL.

Signed-off-by: wangzijie <wangzijie1@honor.com>
---
 fs/f2fs/extent_cache.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 199c1e7a8..6ed6f3d1d 100644
--- a/fs/f2fs/extent_cache.c
+++ b/fs/f2fs/extent_cache.c
@@ -605,6 +605,7 @@ static struct extent_node *__insert_extent_tree(struct f2fs_sb_info *sbi,
 			leftmost = false;
 		} else {
 			f2fs_bug_on(sbi, 1);
+			return NULL;
 		}
 	}
 
-- 
2.25.1



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2025-09-10 13:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-10 13:58 [f2fs-dev] [PATCH 1/2] f2fs: fix wrong extent_info data for precache extents wangzijie
2025-09-10 13:58 ` wangzijie [this message]
2025-09-11  3:34 ` Chao Yu via Linux-f2fs-devel
2025-09-11  6:55   ` wangzijie
2025-09-11  7:47     ` Chao Yu via Linux-f2fs-devel
2025-09-11  7:42   ` wangzijie
2025-09-11  8:19 ` Chao Yu via Linux-f2fs-devel
2025-09-11  9:07   ` wangzijie
2025-09-12  1:52     ` Chao Yu via Linux-f2fs-devel
2025-09-12  3:36       ` wangzijie
2025-09-12  3:41         ` Chao Yu via Linux-f2fs-devel
2025-09-12 10:06           ` wangzijie
2025-09-12 10:38             ` Chao Yu via Linux-f2fs-devel
2025-09-12 10:48               ` wangzijie
2025-09-12 10:39             ` wangzijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250910135835.2751574-2-wangzijie1@honor.com \
    --to=wangzijie1@honor.com \
    --cc=chao@kernel.org \
    --cc=feng.han@honor.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).