From: wangzijie <wangzijie1@honor.com>
To: <chao@kernel.org>
Cc: feng.han@honor.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, jaegeuk@kernel.org,
wangzijie1@honor.com
Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: fix infinite loop in __insert_extent_tree()
Date: Tue, 16 Sep 2025 20:36:51 +0800 [thread overview]
Message-ID: <20250916123651.257804-1-wangzijie1@honor.com> (raw)
In-Reply-To: <1f80bc3f-845f-49f4-93d7-cc1be8a781f5@kernel.org>
>On 9/15/25 11:52, wangzijie wrote:
>> When we get wrong extent info data, and look up extent_node in rb tree,
>> it will cause infinite loop (CONFIG_F2FS_CHECK_FS=n). Avoiding this by
>> return NULL.
>>
>> Signed-off-by: wangzijie <wangzijie1@honor.com>
>> ---
>> fs/f2fs/extent_cache.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
>> index 199c1e7a8..6ed6f3d1d 100644
>> --- a/fs/f2fs/extent_cache.c
>> +++ b/fs/f2fs/extent_cache.c
>> @@ -605,6 +605,7 @@ static struct extent_node *__insert_extent_tree(struct f2fs_sb_info *sbi,
>> leftmost = false;
>> } else {
>
>Need to print some messages here as Jaegeuk suggested, IIUC.
>
>Thanks,
OK, I will update it in next version.
>> f2fs_bug_on(sbi, 1);
>> + return NULL;
>> }
>> }
>>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-09-16 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 3:52 [f2fs-dev] [PATCH v2 1/2] f2fs: fix zero-sized extent for precache extents wangzijie
2025-09-15 3:52 ` [f2fs-dev] [PATCH v2 2/2] f2fs: fix infinite loop in __insert_extent_tree() wangzijie
2025-09-15 8:05 ` Chao Yu via Linux-f2fs-devel
2025-09-16 2:21 ` Jaegeuk Kim via Linux-f2fs-devel
2025-09-16 5:22 ` wangzijie
2025-09-16 6:46 ` Chao Yu via Linux-f2fs-devel
2025-09-16 7:09 ` wangzijie
2025-09-16 7:28 ` Chao Yu via Linux-f2fs-devel
2025-09-16 8:26 ` wangzijie
2025-09-16 8:49 ` Chao Yu via Linux-f2fs-devel
2025-09-16 9:02 ` wangzijie
2025-09-16 12:12 ` Chao Yu via Linux-f2fs-devel
2025-09-16 12:36 ` wangzijie [this message]
2025-09-15 8:05 ` [f2fs-dev] [PATCH v2 1/2] f2fs: fix zero-sized extent for precache extents Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250916123651.257804-1-wangzijie1@honor.com \
--to=wangzijie1@honor.com \
--cc=chao@kernel.org \
--cc=feng.han@honor.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).