From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 610E1CCF2DE for ; Mon, 19 Jan 2026 19:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iBCFcbnFQOpTT5GK44h/jfAE1eLu965g/Am2wQ6hyr8=; b=hXr2PpDB9kdTy5k7KVWj1+2gKH lWPg0+ayCSwqgUldg1uaNb0Gm8gR4ohOAfkPAJooo/jyCeNYAyg3GWK9po44m8sDtiWdOEwx3rrbS iDxgCUGoxG8ONXSBVsb7CgPV1fjTcLR+H+qlQ/AfEeRpj8phE3M8BBt/8KP9sXH5Nokk=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vhuZv-0003Ma-80; Mon, 19 Jan 2026 19:06:19 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vhuZt-0003MU-NE for linux-f2fs-devel@lists.sourceforge.net; Mon, 19 Jan 2026 19:06:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1EKinB4Lm6EZf7nKTWDUJkGBiIlQQ2RWlqWqXDWPpNk=; b=jJFvBSnMdD4S6OQe6U8hqEqeJG v3bo6bjZqIQKI/qLMOFqkLWN3SXlfYxS0rOGl9ACfWC79MWVL7pPmtuJM9qY8X0SKcLm38erb7lh0 MwhGOR9kHl37VX4ZFEIwMSLe3AiXXhDiLyzzEzlVXUKY3ThXmZ2cupL6/FG/zz3wjahc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1EKinB4Lm6EZf7nKTWDUJkGBiIlQQ2RWlqWqXDWPpNk=; b=gVlzjw6Sie9xi8yPuhMcLRoiI0 /HdZ7TG/gN8ck+Uj70g2P3kKLnr0FY3/hNCBudNimq/NeNYMa00fyCmE0xmGKFNsiQTfoee03az0c qXkAp3MM1TmfGQvj8So+lS96ejZll3s1KWZZ6Vt3XANMiBycXcQOrSRsqYzaCqZVbVNs=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vhuZt-0007Ec-6D for linux-f2fs-devel@lists.sourceforge.net; Mon, 19 Jan 2026 19:06:17 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 83FF760054; Mon, 19 Jan 2026 19:06:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7B61C116C6; Mon, 19 Jan 2026 19:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768849566; bh=qwc08ec1OrctlmlBAKmKSTt74F2eGcEv59WaOb2w5eQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PtfZTXUqDM7feQgU5ZToqJgQZfAEbmvBY6pgybD43xWXMt5+0d1F/AgDFH0jYr3hN Pv34MqMPrKVWxKgQxA0z0xO8T97+YdKXpxYk6pduxC2A9PoYfLeL6fDgupt3wQfjzS r1XxlTijMiBjFLZMphMJtVvD+qfHuUItPnUWutZS57l6KjV+OeTtq3cuHYs3J+GH/h PorU2xUi0AWmM8VF9IoYarXTtpg9RSEs166be/N2rOnQ4gsZCfXJIKV93gkLJV5LZW 2GcKQ1fLhawecTS6hTvIBY1iNsWS8OyaUpNnpTJsrGgkBruC/e4kIZLMpDLhm0gNgL VDhQpjkvpFydw== Date: Mon, 19 Jan 2026 11:05:36 -0800 To: Christoph Hellwig Message-ID: <20260119190536.GA13800@sol> References: <20260119062250.3998674-1-hch@lst.de> <20260119062250.3998674-5-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260119062250.3998674-5-hch@lst.de> X-Headers-End: 1vhuZt-0007Ec-6D Subject: Re: [f2fs-dev] [PATCH 4/6] fsverity: use a hashtable to find the fsverity_info X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: fsverity@lists.linux.dev, Christian Brauner , Theodore Ts'o , Andrey Albershteyn , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Al Viro , Jaegeuk Kim , David Sterba , Jan Kara , linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Jan 19, 2026 at 07:22:45AM +0100, Christoph Hellwig wrote: > Use the kernel's resizable hash table to find the fsverity_info. This > way file systems that want to support fsverity don't have to bloat > every inode in the system with an extra pointer. The tradeoff is that > looking up the fsverity_info is a bit more expensive now, but the main > operations are still dominated by I/O and hashing overhead. > > Signed-off-by: Christoph Hellwig Has anything changed from my last feedback at https://lore.kernel.org/linux-fsdevel/20250810170311.GA16624@sol/ ? Any additional data on the cycles and icache footprint added to data verification? The preliminary results didn't look all that good to me. It also seems odd to put this in an "fsverity optimzations and speedups" patchset, given that it's the opposite. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel