Re: [f2fs-dev] [PATCH 11/11] fsverity: use a hashtable to find the fsverity_info

Christoph Hellwig
2026-01-26T04:44:47Z

On Sun, Jan 25, 2026 at 09:48:22PM +0000, Matthew Wilcox wrote:
> Is there a reason not to do as DAX did:

> +#ifdef CONFIG_FS_VERITY
> #define S_VERITY (1 << 16) /* Verity file (using fs/verity/) */
> +#else
> +#define S_VERITY 0 /* Make all the verity checks disappear */
> +#endif
> #define S_KERNEL_FILE (1 << 17) /* File is in use by the kernel (eg. fs/cachefiles) */
> #define S_ANON_INODE (1 << 19) /* Inode is an anonymous inode */
>
>
> and then we can drop the CONFIG_FS_VERITY check here and in (at leaast)
> three other places

I looked into this, but wasn't entirely sure about all callers. Also
in at least some places we might need the barrier in fsverity_active,
so my plan was to see how many of the checks should simply be converted
to fsverity_active in a follow on and how much is left after that first.