From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 358D2D35669 for ; Wed, 28 Jan 2026 03:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ViVgnwX01BshlNoKeMMw71Zgm5O6mga4G/7kjKtYma0=; b=HOjwsMuD0MJTn7+dJ0hjiInuoQ qAPlfStDHg4pZw7eTxV7/U9VkDG+c//gw4Jaz7VbDzN2ADIc/qgeq6SuLxSZx/amYdopSz+WQ6HVd ZFI072KCw91AzreicALHKbszYDWDSG/4YQhRMMcWVc72iAdPsAgu13zII7Wsoi6w5GD8=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vkwR9-0002tM-ID; Wed, 28 Jan 2026 03:41:47 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vkwR8-0002tG-C4 for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Jan 2026 03:41:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8WNwQvuQreTemPKSkE9Ofh4ZJaaChEBZ96eOjcAAjpM=; b=amVIgCUQuutyfOnX0xmlA2o62J hK2+DNUxwyzqAo1cUlPfSkoXP/tjAawSAM3DDoJYEkaMIfqw0vg6idOQdWvhiaRu3c9++IVI3xMvj xELBoFBaOcMOOOEL/Eq/HIEn9ODjdJsfy1dRTSMP87ZEIyf69xU8Aiv/ec+RFXCxAQUQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8WNwQvuQreTemPKSkE9Ofh4ZJaaChEBZ96eOjcAAjpM=; b=GsKHQxf+TWhiso57OhNhXFEKdK 1Kig46/ztvYKEeX/3VdW40J9pZIej0qn6zfvkBsZ/3UeBqtuYsnTOrMFtU65tTHu551sF+/zVYJGT FXJ9+NzFbByRoEjCgoUfEs7stQZBfXdWdLBkH3rmDAJ9etpFD3NUPUChsgvz96K0blTM=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vkwR7-0000zR-Tt for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Jan 2026 03:41:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 42F9C6001A; Wed, 28 Jan 2026 03:41:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79AE0C4CEF1; Wed, 28 Jan 2026 03:41:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769571695; bh=34CW2N/dMbkFR7cyXaksGnhaLHYhfifPNLB5pSoQWJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dbwCTTNNtA2TKf57Dcgd/gAlPCfwSPJkzXB3I0ZjyGqro2OC4619YEMvb7YfHTNfM jbbinV6fx+3o6stxCiyTbER6NlHiabXHM2N0tJsuZYdqiA53a1y3FENrQCJUGd/QWZ KJ89SaP7IBuIx1QeDPYdGy+5fanThEWZyeXhXMIviAkumfjCalzL7OWk8+Kq7nV7k8 dMWmiOE1p5dO7wppx7RgSc1wDvLCR19Nt3jBuW3KtXQCkh4VYhPb5OKtosUKtClEpu 69vfH/WpL7e3WbzfuH7+Px8no6l4ad0AwmMuuYOe7xaD+Z8U7wSiaMdfA+BI+uODz7 vqATPSgpMFC4Q== Date: Tue, 27 Jan 2026 19:41:02 -0800 To: Christoph Hellwig Message-ID: <20260128034102.GC2718@sol> References: <20260126045212.1381843-1-hch@lst.de> <20260126045212.1381843-10-hch@lst.de> <20260128032203.GA2718@sol> <20260128033242.GA30830@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260128033242.GA30830@lst.de> X-Headers-End: 1vkwR7-0000zR-Tt Subject: Re: [f2fs-dev] [PATCH 09/16] fsverity: constify the vi pointer in fsverity_verification_context X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: fsverity@lists.linux.dev, Christian Brauner , Theodore Ts'o , Andrey Albershteyn , Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Al Viro , Jaegeuk Kim , David Sterba , Jan Kara , linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Jan 28, 2026 at 04:32:42AM +0100, Christoph Hellwig wrote: > On Tue, Jan 27, 2026 at 07:22:03PM -0800, Eric Biggers wrote: > > On Mon, Jan 26, 2026 at 05:50:55AM +0100, Christoph Hellwig wrote: > > > struct fsverity_info contains information that is only read in the > > > verification path. Apply the const qualifier to match various explicitly > > > passed arguments. > > > > > > Signed-off-by: Christoph Hellwig > > > --- > > > fs/verity/verify.c | 15 ++++++++------- > > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > > Did you consider that fsverity_info::hash_block_verified is written to? > > It's a pointer to an array, so the 'const' doesn't apply to its > > contents. But logically it's still part of the fsverity information. > > Well, it doesn't apply by the type rules. But if you don't like the > const here just let me know and I'll drop it. It just seems that the motivation is a bit weak. It works only because hash_block_verified happens to be a dynamic array, and also because the spinlock that used to be there got removed. And the very next patch removes const from the inode, so it kind of feels like we're going in two different directions. Maybe just drop this patch for now? - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel