From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06CE8D35668 for ; Wed, 28 Jan 2026 03:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pLIbX5zwb97YQJhkiksXQ3famanmCs4tbLzN9l4orAE=; b=IY9gPuyVvcZ/JFOWADnwvjGd9R Rt6MacZJHU+TAc/LSao6CVURQLp+iBcAOLinRv9l3wXd2/hG7GM9ZXNbOvpjO/Meu7Ydsg08F7dyn PAMwC+jSu1QGrL3mxmi0OV5zrmhSWBfULxTzwvu9TXupWslLtnWfgy0i1rJ9QqSge4kc=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vkwU6-0000Ol-LD; Wed, 28 Jan 2026 03:44:51 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vkwU5-0000OV-7I for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Jan 2026 03:44:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/LXIytMX+jd09O4G3j3iiwkfz4Rqdfw0zKOmNAceMmo=; b=SI8ZTZ2/r5QJoo6DQcyVtJLrS6 /fqDGqtmdIRFjgOzqpHa5gPBWPIPLghfVU9HL/Pm9bP2WPijJJmNyQtSADSwLbelpnYSYJQ7DSTSr rtdFFUIhwiR5ddijBLw+lqEvrgsJfNxN9xGOSTs1rqWYGEBWzUJg0WfXW0D6xgB8AQNI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/LXIytMX+jd09O4G3j3iiwkfz4Rqdfw0zKOmNAceMmo=; b=R69/AIWjGHNJiIOM70lSYfxEyf XUn1pVujPDLneT7+fx2uk1LOydLEkfN6b84P5opCYVuKEoISc1Rr/WKegthJpIgJ6CvET9dIFmi4X giriDI1KqJkmGzFjnpGq+22rOxAwrNJ1c+nNUxZlXDivb6BC8VYXDvHdVv+0iws3Q52U=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vkwU5-0001A7-KP for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Jan 2026 03:44:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 0C2C260007; Wed, 28 Jan 2026 03:44:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 388A4C4CEF1; Wed, 28 Jan 2026 03:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769571878; bh=AxsbRiz6g5OHmI8dfGU8IScrv9tHBdspZu1p6bmeGBE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P201+ebcahtveats5bhW2VJNT2y5qzZhA5UQq4K1H1t4r3j8dB204ErQtUZ4OVk7N YnWXZUkXX1CbW8uko3pPh+QLq4pWZLsSBJA9PvkIniP9ouFclwLqq3s7rzdJdnahiv F8uNjLjPV7RhubK6C9IlB690qAzIOrBIS168z1Jj9DAw594M2kV1u1lIAtTaU6frsL YVjDJT63xqbvutBpXCtTvsieBy0dKR44T1c1fyeRrNuX51xye8cn2hCQKzBf/PGuN2 y3G1FufZ7pMbsRJS+GieYovcevovNHI/9hjK7cqJDIpSxdqJz1BNQ/LggEt/fIz2Yr VqO+Ot3ttWEuA== Date: Tue, 27 Jan 2026 19:44:05 -0800 To: Christoph Hellwig Message-ID: <20260128034405.GD2718@sol> References: <20260126045212.1381843-1-hch@lst.de> <20260126045212.1381843-17-hch@lst.de> <20260128032817.GB2718@sol> <20260128033519.GB30830@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260128033519.GB30830@lst.de> X-Headers-End: 1vkwU5-0001A7-KP Subject: Re: [f2fs-dev] [PATCH 16/16] fsverity: use a hashtable to find the fsverity_info X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: fsverity@lists.linux.dev, Christian Brauner , Theodore Ts'o , Andrey Albershteyn , Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Al Viro , Jaegeuk Kim , David Sterba , Jan Kara , linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Jan 28, 2026 at 04:35:19AM +0100, Christoph Hellwig wrote: > > Is there a reason for this function in particular to be __always_inline? > > fsverity_get_info() is just inline. > > Without the __always_inline some gcc versions on sparc fail to inline it, > and cause a link failure due to a reference to fsverity_readahead in > f2fs_mpage_readpages for non-verity builds. (reported by the buildbot) The relevant code is: vi = f2fs_need_verity(inode, folio->index); if (vi) fsverity_readahead(vi, folio, nr_pages); Where: f2fs_need_verity() => fsverity_get_info() => fsverity_active() If fsverity_active() needs __always_inline, why don't the other two functions in the call chain need it? - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel