From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22CC7D73EB7 for ; Fri, 30 Jan 2026 05:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=injBlWUsZFjUM0//RYJ+uaBWM6Ibg17xrkWi1tYDJ0Y=; b=gVOSKl3QKBkD9qyxAhxpfxZ2vD b9+in26Seb1jPRDUhm/OTZ+/zjHVfT51ohAxZdWwcdsmnnzf58RV7xl14Ar+JBjXXpzX+MzSf9pOJ Fv1qm+s0o/fN+c+rvXF2hsy0wc1DonauuuQD/+yQdn6Dj9fGeh466dQaHNTQE5GEIyGU=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vlhTx-0002mH-Mt; Fri, 30 Jan 2026 05:55:50 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vlhTw-0002m6-Tl for linux-f2fs-devel@lists.sourceforge.net; Fri, 30 Jan 2026 05:55:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xknPMXANQugp2pyenTKzz5Q4Vhpi6GMGorWnu0Wyrv4=; b=ZvVvlQ78l+Ur1rDOX+2tMTw8Yc 3oMG4XSeczTX7wW99yJBkz9fLMHrnGPqJ2sseKzbi2yuC1X+LH4RrbIfgpld4ENoPiHWITtY2ogqx bn6wQOEAS7j/GN8YJ0nEJfu6EDfnBNTbKuxDVX+WHt6/754Ao4rmi3t4XPz4Shu4nDJk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xknPMXANQugp2pyenTKzz5Q4Vhpi6GMGorWnu0Wyrv4=; b=lMSxb0Bo6eeLVr9NI9iNFGCjqk 7JsTExIY5+LEzMiAFXiQlKJhvf/Aigwf9vZJfRH41BpAR2iZdhzbAEDFg0/uz3conTwwRsVN+9BOf DE63sWsLPqiQa9qrCYwcf1TBs8+BfeLqcMAbAqq5FXKJgnaUUDOCYQY9b3EDDmdfCPq4=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vlhTx-00022h-2L for linux-f2fs-devel@lists.sourceforge.net; Fri, 30 Jan 2026 05:55:49 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6D5F568AFE; Fri, 30 Jan 2026 06:55:41 +0100 (CET) Date: Fri, 30 Jan 2026 06:55:41 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Message-ID: <20260130055541.GC622@lst.de> References: <20260128152630.627409-1-hch@lst.de> <20260128152630.627409-9-hch@lst.de> <20260128225602.GB2024@quark> <20260128232213.GJ5900@frogsfrogsfrogs> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260128232213.GJ5900@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1vlhTx-00022h-2L Subject: Re: [f2fs-dev] [PATCH 08/15] fsverity: kick off hash readahead at data I/O submission time X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fsverity@lists.linux.dev, Christian Brauner , Jan Kara , Andrey Albershteyn , Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fsdevel@vger.kernel.org, Al Viro , Jaegeuk Kim , David Sterba , Theodore Ts'o , linux-ext4@vger.kernel.org, Christoph Hellwig , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Jan 28, 2026 at 03:22:13PM -0800, Darrick J. Wong wrote: > > Unfortunately, this patch causes recursive down_read() of > > address_space::invalidate_lock. How was this meant to work? > > Usually the filesystem calls filemap_invalidate_lock{,_shared} if it > needs to coordinate truncate vs. page removal (i.e. fallocate hole > punch). That said, there are a few places where the pagecache itself > will take that lock too... > [...] > ...except that pagecache_ra_unbounded is being called recursively from > an actual file data read. My guess is that we'd need a flag or > something to ask for "unlocked" readahead if we still want readahead to > spur more readahead. Basically just move it out of page_cache_ra_unbounded. With the consolidation in the earlier patches there are just two callers of page_cache_ra_unbounded left, this and the redirty_blocks() in f2fs. I'd kinda wish to kill the latter, as the past-EOF reading is something that should be restricted to core code, but I can't really think of an easy way to do that. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel