From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AB3310398B2 for ; Fri, 27 Feb 2026 21:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gsdbDCIDVJD0qC9MXZOqLQnXe4gLg8aD4qGFUU7szLg=; b=V6IssbgVFZjQO+Tn/gntDn1aw3 38YP4HNfh/l/3/DFniQ9MtxNpKy+oVtJl2HtjpERphiQoCs8e8QujAmr5Z/Vewmr9924bIxHSsqjb PeG9TAsW9PBKQj/hdMv+1tD7Ynd6N0U7oTX6f73kfUA76trUddV9/L45KZKWECzN+8vM=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vw5Cb-0001RB-6x; Fri, 27 Feb 2026 21:16:49 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vw5Ca-0001R4-Mi for linux-f2fs-devel@lists.sourceforge.net; Fri, 27 Feb 2026 21:16:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zXVfmxf4g/bnN/LYPTymK0sWVKMq8DJB0yar+wfUCgo=; b=a9j9C0LsaM+IfdmVlddT7/iQim rZMfRs/GYxC6064YPZHnHgFwSFn4z0wmYI8SpFXJbu1q8d9bkcOj/OUfwmWNZ9z19q/OONMXtuSEg Cwhky94lCyseS9/RTIKW8sWs7Sxim85hwNMS09ck6dNRzzY1v5CyvDaNJmkbean3EbQ4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zXVfmxf4g/bnN/LYPTymK0sWVKMq8DJB0yar+wfUCgo=; b=cmXFgdKhG/eQ2m9wQUfGpofcS7 sM0alZnJ9p6qQi+kM1Ki8unf9hUh3IWuu6zSVZlMEQOnKLJdd5rZfmWL6DvrQiEHg2x/A9sgGDjpt W6g36XdkCsgBJdOk/uHUvnvxt7V1z2TulcW7aa95zSg4uAOqZb410H6huNpydHYOVGrw=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vw5Ca-0005aq-AV for linux-f2fs-devel@lists.sourceforge.net; Fri, 27 Feb 2026 21:16:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0B1AD4363F; Fri, 27 Feb 2026 21:16:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F4098C116C6; Fri, 27 Feb 2026 21:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772227002; bh=IYVWg1WHxAiTLvaxqvVywcr6KglLqSKrG5o1wA/srJs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n9Y/HrUWuZUg8+lNeTyzL6gTo253Vmxl1ioHnAfR/Aw49uUiAtNG2CfzgiUzkQPnv i5wHzU2ZHD3Itr0lRNfzL2rLy5lO4IAwdYXDiLa1avnHMcu5omFm/imvcMJTEbprOA 65ZHdkbBbAdcqTPhW5d0hEmXXfLDwogzOWPs1j1DOIbIfzXmKLD1iMbzOj6DPgQWRj rokEjrjD8NyzHqZEf5OuPk7Q304WhRVSDKrP/ARW4BrDkqJA1RMQvdyQARjpohDELu zp7/mVlTgNARTjjmcQHQqvohZsVLz6Jq8iLNo4HPMcWhjMjRDViVvw8N3gWX2YYMam Us/UIEQtE2HHA== Date: Fri, 27 Feb 2026 13:16:39 -0800 To: Christoph Hellwig Message-ID: <20260227211639.GA2659@quark> References: <20260226144954.142278-1-hch@lst.de> <20260226144954.142278-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260226144954.142278-2-hch@lst.de> X-Headers-End: 1vw5Ca-0005aq-AV Subject: Re: [f2fs-dev] [PATCH 01/14] ext4: initialize the write hint in io_submit_init_bio X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: Christian Brauner , "Theodore Y. Ts'o" , "Darrick J. Wong" , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Andreas Dilger , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Feb 26, 2026 at 06:49:21AM -0800, Christoph Hellwig wrote: > Make io_submit_init_bio complete by also initializing the write hint. > > Signed-off-by: Christoph Hellwig > --- > fs/ext4/page-io.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index a8c95eee91b7..a3644d6cb65f 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -416,6 +416,7 @@ void ext4_io_submit_init(struct ext4_io_submit *io, > } > > static void io_submit_init_bio(struct ext4_io_submit *io, > + struct inode *inode, > struct buffer_head *bh) > { > struct bio *bio; > @@ -430,6 +431,7 @@ static void io_submit_init_bio(struct ext4_io_submit *io, > bio->bi_end_io = ext4_end_bio; > bio->bi_private = ext4_get_io_end(io->io_end); > io->io_bio = bio; > + io->io_bio->bi_write_hint = inode->i_write_hint; > io->io_next_block = bh->b_blocknr; > wbc_init_bio(io->io_wbc, bio); > } Maybe make this consistent with the other initializations by moving it up a line and doing: bio->bi_write_hint = inode->i_write_hint; - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel