From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 142BDEDA682 for ; Tue, 3 Mar 2026 15:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Bm27eeA+tPVA1vEWY2zNRez0a6sjVDInOS9K47dfUc=; b=iVYTZegkkR2GLV/XU9+ObVO6vO 9kVzgRXI1aXUuzLxTWvQv5s92Upe2D6jLqsumKxwwNEuJggqbkO+9Vog8912aJvInkwrS8PeF/bJl hf8D/dpPCjA4+Juo1spRR6KwSj3DLntjYVndneH7rgcCououpW1lXg2i9UZnrs4Y335I=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxRUg-00031C-Ru; Tue, 03 Mar 2026 15:17:07 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxRUd-00030t-JW for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Mar 2026 15:17:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=r6x2klXXgoU+8nt+Cp4vS5BDkY5WkDUr+eoNgGYMPDk=; b=JF0DVi5sTC+yhaNVmEklpuwDL3 M69L4QtX0wtmBfj3afg6Uai87qJW5YALcgUlqzzDf4+YzsSiNA2sCoP68GbN+q4ZG7OTCGbFQzsQu GvIBGwtaCytrSNj45+ylXRpUEYeEp5tXYnpSktG+KVnSHscrYxg409ZVPXlXu2AhOA/0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=r6x2klXXgoU+8nt+Cp4vS5BDkY5WkDUr+eoNgGYMPDk=; b=hCLDSYDJtWbaQh28Ne9SP2RIEj R0xjzE0+7vWjWkq8+oRyDn8C1USF3L1k6H3ql3I0ZZDtgBecHw7B1fe8Df6gCcAtjr9zkmceNQX4L 2CJcLsrkjnXulJJ+vD46IMPnTvbj1yedImDx61HMWERnwNQBN72CtVcLQGO5kjB/MsWE=; Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vxRUb-00072Q-72 for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Mar 2026 15:17:02 +0000 Received: from macsyma.thunk.org (pool-173-48-119-12.bstnma.fios.verizon.net [173.48.119.12]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 623FGHAc030962 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 Mar 2026 10:16:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1772550987; bh=r6x2klXXgoU+8nt+Cp4vS5BDkY5WkDUr+eoNgGYMPDk=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=KzTSOHRwT3LMbTHR0llsbZ8Elqs5CaJRZjxmNxQUFMAswuStpC31fs0yIcl+nwIjJ S3umgVQVGgNt1Oz1RTpJYxeDOSLWGS1lQWG0OF06WsyJthAOHPTEk63HFB378Gc+Z1 7AClTaSOQ+KtiOBjb8/C0ZU9vmqyHEnX8NnBL8RHxXhXKgJeC3i83ujxFmi6vH0p2g D27eKVQpmNlyvbKzOT3QHfYP30GkVsl3F2eGSBkR3cTjNKb8X0Ca5cSjf7eotj62mj 8tAKE8+0/pvSZn9wBTBUATHjwH/dtOFEvj1uXh0ceQlfb2thD+EORwMqde/Ys1tqiQ fLxLTxyRvRmmw== Received: by macsyma.thunk.org (Postfix, from userid 15806) id 99AD45ADBA78; Tue, 3 Mar 2026 10:16:17 -0500 (EST) Date: Tue, 3 Mar 2026 10:16:17 -0500 From: "Theodore Tso" To: Jeff Layton Message-ID: <20260303151617.GD6520@macsyma-wired.lan> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> <20260303012556.GA6520@macsyma-wired.lan> <20260303042546.GF13868@frogsfrogsfrogs> <33228005140684201de2ca0c157441d3b6a06413.camel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <33228005140684201de2ca0c157441d3b6a06413.camel@kernel.org> X-Headers-End: 1vxRUb-00072Q-72 Subject: Re: [f2fs-dev] [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , nvdimm@lists.linux.dev, Paulo Alcantara , "Darrick J. Wong" , Anders Larsen , dri-devel@lists.freedesktop.org, linux-sctp@vger.kernel.org, linux-hams@vger.kernel.org, Sumit Semwal , Mike Marshall , linux-xfs@vger.kernel.org, Fan Wu , Xin Long , ceph-devel@vger.kernel.org, James Morris , Tyler Hicks , Christoph Hellwig , devel@lists.orangefs.org, Shyam Prasad N , Martin Schiller , Jesper Dangaard Brouer , Jan Harkes , Willem de Bruijn , Arnaldo Carvalho de Melo , linux-fscrypt@vger.kernel.org, Alexander Viro , Ronnie Sahlberg , John Paul Adrian Glaubitz , David Hildenbrand , Eric Van Hensbergen , Magnus Karlsson , Christian Brauner , Dmitry Kasatkin , Stephen Smalley , linux-kernel@vger.kernel.org, Eric Paris , linux-perf-users@vger.kernel.org, Chuck Lever , Masami Hiramatsu , Jiri Olsa , Jan Kara , Alex Deucher , linux-media@vger.kernel.org, Trond Myklebust , Mark Rutland , Dave Kleikamp , Mimi Zohar , Oleg Nesterov , Eric Dumazet , Johan Hedberg , Simona Vetter , linux-cifs@vger.kernel.org, Kuniyuki Iwashima , linux-nilfs@vger.kernel.org, Paul Moore , John Fastabend , Remi Denis-Courmont , linux-trace-kernel@vger.kernel.org, Olga Kornievskaia , Maciej Fijalkowski , Yangtao Li , selinux@vger.kernel.org, v9fs@lists.linux.dev, linux-can@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Casey Schaufler , netfs@lists.linux.dev, Jaegeuk Kim , fsverity@lists.linux.dev, Nicolas Pitre , Muchun Song , Roberto Sassu , "David S. Miller" , Anna Schumaker , linux-integrity@vger.kernel.org, Marcelo Ricardo Leitner , Luiz Augusto von Dentz , Alex Markuze , Martin Brandenburg , Alexander Shishkin , ocfs2-devel@lists.linux.dev, Alexei Starovoitov , linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, Marc Dionne , Neal Cardwell , linux-afs@lists.infradead.org, Ian Kent , Naohiro Aota , Eric Biggers , Daniel Borkmann , Miklos Szeredi , Matthew Wilcox , coda@cs.cmu.edu, Stanislav Fomichev , Viacheslav Dubeyko , NeilBrown , Ilya Dryomov , Paolo Abeni , jfs-discussion@lists.sourceforge.net, "Serge E. Hallyn" , Amir Goldstein , James Clark , autofs@vger.kernel.org, Steven Rostedt , Damien Le Moal , Mathieu Desnoyers , Dan Williams , Oscar Salvador , Konstantin Komarov , linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, samba-technical@lists.samba.org, Ondrej Mosnacek , Steve French , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, ntfs3@lists.linux.dev, Christian =?iso-8859-1?Q?K=F6nig?= , Ian Rogers , Alexander Aring , Jan Kara , Peter Zijlstra , Dominique Martinet , Christian Schoenebeck , ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, David Howells , Joseph Qi , Andreas Dilger , Mikulas Patocka , linux-f2fs-devel@lists.sourceforge.net, David Airlie , Steffen Klassert , Eric Snowberg , Herbert Xu , linux-x25@vger.kernel.org, linux-bluetooth@vger.kernel.org, Richard Weinberger , Mark Fasheh , Dai Ngo , Ingo Molnar , Jakub Kicinski , Salah Triki , Marcel Holtmann , Joerg Reuter , codalist@telemann.coda.cs.cmu.edu, Simon Horman , apparmor@lists.ubuntu.com, Tom Talpey , Bharath SM , Marc Kleine-Budde , "Tigran A. Aivazian" , David Sterba , Namhyung Kim , Ryusuke Konishi , John Johansen , Luis de Bethencourt , Oliver Hartkopp , David Ahern , Adrian Hunter , audit@vger.kernel.org, linux-security-module@vger.kernel.org, Johannes Thumshirn , David Woodhouse , Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Mar 03, 2026 at 05:53:39AM -0500, Jeff Layton wrote: > > Like I said to Ted, this is just temporary scaffolding for the change. > The PRIino macro is removed in the end. Given that, perhaps you can > overlook the bikeshed's color in this instance? I didn't realize that this was going to disappear in the end. That makes me feel much better about the change. I'd suggest changing the commit description where it claims that we're using something that follows the inttypes.h convention and making it clear that this is temporary and only to preserve bisectability. One question though --- are there *really* places that are using signed inode numbers and trying to print them? If people are trying to use negative inodes to signal an error or some such, the it implies that at least for some file systems, an inode number larger than 2**63 might be problematic. If there is core VFS code that uses a negative inode number then this could be a real potential trap. So are there really code which is doing a printf of 'PRIino "d"'? Or was this to allow the use of of 'PRiino "x"'? - Ted _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel