From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2FF5FAD3E2 for ; Wed, 22 Apr 2026 23:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:In-Reply-To:References:Message-Id: MIME-Version:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xiJQEFUEhNt2OxLgrA0BqcXe8Fn37LpqyLk1fWSUZEE=; b=Uu/OfKjFe+CDLD60ox3hHGUMBn kP/ssJIbWXfdl9h1wQOiYypSMqGG7xF2DvXLGQdjCZBkcBKIFLb+v9BISQpRGS7pBnMDAaDsvDy81 Q7FW29fhSrubjVq28aEkKO0zkYafDWLcKRj/X/2W4tv3bgmelMVljp0ErN3ZMc77cBm0=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wFh2D-0001DN-Jn; Wed, 22 Apr 2026 23:31:09 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wFh2C-0001DD-O3 for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Apr 2026 23:31:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Zd3EBBNCQGeY5tGPvbpVxdrZKnSVQZtJnnMaFjbdmpk=; b=bmWm6d+Z0wIslWHun4pvunZvUf FrYH2YIQdz1/p1oDWTQ/1i9qZ3T2jjh3JHeHjgHM/9MaagDZFRSVPOgOAHk5bc4NseWPkWoP7Ewah HFylo6oYQXJ698MDyfJJMnYdoIkk8pJGCOeI7i61mnzo7BuxaSt9byouxfsxFri9l84Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Zd3EBBNCQGeY5tGPvbpVxdrZKnSVQZtJnnMaFjbdmpk=; b=iR9uABCAhkrAEr1PB3gNWduwpn A/kMNIvEUTCGTGIg6pO1FyxH6t+HpVQ4mNYXiHP1E9+z7X6wkLvyBIl3lc7iqHENwPKQSiMTMdr00 mCNFqRdHTQ1FAAhaJWjyaijuLJFKrRYKvG/LycZyD+xY6ABjVRqNRbzrz+WAvMHQytBw=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wFh2C-0006fv-7F for linux-f2fs-devel@lists.sourceforge.net; Wed, 22 Apr 2026 23:31:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E5FF041694; Wed, 22 Apr 2026 23:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A46D4C19425; Wed, 22 Apr 2026 23:30:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776900657; bh=yGB+SiukKqXG153GFiqJqhuat+PctFhKpyG9E7K2Nwk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=WEOVPlYiy41FokHzJ/G3c6LQEKjEa140BOLBum2ty56e48W5ncchnQm34HxR1orSK 2j3/TOEzx3WBAwpBlet9UiukU9BnswuxpxPCaAv9NnjM0S8HpZU7YQbpOla3YL4f2Q 9Hr4PqJx1YDEFGUhFrjOLoy8EOGinKE9n1UYd5AZC3Zs0QpmP2HXLGnoaP2cJt3VNw iCzI43DWk8neu38UTOipBATiQgLD2nM3EFEwiaOiibCD/06RwM/whf2hhZe5KAUguJ JEa54CvrQdbBVNX+tki2kUGuYTCFFXeamDcxo+8BvTPdlhZkLwNXADC3biNTMLmU+p ROjyOUWLFL8wQ== Date: Wed, 22 Apr 2026 19:30:11 -0400 MIME-Version: 1.0 Message-Id: <20260422-case-sensitivity-v9-17-be023cc070e2@oracle.com> References: <20260422-case-sensitivity-v9-0-be023cc070e2@oracle.com> In-Reply-To: <20260422-case-sensitivity-v9-0-be023cc070e2@oracle.com> To: Al Viro , Christian Brauner , Jan Kara X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2564; i=chuck.lever@oracle.com; h=from:subject:message-id; bh=2nS1LtlO/vmrzHVVaUmzB5jhcNO5BsoFT5yc1yYmaA0=; b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp6VoGIYmy6NHTYqRGKLzunLRkH1VFkkmk3nfRE QrXoqRc1COJAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCaelaBgAKCRAzarMzb2Z/ l9JtD/4lsYqo5MVTwAVbK3MDQFPfipoXxMx5tsyzwfZh40XeahxwjqXXRMFQSRuwY2jQOg3BV0E 4lEofWunivHzQWh1Cgt3noIh70i3Luw+mbNRpnphdJjx0qQTqmk4CG26zOMfw8y131burjTqlgB Xtbsi9CV2FsqzJKt3W9KvuWnHvO9044tzCl6Pv2cJVReaHFTSTGAVuoX/7eC1yeNaV0joaNCdHQ VkH7niDabdUGlxJ09K/Zu5Nml+Jl/VrPiiU5NWzpVRJ8S7b4nK6TNTSBGHVBme52ClcHBNXbHEF YBgUu2JZJxOpDk78wzMaTPjmhoSBgKHx0poogwNRXVZS2FwcmVFmOPitYhsO/mTB8FVc53Y292J rLeBq1vL0NSVWqpSd9bZ1hZXroaukxXGY190syIzT26bZ3IdG0WQJX2eNXyEe3/gQPYOmvIBm9b 1j0M+glgCryYZ7AqyQBnNUfYrxcOxdQu0Evs8DprN6ptEi9Cm6xpliHtzJqK974zY6J6udmG89f wTzKocypE6W2wNP2MzL7BJwUcYq9CQ7CFjqHN4IRCg08iKjjtI72VQq/wPOnZs2PHjCq+DJtDlR GlWEXv230nLY/lXAYUa+0ijVG6ZfkjDXPSui+aKmqM6UhKWIbnSID54OjV9Voi4iTsGAZwA6A1r ufg5mxTsl+M9YvA== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 X-Headers-End: 1wFh2C-0006fv-7F Subject: [f2fs-dev] [PATCH v9 17/17] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chuck Lever via Linux-f2fs-devel Reply-To: Chuck Lever Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org, almaz.alexandrovich@paragon-software.com, adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org, sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org, linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com, ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de, jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp, linux-nfs@vger.kernel.org, tytso@mit.edu, linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, senozhatsky@chromium.org, Chuck Lever , hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com, trondmy@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Chuck Lever FS_ATTRIBUTE_INFORMATION responses have always reported FILE_CASE_SENSITIVE_SEARCH and FILE_CASE_PRESERVED_NAMES unconditionally. Case-insensitive filesystems like exFAT, and casefolded directories on ext4 or f2fs, have no way to signal their actual semantics to SMB clients. Now that filesystems expose case behavior through ->fileattr_get, query it via vfs_fileattr_get() and translate the FS_XFLAG_CASEFOLD and FS_XFLAG_CASENONPRESERVING flags into the corresponding SMB attributes. Filesystems without ->fileattr_get continue reporting default POSIX behavior (case-sensitive, case-preserving). SMB's FS_ATTRIBUTE_INFORMATION reports per-share attributes from the share root, not per-file. Shares mixing casefold and non-casefold directories report the root directory's behavior. Acked-by: Namjae Jeon Signed-off-by: Chuck Lever --- fs/smb/server/smb2pdu.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index ee32e61b6d3c..7e91b578ca28 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -14,6 +14,7 @@ #include #include #include +#include #include "glob.h" #include "smbfsctl.h" @@ -5541,16 +5542,28 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work, case FS_ATTRIBUTE_INFORMATION: { FILE_SYSTEM_ATTRIBUTE_INFO *info; + struct file_kattr fa = {}; size_t sz; + u32 attrs; + int err; info = (FILE_SYSTEM_ATTRIBUTE_INFO *)rsp->Buffer; - info->Attributes = cpu_to_le32(FILE_SUPPORTS_OBJECT_IDS | - FILE_PERSISTENT_ACLS | - FILE_UNICODE_ON_DISK | - FILE_CASE_PRESERVED_NAMES | - FILE_CASE_SENSITIVE_SEARCH | - FILE_SUPPORTS_BLOCK_REFCOUNTING); + attrs = FILE_SUPPORTS_OBJECT_IDS | + FILE_PERSISTENT_ACLS | + FILE_UNICODE_ON_DISK | + FILE_SUPPORTS_BLOCK_REFCOUNTING; + err = vfs_fileattr_get(path.dentry, &fa); + if (err && err != -ENOIOCTLCMD) { + path_put(&path); + return err; + } + if (!(fa.fsx_xflags & FS_XFLAG_CASEFOLD)) + attrs |= FILE_CASE_SENSITIVE_SEARCH; + if (!(fa.fsx_xflags & FS_XFLAG_CASENONPRESERVING)) + attrs |= FILE_CASE_PRESERVED_NAMES; + + info->Attributes = cpu_to_le32(attrs); info->Attributes |= cpu_to_le32(server_conf.share_fake_fscaps); if (test_share_config_flag(work->tcon->share_conf, -- 2.53.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel