From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 545D3CD3427 for ; Thu, 7 May 2026 08:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:In-Reply-To:References:Message-Id: MIME-Version:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9BA49TW7+endGm8XrfNUT5ypQhjQZpR0C8ZSutZM+w4=; b=ZtsgM3ioteminH89QjcvRNl40h K7cThJeQfdbRkx33dEV5AQbbb4w14LO8o7GmQG+sifyQqRzJzSnJOxhIy2hNXz14GpUjPKXj1+Rgy t7AMSyv2ANzk6bXmo50CMZOCGBUI+e8rxtLdlaGH+guL2IUslSDj2dis/W1LcEQObUpo=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wKuUC-0005Xy-0K; Thu, 07 May 2026 08:53:36 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wKuUA-0005Xs-QC for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2026 08:53:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bLYGD8UhEfZ0gI1O0q/9fKsjTL83YjgnGhMcoMvuzIo=; b=Xe3iyng7K/vOmBqzUFYt6T+C/Y T3mAd5G8Emkl4lRY1aTSdQXtmZ316gXp0pasXec8khw5VgSuhV4UmfO5wwFJfwMakmMLkn0X3XReF YdbXBDLf6fKuEA/nOcbhefVaRJeqbtP1+aHKFIGLRQZslIDyCZaeORh/HmcIJf+vH/lo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bLYGD8UhEfZ0gI1O0q/9fKsjTL83YjgnGhMcoMvuzIo=; b=iJ1221HwJu1QSu+xvMGTToj+rM GbFvRyIQpZrObpeTzPLnHbaR1PXXQvqJFpnZlQ2MnnMkc9OnfH++SKtyhK9Pn1kDoorB/egXSo2g5 ncsD4l4TLxwLi1SCF4E347uiO4QiFDgCDheeNS4QEOVx+Pj9LRwJO8KwSKev7wYcGshc=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wKuUA-00028l-2t for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2026 08:53:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C462943BBA; Thu, 7 May 2026 08:53:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33960C2BCB2; Thu, 7 May 2026 08:53:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778144008; bh=93lkf1HBQv1pjT23tKqszLwADekuVqw95GHVpFk/qSc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=mZvNGIf9tbbRgwEmL1IX43i678VLpOXozRrR08Dnf5wGdcfk+YTjIl5W0bKHc2vyq qHmNTfjauwBVna4ywyHHJYSdGg33PKTHOKmpurYQh20oILMR6KTzKk3MV2awRN9tE5 17Ll4kLYTjKq3NdI/h6gMg3LVIxiaj5KZaQH2N3/FI1qAG5/DKqQEDVVLyvLMWLIWA 9qCEqvOjNWfio21JMSNDYBcmu6KBpul2MMUwqclycpdBK94QXVEmhb73qabNaV1Klk ZhI25Him/SxqrweeMABlhh1VmWuyQ9v2h0xEl8ZSAWLUi+TK1J2OZQxCgn/kUvGRTP G4dUpti4Vb7kA== Date: Thu, 07 May 2026 04:52:54 -0400 MIME-Version: 1.0 Message-Id: <20260507-case-sensitivity-v14-1-e62cc8200435@oracle.com> References: <20260507-case-sensitivity-v14-0-e62cc8200435@oracle.com> In-Reply-To: <20260507-case-sensitivity-v14-0-e62cc8200435@oracle.com> To: Al Viro , Christian Brauner , Jan Kara X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=3605; i=chuck.lever@oracle.com; h=from:subject:message-id; bh=AWgZwG1E8rlvIL3m0PCLX9DfISmeBrTqPl/lfHkVgk0=; b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp/FL16M1JzToUSuCpZmfb9ISP0Yb3U7s9zGQgt oYjDlZVzZ+JAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCafxS9QAKCRAzarMzb2Z/ l3BzEACGzFrS/32BQckCPrBzk/xgZqzqC881Ip6a/vBEbYz1SK414wXOlH85WVN2d29H8fonAcz adYqB5qbp+v8T+9duTlUWaBQJt2vopPdB2O6RF2XC5XsIm4VEIsvq8LThmv/mhqQeXiEt75OGbB HR7ngShmQ2F5TubIp6Z43XdL7MAKtH1GdJnaYyTI5MJVz+wPs5vAXSAP93w+xJw0vMQB1U10jmO GDwJuyKrW6RD1HO7iDqj0biwRMzY/vStbWm/mILezbREu77aVBYxCJxlIDIzld1Ro+ySyeyiIB4 NE3tHEdGHfbDZiSeMn67NgyAVCdFWgHh+pZDJpJH5uNU/T8VEGwOjrCpXDUfIcOPYXOtYNSH5xK J9z7xXIjsh1OFQip8qPnxaX1WVDaZrqgSYUaT5+tdfxm2H5tY6LlIncs+VrVwlOcLSDTd1JljzV P8tMa3wDGF+OLS90vgNuS2ftLY8V6upZwWVu5el/x4CQWfYUt+oFXkUQPieNd4u8d+VK+5GIwOZ HXh6xKpUG6kbTTgV3uU58KREEyyVCMS5OJBd9zdpKvjrp/KFLx+/McybdERdd3QWcr7SOCwyvNp F99tUGm9K4lUktBvxzstOywNKvikf4vJaWpyLCkEHtCWLL0xd1/gwAWFdBm//DwJ1QUvcF4yV1c E7GRVRlfxnZJb0w== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 X-Headers-End: 1wKuUA-00028l-2t Subject: [f2fs-dev] [PATCH v14 01/15] fs: Move file_kattr initialization to callers X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chuck Lever via Linux-f2fs-devel Reply-To: Chuck Lever Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org, Roland Mainz , almaz.alexandrovich@paragon-software.com, adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org, sfrench@samba.org, slava@dubeyko.com, "Darrick J. Wong" , linux-ext4@vger.kernel.org, linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com, ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de, jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp, linux-nfs@vger.kernel.org, tytso@mit.edu, linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, senozhatsky@chromium.org, Chuck Lever , hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com, trondmy@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Chuck Lever fileattr_fill_xflags() and fileattr_fill_flags() memset the entire file_kattr struct before populating select fields, so callers cannot pre-set fields in fa->fsx_xflags without having their values clobbered. Darrick Wong noted that a function named "fill_xflags" touching more than xflags forces callers to know implementation details beyond its apparent scope. Drop the memset from both fill functions and initialize at the entry points instead: ioctl_setflags(), ioctl_fssetxattr(), the file_setattr() syscall, and xfs_ioc_fsgetxattra() now declare fa with an aggregate initializer. ioctl_getflags(), ioctl_fsgetxattr(), and the file_getattr() syscall already aggregate-initialize fa to pass flags_valid/fsx_valid hints into vfs_fileattr_get(). Subsequent patches rely on this so that ->fileattr_get() handlers can set case-sensitivity flags (FS_XFLAG_CASEFOLD, FS_XFLAG_CASENONPRESERVING) in fa->fsx_xflags before the fill functions run. Suggested-by: Darrick J. Wong Reviewed-by: Jan Kara Reviewed-by: Darrick J. Wong Reviewed-by: Roland Mainz Signed-off-by: Chuck Lever --- fs/file_attr.c | 12 ++++-------- fs/xfs/xfs_ioctl.c | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/fs/file_attr.c b/fs/file_attr.c index da983e105d70..f429da66a317 100644 --- a/fs/file_attr.c +++ b/fs/file_attr.c @@ -15,12 +15,10 @@ * @fa: fileattr pointer * @xflags: FS_XFLAG_* flags * - * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). All - * other fields are zeroed. + * Set ->fsx_xflags, ->fsx_valid and ->flags (translated xflags). */ void fileattr_fill_xflags(struct file_kattr *fa, u32 xflags) { - memset(fa, 0, sizeof(*fa)); fa->fsx_valid = true; fa->fsx_xflags = xflags; if (fa->fsx_xflags & FS_XFLAG_IMMUTABLE) @@ -48,11 +46,9 @@ EXPORT_SYMBOL(fileattr_fill_xflags); * @flags: FS_*_FL flags * * Set ->flags, ->flags_valid and ->fsx_xflags (translated flags). - * All other fields are zeroed. */ void fileattr_fill_flags(struct file_kattr *fa, u32 flags) { - memset(fa, 0, sizeof(*fa)); fa->flags_valid = true; fa->flags = flags; if (fa->flags & FS_SYNC_FL) @@ -325,7 +321,7 @@ int ioctl_setflags(struct file *file, unsigned int __user *argp) { struct mnt_idmap *idmap = file_mnt_idmap(file); struct dentry *dentry = file->f_path.dentry; - struct file_kattr fa; + struct file_kattr fa = {}; unsigned int flags; int err; @@ -357,7 +353,7 @@ int ioctl_fssetxattr(struct file *file, void __user *argp) { struct mnt_idmap *idmap = file_mnt_idmap(file); struct dentry *dentry = file->f_path.dentry; - struct file_kattr fa; + struct file_kattr fa = {}; int err; err = copy_fsxattr_from_user(&fa, argp); @@ -431,7 +427,7 @@ SYSCALL_DEFINE5(file_setattr, int, dfd, const char __user *, filename, struct path filepath __free(path_put) = {}; unsigned int lookup_flags = 0; struct file_attr fattr; - struct file_kattr fa; + struct file_kattr fa = {}; int error; BUILD_BUG_ON(sizeof(struct file_attr) < FILE_ATTR_SIZE_VER0); diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 46e234863644..ed9b4846c05f 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -517,7 +517,7 @@ xfs_ioc_fsgetxattra( xfs_inode_t *ip, void __user *arg) { - struct file_kattr fa; + struct file_kattr fa = {}; xfs_ilock(ip, XFS_ILOCK_SHARED); xfs_fill_fsxattr(ip, XFS_ATTR_FORK, &fa); -- 2.53.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel