From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18580CD3427 for ; Thu, 7 May 2026 08:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:In-Reply-To:References:Message-Id: MIME-Version:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HX3OZ2UZXoPYaHaSVt+KYjAkWIBbSQJsuzolOcxlABQ=; b=HNankhiw8OC/6KYzqZYSHuEQkL KivCehB5naxFuwKeB+eLyBfOxYHbPGdcgq7H0dT+uZQCAV7ckG1ADGrQ1A/2DzFBswABTMyU5eRc7 qtDXg6YJ1xJqVQxIaoMZYrpGPehgnTZ3i0JaMd+3m2bFej9BECtuxi4fSMgXVhVNKjZw=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wKuVr-0005pk-OZ; Thu, 07 May 2026 08:55:19 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wKuVq-0005pT-IL for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2026 08:55:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eHU5vEtvFf8gW2kW65c93S0sL65ucaaiMFs0jpTrmoE=; b=Jy8XPUA8NHlFFIe94EVrG3ajtW NtOl8wJyPLhiDY+3SBVdaUzI3pAKOwFtvqrZ+/Fh4qVZOu8vpLD0bJ/S4EKS1y2MxonhCTiaSlhp3 nSezi+46BkwPA+Sr1JwuoPaa5X+Vl4QOaNHr4skFjPhJQsKqtrV6PzQKEoDWgUmWgz28=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eHU5vEtvFf8gW2kW65c93S0sL65ucaaiMFs0jpTrmoE=; b=gmoPKiodHh72Wyj7wxnxOh261O uzbsE2h6yF1okdHbPzT8841DDRjrY2IxiZet+noWxZvLWR2XlSQgowI4SQ1xKWvZBRjo6tnbMWi18 Uj5uW85CnZo2TMMhtToF3ZXDy27VmLplcwjdngw4GrQ5Oq6cFrWFebS45mskv5IuSvyw=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wKuVp-0002GV-FY for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2026 08:55:18 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 2FD864036C; Thu, 7 May 2026 08:55:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98526C2BCB2; Thu, 7 May 2026 08:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778144107; bh=yLWlWt9V9Y5GGjXgBQKVgu1PJw/giK9+7A2pF5f40rk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=DgVF/ZHeV+kuGyAWmVI6pYtPDmHwEyTaC/1dkxbE09rooY6ON3S2YqhNJLhtxWNnz v4h9eHHEh1I7/1MjNDRzoD4ccip6pzQVvi1+cmgeHr7IYO8gxVFD7qVsnPab/61e0X rgSkMMzi1DI7pbs8qwMaxriGsvPphFCHwPupLVRY7K3dK+1cCHgF4WHykAVQKz4xov 40LtclGOjQS5ak28bdxbgnOYfMSw4mw92Lur47qX/ILVjgdp5K74SDxwDTljYYeafN AFb9ah+FgVebRtSJxqTs4qEGY8DXAVgLlwoMCbCQLMUkDHTZA51BamoHhYVwGKsmhu S+NvMcusUwFdA== Date: Thu, 07 May 2026 04:53:07 -0400 MIME-Version: 1.0 Message-Id: <20260507-case-sensitivity-v14-14-e62cc8200435@oracle.com> References: <20260507-case-sensitivity-v14-0-e62cc8200435@oracle.com> In-Reply-To: <20260507-case-sensitivity-v14-0-e62cc8200435@oracle.com> To: Al Viro , Christian Brauner , Jan Kara X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=4953; i=chuck.lever@oracle.com; h=from:subject:message-id; bh=5/2C2emITzAWN8Je7PbhdbbMkvvYBrugawZoWYBZ60w=; b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp/FL2KxHLyffiYrb1ic3za8sMFG9zo+OQsbJdi jfmUL/mPIeJAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCafxS9gAKCRAzarMzb2Z/ lz07D/9TSIMf0tbC8Ba0i9jMTBBDddV4dk65yZI5JIWciCRrg55cmdAQkhiDKOxajwU1ZK0BotD lzvs7dV+QxIMJvWR04Ay3u+Mq2qcPSsQ4vHXujHGry/kEHA6CPonitmONSH43kcRwRRYqTNRTbZ 6mv3sSJ96W7D9vhL8a/hD12W4e7E9RZOMPaWrFbGhDcbfkJJ5Q13jzAcBaZDDoXfdL/1NHAECkH uccSYYejdB+5kISMwCSj8ukXz3RaVVFLz4p0pfoqNE8G0ORDw3IDOx6nwRJ37AsMrDqhOlCQXJ7 Eci/NYR+2TKzfQHjefMFLsv3/kHnBl9jx0Xvnb2Dz7zCI79nICBygT35nhOqtjyjUx00Hifpcva GdTSLyBIv4FjfmV4h3SaUlgiHqBAYsbgod9GI9bRIe8vbHJi8JZB010Q2F0wjZf4ejE9Rxxr+PC ofIze9YCs5xFjwevnHTtV5gpbSnATGp0pSCoWgHgd48lpFJ65qNU94+yNAlkKh/C5BQsf2aHuhC CdPPgm73p31m7P5HTwbm0CyWX2RLqt0gd7tkYWZnoWDUQgOCC6gLkkDiPqN4cKVilEQanENN/zJ XBoN7lMKZ5Z9nCMMkF8KF8MV86Fq+xHRB8XI0wwuyw4HjkA/oiO6YVW4hwBwp19twoId72SkRlF EAWeEuxYnFD5Uhw== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 X-Headers-End: 1wKuVp-0002GV-FY Subject: [f2fs-dev] [PATCH v14 14/15] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chuck Lever via Linux-f2fs-devel Reply-To: Chuck Lever Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org, Roland Mainz , almaz.alexandrovich@paragon-software.com, adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org, sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org, linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com, ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de, jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp, linux-nfs@vger.kernel.org, tytso@mit.edu, linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, senozhatsky@chromium.org, Chuck Lever , hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com, trondmy@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Chuck Lever NFSD currently provides NFSv4 clients with hard-coded responses indicating all exported filesystems are case-sensitive and case-preserving. This is incorrect for case-insensitive filesystems and ext4 directories with casefold enabled. Query the underlying filesystem's actual case sensitivity via nfsd_get_case_info() and return accurate values to clients. This supports per-directory settings for filesystems that allow mixing case-sensitive and case-insensitive directories within an export. The helper queries the parent dentry for non-directory filehandles because case-folding is a per-directory property. That resolution has the same corner cases here as for NFSv3 PATHCONF: single-file exports query an unexported parent, disconnected dentries report defaults until reconnected, and hardlinked files track whichever alias the dcache currently holds. Reviewed-by: Roland Mainz Signed-off-by: Chuck Lever --- fs/nfsd/nfs4xdr.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 2a0946c630e1..319007b79d49 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -3158,6 +3158,8 @@ struct nfsd4_fattr_args { u32 rdattr_err; bool contextsupport; bool ignore_crossmnt; + bool case_insensitive; + bool case_preserving; }; typedef __be32(*nfsd4_enc_attr)(struct xdr_stream *xdr, @@ -3356,6 +3358,33 @@ static __be32 nfsd4_encode_fattr4_acl(struct xdr_stream *xdr, return nfs_ok; } +static __be32 nfsd4_encode_fattr4_case_insensitive(struct xdr_stream *xdr, + const struct nfsd4_fattr_args *args) +{ + return nfsd4_encode_bool(xdr, args->case_insensitive); +} + +static __be32 nfsd4_encode_fattr4_case_preserving(struct xdr_stream *xdr, + const struct nfsd4_fattr_args *args) +{ + return nfsd4_encode_bool(xdr, args->case_preserving); +} + +static __be32 nfsd4_encode_fattr4_homogeneous(struct xdr_stream *xdr, + const struct nfsd4_fattr_args *args) +{ + /* + * Casefold-capable filesystems (e.g. ext4 or f2fs with the + * casefold feature) attach a Unicode encoding at mount time + * but apply case folding per directory. The per-file-system + * case_insensitive and case_preserving values can therefore + * legitimately differ across objects that share the same fsid. + * Report FATTR4_HOMOGENEOUS = FALSE on such filesystems to + * keep that variation consistent with RFC 8881 Section 5.8.2.16. + */ + return nfsd4_encode_bool(xdr, !sb_has_encoding(args->dentry->d_sb)); +} + static __be32 nfsd4_encode_fattr4_filehandle(struct xdr_stream *xdr, const struct nfsd4_fattr_args *args) { @@ -3748,8 +3777,8 @@ static const nfsd4_enc_attr nfsd4_enc_fattr4_encode_ops[] = { [FATTR4_ACLSUPPORT] = nfsd4_encode_fattr4_aclsupport, [FATTR4_ARCHIVE] = nfsd4_encode_fattr4__noop, [FATTR4_CANSETTIME] = nfsd4_encode_fattr4__true, - [FATTR4_CASE_INSENSITIVE] = nfsd4_encode_fattr4__false, - [FATTR4_CASE_PRESERVING] = nfsd4_encode_fattr4__true, + [FATTR4_CASE_INSENSITIVE] = nfsd4_encode_fattr4_case_insensitive, + [FATTR4_CASE_PRESERVING] = nfsd4_encode_fattr4_case_preserving, [FATTR4_CHOWN_RESTRICTED] = nfsd4_encode_fattr4__true, [FATTR4_FILEHANDLE] = nfsd4_encode_fattr4_filehandle, [FATTR4_FILEID] = nfsd4_encode_fattr4_fileid, @@ -3758,7 +3787,7 @@ static const nfsd4_enc_attr nfsd4_enc_fattr4_encode_ops[] = { [FATTR4_FILES_TOTAL] = nfsd4_encode_fattr4_files_total, [FATTR4_FS_LOCATIONS] = nfsd4_encode_fattr4_fs_locations, [FATTR4_HIDDEN] = nfsd4_encode_fattr4__noop, - [FATTR4_HOMOGENEOUS] = nfsd4_encode_fattr4__true, + [FATTR4_HOMOGENEOUS] = nfsd4_encode_fattr4_homogeneous, [FATTR4_MAXFILESIZE] = nfsd4_encode_fattr4_maxfilesize, [FATTR4_MAXLINK] = nfsd4_encode_fattr4_maxlink, [FATTR4_MAXNAME] = nfsd4_encode_fattr4_maxname, @@ -3968,6 +3997,23 @@ nfsd4_encode_fattr4(struct svc_rqst *rqstp, struct xdr_stream *xdr, args.fhp = tempfh; } else args.fhp = fhp; + if (attrmask[0] & (FATTR4_WORD0_CASE_INSENSITIVE | + FATTR4_WORD0_CASE_PRESERVING)) { + err = nfsd_get_case_info(dentry, &args.case_insensitive, + &args.case_preserving); + /* + * Per RFC 8881 Section 18.7.3, an attribute advertised + * in SUPPORTED_ATTRS must come back with a value or the + * GETATTR must fail. nfsd_get_case_info() fills POSIX + * defaults and returns -EOPNOTSUPP when the underlying + * filesystem does not expose case state; encode those + * defaults so the reply agrees with what SUPPORTED_ATTRS + * advertises. Other errors fail the operation as the + * spec requires. + */ + if (err && err != -EOPNOTSUPP) + goto out_nfserr; + } if (attrmask[0] & FATTR4_WORD0_ACL) { err = nfsd4_get_nfs4_acl(rqstp, dentry, &args.acl); -- 2.53.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel