From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41158CD3446 for ; Thu, 7 May 2026 08:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:In-Reply-To:References:Message-Id: MIME-Version:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XsWRT75owujys9NQS/Zwb+STQ0FewAZvfD81lyqwzB8=; b=RkM9Z2dPeAXT6g1KWrFTHvR9+i jC5hDj64ibukzoE0vTIiFv3SHTHueFLb4b3nuPVdZNuOMIS9kg5EOr2RRyLi+YrD5t+3YEEMBPAX1 mc5L0i7Yyc1ph82e3yPhUS8DvZAAqiqEI4nrv8/Agy/J5A8hW+QRUJ05Xl2aMYBdZRMo=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wKuVF-0005oL-Bh; Thu, 07 May 2026 08:54:38 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wKuVC-0005nk-BW for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2026 08:54:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7kMLjVvCrBo82w2GXtMzNzpVBCvFgjFVn8e4IF45Drg=; b=jN3jFYTKXsRqWNIr+85j07zl4L zVUzHCFZUdywAfQC6C58eNB2gkI6mP3bbXTdzAiE7M8yi94LFC7BZw/TC9o3sdQlQMBKJ3BOUM3B4 iRYCQEaZtBMdavBeJgYv7HkW8l1WmVNkxu9w12m2Hobewav0lgD7gbQQSJFyMfQLehjw=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Cc:To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7kMLjVvCrBo82w2GXtMzNzpVBCvFgjFVn8e4IF45Drg=; b=hAIF25xqdw1+4UokepX57bYZ1Q UyBtXoWqKNIbJPgY8CQUmTmcm28xoM8vJGPqRFdkFoLuf9SWgoJymLpoFgVJ1ynfUHJVYG0kK5BhC BGO49NkmjJ5VAwdQFi072an7hSrFq2fCFnpWqClTUQFWwEQ0J+bVHj8HsLDJ9eXhrFkI=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wKuV7-0002Bs-1J for linux-f2fs-devel@lists.sourceforge.net; Thu, 07 May 2026 08:54:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 70E0860252; Thu, 7 May 2026 08:54:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29B19C2BCB8; Thu, 7 May 2026 08:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778144062; bh=29KDob7D6wjAqke0cQHbkTiX/VafLuHXAnmywDOdkA0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=F5OPAtZyEPiRob11r6mjsT73FtLF+Xt5ZI1INoILliI2QpRjl9qwD910bJ/hWej2q 5qOgMKJI5uvCXGOkJuLCWItwqKcrtktRRLmVz4stu1cquv0qDoRB7+dIuHqSwNmp4Q cVP0dMX/KmylSyBzy4wcl1Fn+ow+iH2FIZmafc8WjoQXE2yolrma2YbtF+yqPUNdro sLdBe20m4uUCakDTNw4U1GgA4YmbJNMRkLV/XGxLLV1aO61bHL1uWOslg1nL1em9sI qMeG+rAxNAWC0PFJaOrFXyX5+ECuG/wOrWTrTwffLtC06zW071t1LsdsGMCfUVvzCk yPfwCqVThIZ0Q== Date: Thu, 07 May 2026 04:53:01 -0400 MIME-Version: 1.0 Message-Id: <20260507-case-sensitivity-v14-8-e62cc8200435@oracle.com> References: <20260507-case-sensitivity-v14-0-e62cc8200435@oracle.com> In-Reply-To: <20260507-case-sensitivity-v14-0-e62cc8200435@oracle.com> To: Al Viro , Christian Brauner , Jan Kara X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2743; i=chuck.lever@oracle.com; h=from:subject:message-id; bh=5XtPWdQD9rNyvcNieFdC0PM+y6dNjGmJfHpo+ZOq7bw=; b=owEBbQKS/ZANAwAKATNqszNvZn+XAcsmYgBp/FL2jWmMonLIdv4jv4c9Pilh2ntipFp8Txt7s wyRNKYSIL+JAjMEAAEKAB0WIQQosuWwEobfJDzyPv4zarMzb2Z/lwUCafxS9gAKCRAzarMzb2Z/ l3/SEACRIni+53l30d8QNO1GWehaiAG0xt92TB6hFrKf1Ho8s5nrt0Dl1634Z5/HpawKeZPc3+G 0/KQRlETPfz14p0UU96eZNjODEFJyCd3tUouJlSVSWJalrQFEz1rAetcRbNX116/cvduq22g0+p CTrwYiCnjG8zT9DeEfsDfxYR2459bGcQhVC9ON+/h+KkSJrInBNIEESHMKxhSA8a3IvWcFQCYJs dh4Dl3KX4btkKxyavpKevYXn86Kyqy9Jt3OKUlWgghNgnL1RulYQkLq3cXd78PlEo3IKLEMM8Di 3WjFL+QM/L+QXDQ2O9gn9BhnT/eK9pIP2cco8FZeogLm4nfMF+RcqPhf8uai08MdPoNJ+2L9qsn qZ5WISOEs2pl7VhLKLP5UQWQxGoVb9Rll3Az2SlSiF+R4L8USA5zv9Gwvc74eJYwTw/iY8cFV9a PhNuoQIEoJd8rVcXqguouQbVyn31HOkbRbmJbrKtH81MnLZKPOnRQirmI4l8BiMGScbuwLvh7GQ s1yKAl6DrreCESNhK80DiwnF+k7I5b13pRoQd4976TfZySbl+sbnRfd9AJeK3LgY7aRdYp2VVN6 NnTxeBBQICpRtqDXi/j44Upj8CYYvyKx6McjG/wXilh4jkJwaNSIEpk3pXVUyVg+FqT8JGrMaDT TpLBMFUhE3QfnjA== X-Developer-Key: i=chuck.lever@oracle.com; a=openpgp; fpr=28B2E5B01286DF243CF23EFE336AB3336F667F97 X-Headers-End: 1wKuV7-0002Bs-1J Subject: [f2fs-dev] [PATCH v14 08/15] xfs: Report case sensitivity in fileattr_get X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chuck Lever via Linux-f2fs-devel Reply-To: Chuck Lever Cc: pc@manguebit.org, yuezhang.mo@sony.com, cem@kernel.org, Roland Mainz , almaz.alexandrovich@paragon-software.com, adilger.kernel@dilger.ca, linux-cifs@vger.kernel.org, sfrench@samba.org, slava@dubeyko.com, linux-ext4@vger.kernel.org, linkinjeon@kernel.org, sprasad@microsoft.com, frank.li@vivo.com, ronniesahlberg@gmail.com, glaubitz@physik.fu-berlin.de, jaegeuk@kernel.org, hirofumi@mail.parknet.co.jp, linux-nfs@vger.kernel.org, tytso@mit.edu, linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, senozhatsky@chromium.org, Chuck Lever , hansg@kernel.org, anna@kernel.org, linux-fsdevel@vger.kernel.org, sj1557.seo@samsung.com, trondmy@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net From: Chuck Lever Upper layers such as NFSD need to query whether a filesystem is case-sensitive. Add FS_XFLAG_CASEFOLD to xfs_ip2xflags() when the filesystem is formatted with the ASCIICI feature flag. This serves both FS_IOC_FSGETXATTR (via xfs_fill_fsxattr() in xfs_fileattr_get()) and XFS_IOC_BULKSTAT (which populates bs_xflags directly from xfs_ip2xflags()), so bulkstat consumers and per-inode queries see a consistent view of the filesystem's case-folding behavior. FS_XFLAG_CASEFOLD is read-only: FS_XFLAG_RDONLY_MASK ensures FS_IOC_FSSETXATTR strips it, and xfs_flags2diflags() has no clause for CASEFOLD so the on-disk diflags are unaffected. The legacy FS_IOC_SETFLAGS path in xfs_fileattr_set() also allows FS_CASEFOLD_FL through its allowlist on ASCIICI filesystems so that a chattr read-modify-write cycle does not fail with EOPNOTSUPP. XFS always preserves case. XFS is case-sensitive by default, but supports ASCII case-insensitive lookups when formatted with the ASCIICI feature flag. Reviewed-by: Roland Mainz Signed-off-by: Chuck Lever --- fs/xfs/libxfs/xfs_inode_util.c | 2 ++ fs/xfs/xfs_ioctl.c | 20 +++++++++++++++++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/fs/xfs/libxfs/xfs_inode_util.c b/fs/xfs/libxfs/xfs_inode_util.c index 551fa51befb6..82be54b6f8d3 100644 --- a/fs/xfs/libxfs/xfs_inode_util.c +++ b/fs/xfs/libxfs/xfs_inode_util.c @@ -130,6 +130,8 @@ xfs_ip2xflags( if (xfs_inode_has_attr_fork(ip)) flags |= FS_XFLAG_HASATTR; + if (xfs_has_asciici(ip->i_mount)) + flags |= FS_XFLAG_CASEFOLD; return flags; } diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index ed9b4846c05f..f8216f74679f 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -755,9 +755,23 @@ xfs_fileattr_set( trace_xfs_ioctl_setattr(ip); if (!fa->fsx_valid) { - if (fa->flags & ~(FS_IMMUTABLE_FL | FS_APPEND_FL | - FS_NOATIME_FL | FS_NODUMP_FL | - FS_SYNC_FL | FS_DAX_FL | FS_PROJINHERIT_FL)) + unsigned int allowed = FS_IMMUTABLE_FL | FS_APPEND_FL | + FS_NOATIME_FL | FS_NODUMP_FL | + FS_SYNC_FL | FS_DAX_FL | + FS_PROJINHERIT_FL; + + /* + * FS_CASEFOLD_FL reflects the ASCIICI superblock feature, + * a read-only property. Accept it as a no-op so chattr's + * RMW round-trip succeeds; reject any attempt to enable + * it on a non-ASCIICI filesystem. xfs_flags2diflags() + * has no clause for CASEFOLD, so the bit is dropped from + * the on-disk diflags regardless. + */ + if (xfs_has_asciici(mp)) + allowed |= FS_CASEFOLD_FL; + + if (fa->flags & ~allowed) return -EOPNOTSUPP; } -- 2.53.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel