Re: [PATCH] Remove an unnecessary line in allocate_data_block.

[Dongho Sim <dh.sim@samsung.com>]

Yes, there was another one.
Thanks Chao, :-)

Signed-off-by: Dongho Sim <dh.sim@samsung.com>
---
 fs/f2fs/segment.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 8a6e57d..3ab7749 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -980,7 +980,6 @@ void allocate_data_block(struct f2fs_sb_info *sbi, struct page *page,
 	mutex_lock(&curseg->curseg_mutex);
 
 	*new_blkaddr = NEXT_FREE_BLKADDR(sbi, curseg);
-	old_cursegno = curseg->segno;
 
 	/*
 	 * __add_sum_entry should be resided under the curseg_mutex
@@ -1001,7 +1000,6 @@ void allocate_data_block(struct f2fs_sb_info *sbi, struct page *page,
 	 * since SSR needs latest valid block information.
 	 */
 	refresh_sit_entry(sbi, old_blkaddr, *new_blkaddr);
-	locate_dirty_segment(sbi, old_cursegno);
 
 	mutex_unlock(&sit_i->sentry_lock);
 
-- 
1.9.1

------- Original Message -------
Sender : 俞超<chao2.yu@samsung.com> 工程师/SRC-Nanjing-Mobile Solution Lab/삼성전자
Date : 2014-07-28 14:35 (GMT+09:00)
Title : RE: [f2fs-dev] [PATCH] Remove an unnecessary line in allocate_data_block.

Hi Dongho,

> -----Original Message-----
> From: Dongho Sim [mailto:dh.sim@samsung.com]
> Sent: Monday, July 28, 2014 7:03 AM
> To: jaegeuk@kernel.org; linux-f2fs-devel@lists.sourceforge.net
> Subject: [f2fs-dev] [PATCH] Remove an unnecessary line in allocate_data_block.
> 
> Hi. There was an unnecessary line in function, allocate_data_block.
> It is already done in
>    refresh_sit_entry(sbi, old_blkaddr, *new_blkaddr);
> 
> Thanks.

Agreed,
How about removing old_cursegno too as it's no longer used in allocate_data_block?

Thanks,
Yu

> 
> Signed-off-by: Dongho Sim 
> ---
>  fs/f2fs/segment.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 8a6e57d..a3c7aae 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1001,7 +1001,6 @@ void allocate_data_block(struct f2fs_sb_info *sbi, struct page *page,
>   * since SSR needs latest valid block information.
>   */
>   refresh_sit_entry(sbi, old_blkaddr, *new_blkaddr);
> - locate_dirty_segment(sbi, old_cursegno);
> 
>   mutex_unlock(&sit_i->sentry_lock);
> 
> --
> 1.9.1
> ------------------------------------------------------------------------------
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel