From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chandan Rajendra Subject: Re: [RFC PATCH 00/10] Consolidate Post read processing code Date: Fri, 22 Feb 2019 09:59:31 +0530 Message-ID: <2245787.mQPMR5rap9@localhost.localdomain> References: <20190218100433.20048-1-chandan@linux.ibm.com> <2420837.hecoV8S9Z6@localhost.localdomain> <20190221183827.GA140206@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gx2SU-0000fD-QS for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 Feb 2019 04:29:10 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1gx2SS-006jKW-SI for linux-f2fs-devel@lists.sourceforge.net; Fri, 22 Feb 2019 04:29:10 +0000 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1M4Swp9088507 for ; Thu, 21 Feb 2019 23:28:59 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qt96e1up4-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 21 Feb 2019 23:28:59 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Feb 2019 04:28:57 -0000 In-Reply-To: <20190221183827.GA140206@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Eric Biggers Cc: tytso@mit.edu, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, adilger.kernel@dilger.ca, jaegeuk@kernel.org, linux-ext4@vger.kernel.org On Friday, February 22, 2019 12:08:28 AM IST Eric Biggers wrote: > On Thu, Feb 21, 2019 at 07:02:03PM +0530, Chandan Rajendra wrote: > > On Wednesday, February 20, 2019 6:11:07 AM IST Eric Biggers wrote: > > > On Mon, Feb 18, 2019 at 03:34:23PM +0530, Chandan Rajendra wrote: > > > > Based on the reviews provided for this patchset, I > > > > will change F2FS to use mpage_readpage[s] and post the next version of > > > > this patchset to linux-fsdevel mailing list. > > > > > > Is that really possible? F2FS has other functionality in its ->readpages(), > > > such as support for filesystems that use multiple block devices. > > > > > > > Hmm. I didn't know that. Thanks for pointing that out. I will read up that > > code and if it isn't really possible to get F2FS to use mpage_readpage[s](), > > then I would limit the patchset to Ext4. > > > > But we can make F2FS use the shared bio_post_read functions even if it can't use > mpage_readpage[s](), right? > Yes, that should be possible. I will include those changes in the next version of the patchset. -- chandan