From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83590C433F5 for ; Tue, 2 Nov 2021 03:37:48 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3361F61052; Tue, 2 Nov 2021 03:37:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3361F61052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mhkcM-0004z7-CX; Tue, 02 Nov 2021 03:37:46 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mhkcL-0004z1-A5 for linux-f2fs-devel@lists.sourceforge.net; Tue, 02 Nov 2021 03:37:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8VfvwlRFSnnnvvDQlwNomZvHdkeFL5BD54QGepNw+SU=; b=Rar/+vAFhHMYTQnzypMbmCYN/q RExZf/bfO67nhFPzWOnAcqCXu+Nt0qESf2DDlwKfD5l0hqDgJgVgPKf9F69/NZsBICpyrkt8FIC1T PmWIhvbM9NxYKqPFPBezIvJd9s348LXUZVB6GiTnT3tbDApPzZvzs3GPWcECw3sJRgd4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8VfvwlRFSnnnvvDQlwNomZvHdkeFL5BD54QGepNw+SU=; b=dgW/u/+mQiiU6WdIHvoS9mgfji iKuHW0qIIgzDSEENBJ3Gay/N53JW/1njSWKS5xSFvqth1hPaasDhduZV/iTaiM6a5pCsR1AHjEeXS fWuStT0gGi4JLj5KNBlpn1ZDeZksC8ym8oNzwz1OL95tHwjh/zyzSTOIkrIGi8+g9Voc=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mhkcK-0003ug-Ms for linux-f2fs-devel@lists.sourceforge.net; Tue, 02 Nov 2021 03:37:45 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 62C2760F6F; Tue, 2 Nov 2021 03:37:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635824254; bh=W+VhXomHRpnllsGX4zhga7jZFF/Pxk2QVmjmmokRQyo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TA2wMT44AIu+nh8LQKpHgTUM321wn2zdpSo/mzBm3uXLVGhMbv8X+D6vfXjIeiSt5 Gt3b+tv8vHhNPKa+itGu8ofPGzmpbv6QBwNvlnzGGO9hE4MQ1ckdPTYj8zLgeL8MSZ m5h4GZw2MAQf712BXXa2/LAfsi9eh0Bna68JHOXg6KUH37bzKAJSdPpWrKiBUUec5c 2KXx5H9QfiFS/8mwFbNmkwfmV9yHSQ2BcGOUSWFeMCimVhz9GxKIQlPJJRVSXM73+Z y311E7PQf9TVfAbxY1ykeGyERb6mvvSRR6+1YBWxnEEM5fy3XZwjdKVzHBBeT3NWHc RNjqvgBsdXaiA== Message-ID: <228a7789-4b38-f08c-ecdf-584ef491ea7a@kernel.org> Date: Tue, 2 Nov 2021 11:37:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Content-Language: en-US To: Hyeong-Jun Kim , Jaegeuk Kim References: <20211101084634.38727-1-hj514.kim@samsung.com> From: Chao Yu In-Reply-To: <20211101084634.38727-1-hj514.kim@samsung.com> X-Headers-End: 1mhkcK-0003ug-Ms Subject: Re: [f2fs-dev] [PATCH v2] F2FS: invalidate META_MAPPING before IPU/DIO write X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/11/1 16:46, Hyeong-Jun Kim wrote: > Encrypted pages during GC are read and cached in META_MAPPING. > However, due to cached pages in META_MAPPING, there is an issue where > newly written pages are lost by IPU or DIO writes. > > Thread A - f2fs_gc() Thread B > /* phase 3 */ > down_write(i_gc_rwsem) > ra_data_block() ---- (a) > up_write(i_gc_rwsem) > f2fs_direct_IO() : > - down_read(i_gc_rwsem) > - __blockdev_direct_io() > - get_data_block_dio_write() > - f2fs_dio_submit_bio() ---- (b) > - up_read(i_gc_rwsem) > /* phase 4 */ > down_write(i_gc_rwsem) > move_data_block() ---- (c) > up_write(i_gc_rwsem) > > (a) In phase 3 of f2fs_gc(), up-to-date page is read from storage and > cached in META_MAPPING. > (b) In thread B, writing new data by IPU or DIO write on same blkaddr as > read in (a). cached page in META_MAPPING become out-dated. > (c) In phase 4 of f2fs_gc(), out-dated page in META_MAPPING is copied to > new blkaddr. In conclusion, the newly written data in (b) is lost. > > To address this issue, invalidating pages in META_MAPPING before IPU or > DIO write. > > Fixes: 6aa58d8ad20a ("f2fs: readahead encrypted block during GC") > Signed-off-by: Hyeong-Jun Kim > --- > fs/f2fs/data.c | 2 ++ > fs/f2fs/segment.c | 3 +++ > 2 files changed, 5 insertions(+) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 74e1a350c1d8..9f754aaef558 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1708,6 +1708,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, > */ > f2fs_wait_on_block_writeback_range(inode, > map->m_pblk, map->m_len); > + invalidate_mapping_pages(META_MAPPING(sbi), > + map->m_pblk, map->m_pblk); > > if (map->m_multidev_dio) { > block_t blk_addr = map->m_pblk; > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 526423fe84ce..f57c55190f9e 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -3652,6 +3652,9 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio) > goto drop_bio; > } > > + invalidate_mapping_pages(META_MAPPING(fio->sbi), There is one more comment from Weichao: Use sbi instead of fio->sbi? Thanks, > + fio->new_blkaddr, fio->new_blkaddr); > + > stat_inc_inplace_blocks(fio->sbi); > > if (fio->bio && !(SM_I(sbi)->ipu_policy & (1 << F2FS_IPU_NOCACHE))) > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel