From: Chao Yu <chao@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: Kconfig: clean up config options about compression
Date: Thu, 5 Aug 2021 21:49:25 +0800 [thread overview]
Message-ID: <23f17a0a-7d0a-97c1-246f-994b8ffecc8d@kernel.org> (raw)
In-Reply-To: <1628170224-13239-1-git-send-email-yangtiezhu@loongson.cn>
On 2021/8/5 21:30, Tiezhu Yang wrote:
> In fs/f2fs/Kconfig, F2FS_FS_LZ4HC depends on F2FS_FS_LZ4 and F2FS_FS_LZ4
> depends on F2FS_FS_COMPRESSION, so no need to make F2FS_FS_LZ4HC depends
> on F2FS_FS_COMPRESSION explicitly, remove the redudant "depends on", do
> the similar thing for F2FS_FS_LZORLE.
>
> At the same time, it is better to move F2FS_FS_LZORLE next to F2FS_FS_LZO,
> it looks like a little more clear when make menuconfig, the location of
> "LZO-RLE compression support" is under "LZO compression support" instead
> of "F2FS compression feature".
>
> Without this patch:
>
> F2FS compression feature
> LZO compression support
> LZ4 compression support
> LZ4HC compression support
> ZSTD compression support
> LZO-RLE compression support
>
> With this patch:
>
> F2FS compression feature
> LZO compression support
> LZO-RLE compression support
> LZ4 compression support
> LZ4HC compression support
> ZSTD compression support
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2021-08-05 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 13:30 [f2fs-dev] [PATCH] f2fs: Kconfig: clean up config options about compression Tiezhu Yang
2021-08-05 13:49 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f17a0a-7d0a-97c1-246f-994b8ffecc8d@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).