From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Jaegeuk Kim <jaegeuk@kernel.org>, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs_io: user O_RDONLY for fadvise
Date: Sun, 3 May 2026 16:55:29 +0800 [thread overview]
Message-ID: <24e8b2b6-910a-4273-9009-e206c7fb95ae@kernel.org> (raw)
In-Reply-To: <20260409134630.3693274-2-jaegeuk@kernel.org>
On 4/9/26 21:46, Jaegeuk Kim via Linux-f2fs-devel wrote:
> We don't need O_RDONLY for fadvise.
s/O_RDONLY/O_RDWR according to title & change?
Thanks,
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> tools/f2fs_io/f2fs_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c
> index 8b9f9ef22eef..94e61b850923 100644
> --- a/tools/f2fs_io/f2fs_io.c
> +++ b/tools/f2fs_io/f2fs_io.c
> @@ -474,7 +474,7 @@ static void do_fadvise(int argc, char **argv, const struct cmd_desc *cmd)
> exit(1);
> }
>
> - fd = xopen(argv[4], O_RDWR, 0);
> + fd = xopen(argv[4], O_RDONLY, 0);
>
> if (!strcmp(argv[1], "willneed")) {
> advice = POSIX_FADV_WILLNEED;
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-05-03 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:46 [f2fs-dev] [PATCH 1/2] f2fs_io: support xattr(large_folio) Jaegeuk Kim via Linux-f2fs-devel
2026-04-09 13:46 ` [f2fs-dev] [PATCH 2/2] f2fs_io: user O_RDONLY for fadvise Jaegeuk Kim via Linux-f2fs-devel
2026-05-01 14:02 ` Daeho Jeong
2026-05-03 8:55 ` Chao Yu via Linux-f2fs-devel [this message]
2026-05-08 19:12 ` [f2fs-dev] [PATCH 2/2 v2] f2fs_io: use " Jaegeuk Kim via Linux-f2fs-devel
2026-05-09 8:32 ` Chao Yu via Linux-f2fs-devel
2026-05-01 14:12 ` [f2fs-dev] [PATCH 1/2] f2fs_io: support xattr(large_folio) Daeho Jeong
2026-05-03 8:53 ` Chao Yu via Linux-f2fs-devel
2026-05-08 19:23 ` [f2fs-dev] [PATCH 1/2 v2] " Jaegeuk Kim via Linux-f2fs-devel
2026-05-09 8:32 ` Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e8b2b6-910a-4273-9009-e206c7fb95ae@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox