Re: [f2fs-dev] [PATCH] common/rc: f2fs do not support metadata journaling

[Chao Yu <chao@kernel.org>]

On 2021/6/15 11:25, Sun Ke wrote:
> 
> 
> 在 2021/6/11 19:22, Sun Ke 写道:
>> In generic/50, touch 100 files, go down the fs immediately, Then umount
>> and set the disk readi-only. Try to mount it again without \-o
>> norecovery\, it should fail, because it can not recovery on a read-only
>> device. But f2fs mount successfully and the test fail.
>>
>> f2fs seems do not support metadata journaling.

It looks not correct.

FYI,

https://lkml.org/lkml/2021/3/23/75

Thanks,

>>
>> Signed-off-by: Sun Ke <sunke32@huawei.com>
>> ---
>>
>> I am not very sure if f2fs do not support metadata journaling.
>>
>> ###
>> before change
>> ###
>> [root@localhost xfstests-dev]# ./check tests/generic/050
>> FSTYP         -- f2fs
>> PLATFORM      -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP Tue Jun 8 11:09:37 CST 2021
>> MKFS_OPTIONS  -- /dev/sdb
>> MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch
>>
>> generic/050 4s ... - output mismatch (see /root/work/xfstests-dev/results//generic/050.out.bad)
>>      --- tests/generic/050.out   2021-05-31 15:37:40.000000000 +0800
>>      +++ /root/work/xfstests-dev/results//generic/050.out.bad    2021-06-11 16:48:19.993000000 +0800
>>      @@ -13,9 +13,7 @@
>>       setting device read-only
>>       mounting filesystem that needs recovery on a read-only device:
>>       mount: device write-protected, mounting read-only
>>      -mount: cannot mount device read-only
>>       unmounting read-only filesystem
>>      -umount: SCRATCH_DEV: not mounted
>>       mounting filesystem with -o norecovery on a read-only device:
>>      ...
>>      (Run 'diff -u /root/work/xfstests-dev/tests/generic/050.out /root/work/xfstests-dev/results//generic/050.out.bad'  to see the entire diff)
>> Ran: generic/050
>> Failures: generic/050
>> Failed 1 of 1 tests
>>
>> ###
>> after change
>> ###
>> [root@localhost xfstests-dev]# ./check tests/generic/050
>> FSTYP         -- f2fs
>> PLATFORM      -- Linux/x86_64 localhost 5.12.0-rc5-next-20210330 #8 SMP Tue Jun 8 11:09:37 CST 2021
>> MKFS_OPTIONS  -- /dev/sdb
>> MOUNT_OPTIONS -- -o acl,user_xattr /dev/sdb /tmp/scratch
>>
>> generic/050 4s ...  4s
>> Ran: generic/050
>> Passed all 1 tests
>>
>>
>>
>>   common/rc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/rc b/common/rc
>> index a0aa7300..428b8b80 100644
>> --- a/common/rc
>> +++ b/common/rc
>> @@ -3543,7 +3543,7 @@ _has_metadata_journaling()
>>       fi
>>       case "$FSTYP" in
>> -    ext2|vfat|msdos|udf|exfat|tmpfs)
>> +    ext2|vfat|msdos|udf|exfat|tmpfs|f2fs)
>>           echo "$FSTYP does not support metadata journaling"
>>           return 1
>>           ;;
>>
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel