From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] f2fs: remove request_list check in is_idle() Date: Tue, 16 Oct 2018 13:24:59 -0600 Message-ID: <263ca9fa-7865-41a5-2109-af851cbb2c64@kernel.dk> References: <003df7ce-626c-e32b-909b-909b87e0c8f3@kernel.org> <5bbe6ae7-704e-dcaa-f798-959d8a1a00b3@kernel.dk> <20181016192314.GB29774@jaegeuk-macbookpro.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gCUxt-0004L7-O3 for linux-f2fs-devel@lists.sourceforge.net; Tue, 16 Oct 2018 19:25:13 +0000 Received: from mail-it1-f196.google.com ([209.85.166.196]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1gCUxp-0059M6-GJ for linux-f2fs-devel@lists.sourceforge.net; Tue, 16 Oct 2018 19:25:13 +0000 Received: by mail-it1-f196.google.com with SMTP id h6-v6so30744532ith.0 for ; Tue, 16 Oct 2018 12:25:09 -0700 (PDT) In-Reply-To: <20181016192314.GB29774@jaegeuk-macbookpro.roam.corp.google.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net On 10/16/18 1:23 PM, Jaegeuk Kim wrote: > Thanks Jens, > > On top of the patch killing the dead code, I wrote another one to detect > the idle time by the internal account logic like below. IMHO, it'd be > better to decouple f2fs with other layers, if possible. I agree, that's what got us into trouble in the first place. Can I add your acked-by or review-by to the other patch, then? -- Jens Axboe