[RESEND PATCH] f2fs: Fix one GCC warning

[RESEND PATCH] f2fs: Fix one GCC warning

[Shaokun Zhang]

fs/f2fs/node.c: In function ‘f2fs_remove_inode_page’:
fs/f2fs/node.c:1193:47: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘blkcnt_t {aka long long unsigned int}’ [-Wformat=]
    "Inconsistent i_blocks, ino:%lu, iblocks:%lu",
                                             ~~^
                                             %llu
    inode->i_ino, inode->i_blocks);
                  ~~~~~~~~~~~~~~~
Fixes: cdad635bd068 ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
 fs/f2fs/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 22d21c546bf6..e15d0be729b4 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1190,7 +1190,7 @@ int f2fs_remove_inode_page(struct inode *inode)
 
 	if (unlikely(inode->i_blocks != 0 && inode->i_blocks != 8)) {
 		f2fs_msg(F2FS_I_SB(inode)->sb, KERN_WARNING,
-			"Inconsistent i_blocks, ino:%lu, iblocks:%lu",
+			"Inconsistent i_blocks, ino:%lu, iblocks:%llu",
 			inode->i_ino, inode->i_blocks);
 		set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_FSCK);
 	}
-- 
2.7.4



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [RESEND PATCH] f2fs: Fix one GCC warning

[Chao Yu]

On 2019/4/22 21:27, Shaokun Zhang wrote:
> fs/f2fs/node.c: In function ‘f2fs_remove_inode_page’:
> fs/f2fs/node.c:1193:47: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘blkcnt_t {aka long long unsigned int}’ [-Wformat=]
>     "Inconsistent i_blocks, ino:%lu, iblocks:%lu",
>                                              ~~^
>                                              %llu
>     inode->i_ino, inode->i_blocks);
>                   ~~~~~~~~~~~~~~~
> Fixes: cdad635bd068 ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")

We have already fixed this issue, thanks for noticing this issue. :)

https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=5cf2879fa71a865f08348dae982b97b9738a0847

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [RESEND PATCH] f2fs: Fix one GCC warning

[Zhangshaokun]

Hi,

On 2019/4/23 10:57, Chao Yu wrote:
> On 2019/4/22 21:27, Shaokun Zhang wrote:
>> fs/f2fs/node.c: In function ‘f2fs_remove_inode_page’:
>> fs/f2fs/node.c:1193:47: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘blkcnt_t {aka long long unsigned int}’ [-Wformat=]
>>     "Inconsistent i_blocks, ino:%lu, iblocks:%lu",
>>                                              ~~^
>>                                              %llu
>>     inode->i_ino, inode->i_blocks);
>>                   ~~~~~~~~~~~~~~~
>> Fixes: cdad635bd068 ("f2fs: fix to avoid panic in f2fs_remove_inode_page()")
> 
> We have already fixed this issue, thanks for noticing this issue. :)
> 

Nice, thanks your reply.

> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=5cf2879fa71a865f08348dae982b97b9738a0847
> 
> Thanks,
> 
> .
> 



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel