linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
* [PATCH] f2fs: remove request_list check in is_idle()
@ 2018-10-16 14:34 Jens Axboe
  2018-10-16 16:06 ` Chao Yu
  0 siblings, 1 reply; 13+ messages in thread
From: Jens Axboe @ 2018-10-16 14:34 UTC (permalink / raw)
  To: Jaegeuk Kim, linux-f2fs-devel

This doesn't work on stacked devices, and it doesn't work on
blk-mq devices. The request_list is only used on legacy, which
we don't have much of anymore, and soon won't have any of.

Kill the check.

Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 fs/f2fs/f2fs.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index abf925664d9c..58778992eca4 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -1356,13 +1356,6 @@ static inline bool f2fs_time_over(struct f2fs_sb_info *sbi, int type)
 
 static inline bool is_idle(struct f2fs_sb_info *sbi)
 {
-	struct block_device *bdev = sbi->sb->s_bdev;
-	struct request_queue *q = bdev_get_queue(bdev);
-	struct request_list *rl = &q->root_rl;
-
-	if (rl->count[BLK_RW_SYNC] || rl->count[BLK_RW_ASYNC])
-		return false;
-
 	return f2fs_time_over(sbi, REQ_TIME);
 }
 
-- 
2.17.1

-- 
Jens Axboe

^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2018-10-17  3:12 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-16 14:34 [PATCH] f2fs: remove request_list check in is_idle() Jens Axboe
2018-10-16 16:06 ` Chao Yu
2018-10-16 16:20   ` Jens Axboe
2018-10-16 19:23     ` Jaegeuk Kim
2018-10-16 19:24       ` Jens Axboe
2018-10-16 19:31         ` Jaegeuk Kim
2018-10-16 19:36           ` Jens Axboe
2018-10-17  1:18       ` Chao Yu
2018-10-17  2:19         ` Jaegeuk Kim
2018-10-17  2:49           ` Chao Yu
2018-10-17  3:06             ` Jaegeuk Kim
2018-10-17  3:11       ` Chao Yu
2018-10-17  1:08     ` Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).