From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 008C5C43334 for ; Fri, 10 Jun 2022 17:12:39 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nziBa-0002Yw-9k; Fri, 10 Jun 2022 17:12:37 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nziBY-0002Yq-3m for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Jun 2022 17:12:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kwXtCw17WJllmx5Ao7pJMmgs8rW8H83BvHSWIXWlK/Y=; b=Gdmyvr/+2FQLJj0ENUBw6EN0PI o1u3YfQlan2KD9eD4c8OO3MEkUbzSWPPshiBdHGMF4GhddQ9HdUt+xxITL1/mxjoIra11wxI/KZiA gq3v42HqeM2n9knLAfJ0Nnmj6bdSdgGQbS+p9t9aGFXKwEGiHgj21uZWnHXbbEcKFHCg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kwXtCw17WJllmx5Ao7pJMmgs8rW8H83BvHSWIXWlK/Y=; b=QNbkL/8Uv/S8PdI77SOCPOeiTo MMjY7j5PHBnfWOUCODnjt+BQx2iWuZgGyfidT7/5WgdhuWVsHWFZJ6KxGitfytyns5o/CsRb/yQCv 4UDxQfvL8hDjNCzWwBTIHiD5+veXOEHboM+G3i87TtL7M3wcVPQtbTUoXHCJAHYXsB3Y=; Received: from mail-pg1-f182.google.com ([209.85.215.182]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.94.2) id 1nziBU-0002iM-RT for linux-f2fs-devel@lists.sourceforge.net; Fri, 10 Jun 2022 17:12:34 +0000 Received: by mail-pg1-f182.google.com with SMTP id e66so25336455pgc.8 for ; Fri, 10 Jun 2022 10:12:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kwXtCw17WJllmx5Ao7pJMmgs8rW8H83BvHSWIXWlK/Y=; b=ILrkXyYXXhYqOrdgQbbpiMYX/DLBGn5imuCut0BS/8xON9pFXtql2E1tbUc1EnO0iv mHAHrk/U9U9nGL/KHOgA0ODZWV4g5outzBu8QDF/Gwlz7hM2CrVgzoLDy7leBdXgcjSX PbgmBlW2sptjuoxVdE+ZJPbMnTmIT7SFm7lqQcU4zB2E9PheZa78A1Qvyy4WDeo8kzQE tARF/5ELtCzBu0HssugthgJV9982YrxX1px6SP6qzmbjR4kC05iGEOV5W+uhc9Bq81pJ 2eCiTDYBf5xoy5iGk4G9U5ngDUYE23ulxZe6bjx5lVH9VReBQEzaxusRgVwQJqdl08Va dDWA== X-Gm-Message-State: AOAM533ZfLyebpCe5h6Wwknh7CTXoAZbKpNHWdDDsWaMY2c7HwFHQTTf yU2p+8QtUwgE6DUverQRrNg= X-Google-Smtp-Source: ABdhPJymjxEbiUTV+3hjXutmvvnsNgwYdPjJrvjfiZomVNcSlUtbfzD7X6lSGtgK3FGuHOfQhpuVIQ== X-Received: by 2002:a63:6985:0:b0:3fe:1929:7d6a with SMTP id e127-20020a636985000000b003fe19297d6amr16625457pgc.292.1654881148479; Fri, 10 Jun 2022 10:12:28 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:9eb7:13f0:a1e0:550e? ([2620:15c:211:201:9eb7:13f0:a1e0:550e]) by smtp.gmail.com with ESMTPSA id f2-20020a17090a288200b001e2afd35791sm1998642pjd.18.2022.06.10.10.12.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jun 2022 10:12:27 -0700 (PDT) Message-ID: <2f40b5ea-b493-bcb9-97ad-612d30a2eedc@acm.org> Date: Fri, 10 Jun 2022 10:12:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Peter Collingbourne References: <20220421221836.3935616-1-bvanassche@acm.org> <20220421221836.3935616-11-bvanassche@acm.org> From: Bart Van Assche In-Reply-To: X-Headers-End: 1nziBU-0002iM-RT Subject: Re: [f2fs-dev] [PATCH 10/31] Verify structure sizes at compile time X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 6/9/22 19:05, Peter Collingbourne wrote: > On Thu, Apr 21, 2022 at 03:18:15PM -0700, Bart Van Assche wrote: >> +static_assert(sizeof(struct f2fs_dentry_block) == 4096, ""); > > I noticed that this static_assert fails when PAGE_SIZE is defined to > a value other than 4096. > > I have to admit to being unfamiliar with f2fs. Is this an on-disk > data structure? If so, does it mean that non-4K page size kernels > are unable to mount f2fs file systems if the f2fs-tools were not > built with a matching PAGE_SIZE define? > > In any event, maybe s/4096/PAGE_SIZE/g above is the correct fix > for now? Hi Peter, How this issue should be fixed depends on whether or not f2fs_dentry_block is an on-disk data structure. I'm not sure about the answer. Jaegeuk, can you help with answering this question? Thanks, Bart. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel