From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCD3C433E0 for ; Thu, 9 Jul 2020 07:11:18 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4028E20674; Thu, 9 Jul 2020 07:11:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="hKCNpP2k"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="myqNrNhf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4028E20674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jtQiC-0007hr-9V; Thu, 09 Jul 2020 07:11:16 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtQiB-0007hk-0o for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Jul 2020 07:11:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eb2DB252JvKL7NfTds0iVcfOC9uqArwvCSpuslAO5Fc=; b=hKCNpP2kLamiQ9oN6BHmHFGZN5 tmGgD+n1uike6BCp6Lk9+IoN54S62Ml7eAs7MUM1uWXdBf5iSJCyLV0zlgzeVy4kwa/+FL5B1nQiy eE0xETc6qnC9KpmYJfPOtkcVxTVWE3O4tFBvRyP7453X3RWYCaII65ml2QTEI0NKeu0Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eb2DB252JvKL7NfTds0iVcfOC9uqArwvCSpuslAO5Fc=; b=myqNrNhfn0gBw0rrDTDbxa3svF iu2Yiqskb9GFT9gorYPqiMHnPf48r5rgxqzKGuzblqG8y7NjPdSBylpTZbKydh+uC/rlB2squgxRa feP9TZ0ua4fsx0pReb89tBmLxGAebjchRLLcx4P/dTPfgSxDaDrV3Ff41dDHteAHOGBI=; Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jtQi8-000VS5-T1 for linux-f2fs-devel@lists.sourceforge.net; Thu, 09 Jul 2020 07:11:14 +0000 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 837BFB140773F287219E; Thu, 9 Jul 2020 15:11:04 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 9 Jul 2020 15:11:00 +0800 To: Jaegeuk Kim , , , References: <20200709053027.351974-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <2f4207db-57d1-5b66-f1ee-3532feba5d1f@huawei.com> Date: Thu, 9 Jul 2020 15:10:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200709053027.351974-1-jaegeuk@kernel.org> Content-Language: en-US X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Headers-End: 1jtQi8-000VS5-T1 Subject: Re: [f2fs-dev] [PATCH] f2fs: don't skip writeback of quota data X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2020/7/9 13:30, Jaegeuk Kim wrote: > It doesn't need to bypass flushing quota data in background. The condition is used to flush quota data in batch to avoid random small-sized udpate, did you hit any problem here? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/data.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 44645f4f914b6..72e8b50e588c1 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -3148,7 +3148,7 @@ static int __f2fs_write_data_pages(struct address_space *mapping, > if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING))) > goto skip_write; > > - if ((S_ISDIR(inode->i_mode) || IS_NOQUOTA(inode)) && > + if (S_ISDIR(inode->i_mode) && > wbc->sync_mode == WB_SYNC_NONE && > get_dirty_pages(inode) < nr_pages_to_skip(sbi, DATA) && > f2fs_available_free_memory(sbi, DIRTY_DENTS)) > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel