From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: avoid an infinite loop in f2fs_sync_dirty_inodes
Date: Fri, 4 Mar 2022 17:20:03 +0800 [thread overview]
Message-ID: <303313a4-f529-ce12-e512-082db535d0f5@kernel.org> (raw)
In-Reply-To: <20220304021955.2524246-1-jaegeuk@kernel.org>
On 2022/3/4 10:19, Jaegeuk Kim wrote:
> If one read IO is always failing, we can fall into an infinite loop in
> f2fs_sync_dirty_inodes. This happens during xfstests/generic/475.
>
> [ 142.803335] Buffer I/O error on dev dm-1, logical block 8388592, async page read
> ...
> [ 382.887210] submit_bio_noacct+0xdd/0x2a0
> [ 382.887213] submit_bio+0x80/0x110
> [ 382.887223] __submit_bio+0x4d/0x300 [f2fs]
> [ 382.887282] f2fs_submit_page_bio+0x125/0x200 [f2fs]
> [ 382.887299] __get_meta_page+0xc9/0x280 [f2fs]
> [ 382.887315] f2fs_get_meta_page+0x13/0x20 [f2fs]
> [ 382.887331] f2fs_get_node_info+0x317/0x3c0 [f2fs]
> [ 382.887350] f2fs_do_write_data_page+0x327/0x6f0 [f2fs]
> [ 382.887367] f2fs_write_single_data_page+0x5b7/0x960 [f2fs]
> [ 382.887386] f2fs_write_cache_pages+0x302/0x890 [f2fs]
> [ 382.887405] ? preempt_count_add+0x7a/0xc0
> [ 382.887408] f2fs_write_data_pages+0xfd/0x320 [f2fs]
> [ 382.887425] ? _raw_spin_unlock+0x1a/0x30
> [ 382.887428] do_writepages+0xd3/0x1d0
> [ 382.887432] filemap_fdatawrite_wbc+0x69/0x90
> [ 382.887434] filemap_fdatawrite+0x50/0x70
> [ 382.887437] f2fs_sync_dirty_inodes+0xa4/0x270 [f2fs]
> [ 382.887453] f2fs_write_checkpoint+0x189/0x1640 [f2fs]
> [ 382.887469] ? schedule_timeout+0x114/0x150
> [ 382.887471] ? ttwu_do_activate+0x6d/0xb0
> [ 382.887473] ? preempt_count_add+0x7a/0xc0
> [ 382.887476] kill_f2fs_super+0xca/0x100 [f2fs]
> [ 382.887491] deactivate_locked_super+0x35/0xa0
> [ 382.887494] deactivate_super+0x40/0x50
> [ 382.887497] cleanup_mnt+0x139/0x190
> [ 382.887499] __cleanup_mnt+0x12/0x20
> [ 382.887501] task_work_run+0x64/0xa0
> [ 382.887505] exit_to_user_mode_prepare+0x1b7/0x1c0
> [ 382.887508] syscall_exit_to_user_mode+0x27/0x50
> [ 382.887510] do_syscall_64+0x48/0xc0
> [ 382.887513] entry_SYSCALL_64_after_hwframe+0x44/0xae
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2022-03-04 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 2:19 [f2fs-dev] [PATCH 1/2] f2fs: avoid an infinite loop in f2fs_sync_dirty_inodes Jaegeuk Kim
2022-03-04 2:19 ` [f2fs-dev] [PATCH 2/2] f2fs: introduce F2FS_UNFAIR_RWSEM to support unfair rwsem Jaegeuk Kim
2022-03-04 9:28 ` Chao Yu
2022-03-04 9:20 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=303313a4-f529-ce12-e512-082db535d0f5@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).