* Re: [f2fs:dev-test 30/30] fs/f2fs/file.c:99:2: error: implicit declaration of function '__do_map_lock'; did you mean '__cond_lock'?
[not found] <201809271121.vkngRPJR%fengguang.wu@intel.com>
@ 2018-09-27 3:34 ` Chao Yu
0 siblings, 0 replies; only message in thread
From: Chao Yu @ 2018-09-27 3:34 UTC (permalink / raw)
To: kbuild test robot, Chao Yu; +Cc: Jaegeuk Kim, kbuild-all, linux-f2fs-devel
To Jaegeuk,
On 2018/9/27 11:25, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
> head: 008aecc0a7dd2906168196bd016a547704c2b444
> commit: 008aecc0a7dd2906168196bd016a547704c2b444 [30/30] f2fs: refactor ->page_mkwrite() flow
> config: i386-randconfig-x011-201838 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> git checkout 008aecc0a7dd2906168196bd016a547704c2b444
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> fs/f2fs/file.c: In function 'f2fs_vm_page_mkwrite':
>>> fs/f2fs/file.c:99:2: error: implicit declaration of function '__do_map_lock'; did you mean '__cond_lock'? [-Werror=implicit-function-declaration]
> __do_map_lock(sbi, F2FS_GET_BLOCK_PRE_AIO, true);
It relies on below patch which exports that function.
f2fs: guarantee journalled quota data by checkpoint
> ^~~~~~~~~~~~~
> __cond_lock
> cc1: some warnings being treated as errors
>
> vim +99 fs/f2fs/file.c
>
> 44
> 45 static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
> 46 {
> 47 struct page *page = vmf->page;
> 48 struct inode *inode = file_inode(vmf->vma->vm_file);
> 49 struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
> 50 struct dnode_of_data dn = { .node_changed = false };
> 51 int err;
> 52
> 53 if (unlikely(f2fs_cp_error(sbi))) {
> 54 err = -EIO;
> 55 goto err;
> 56 }
> 57
> 58 sb_start_pagefault(inode->i_sb);
> 59
> 60 f2fs_bug_on(sbi, f2fs_has_inline_data(inode));
> 61
> 62 file_update_time(vmf->vma->vm_file);
> 63 down_read(&F2FS_I(inode)->i_mmap_sem);
> 64 lock_page(page);
> 65 if (unlikely(page->mapping != inode->i_mapping ||
> 66 page_offset(page) > i_size_read(inode) ||
> 67 !PageUptodate(page))) {
> 68 unlock_page(page);
> 69 err = -EFAULT;
> 70 goto out_sem;
> 71 }
> 72
> 73 /*
> 74 * check to see if the page is mapped already (no holes)
> 75 */
> 76 if (PageMappedToDisk(page))
> 77 goto mapped;
> 78
> 79 /* page is wholly or partially inside EOF */
> 80 if (((loff_t)(page->index + 1) << PAGE_SHIFT) >
> 81 i_size_read(inode)) {
> 82 loff_t offset;
> 83
> 84 offset = i_size_read(inode) & ~PAGE_MASK;
> 85 zero_user_segment(page, offset, PAGE_SIZE);
> 86 }
> 87 set_page_dirty(page);
> 88 if (!PageUptodate(page))
> 89 SetPageUptodate(page);
> 90
> 91 f2fs_update_iostat(sbi, APP_MAPPED_IO, F2FS_BLKSIZE);
> 92
> 93 trace_f2fs_vm_page_mkwrite(page, DATA);
> 94 mapped:
> 95 /* fill the page */
> 96 f2fs_wait_on_page_writeback(page, DATA, false);
> 97
> 98 /* block allocation */
> > 99 __do_map_lock(sbi, F2FS_GET_BLOCK_PRE_AIO, true);
> 100 set_new_dnode(&dn, inode, NULL, NULL, 0);
> 101 err = f2fs_reserve_block(&dn, page->index);
> 102 if (err)
> 103 goto out_unlock;
> 104
> 105 /* wait for GCed page writeback via META_MAPPING */
> 106 f2fs_wait_on_block_writeback(inode, dn.data_blkaddr);
> 107
> 108 f2fs_put_dnode(&dn);
> 109 out_unlock:
> 110 __do_map_lock(sbi, F2FS_GET_BLOCK_PRE_AIO, false);
> 111 out_sem:
> 112 up_read(&F2FS_I(inode)->i_mmap_sem);
> 113
> 114 f2fs_balance_fs(sbi, dn.node_changed);
> 115
> 116 sb_end_pagefault(inode->i_sb);
> 117 f2fs_update_time(sbi, REQ_TIME);
> 118 err:
> 119 return block_page_mkwrite_return(err);
> 120 }
> 121
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
^ permalink raw reply [flat|nested] only message in thread