Re: [RFC PATCH] f2fs-tools: introduce tune.f2fs

[Chao Yu <yuchao0@huawei.com>]

On 2018/5/5 3:06, Jaegeuk Kim wrote:
> On 05/02, Chao Yu wrote:
>> On 2018/4/28 10:49, Jaegeuk Kim wrote:
>>> On 04/27, Chao Yu wrote:
>>>> On 2018/4/27 0:13, Jaegeuk Kim wrote:
>>>>> On 04/26, Junling Zheng wrote:
>>>>>> Ping...
>>>>>>
>>>>>> On 2018/4/23 15:32, Junling Zheng wrote:
>>>>>>> Introduce tune.f2fs tool to change the f2fs parameters.
>>>>>>> Currently this tool only supports adding or removing encrypt
>>>>>>> feature bit in superblock.
>>>>>
>>>>> What is the purpose of this empty tune.f2fs? How can we say we have this
>>>>> tool to users? You have to design what kind of things to support first.
>>>>
>>>> I checked very initial tune2fs.c, it only supports very few parameters tuning
>>>> functionality, but, can not say that is a bad start to introduce the misc tool.
>>>>
>>>> +       fprintf (stderr, "Usage: %s [-c max-mounts-count] [-e errors-behavior] "
>>>> +                "[-i interval[d|m]]\n"
>>>> +                "\t[-l] [-m reserved-blocks-percent] device\n", program_name);
>>>
>>> I don't think We have to follow that.
>>>
>>>>
>>>> Maybe tuning 1. extension list, 2. multi device name later? just guess.
>>>
>>> First of all, does it make sense to unset feature bits? I don't think so.
>>
>> Some features can be turned off in a initial image? like encrypted, extra_attr,
>> checksum...?
> 
> Any reason to do thtat? And, we need to find all the files whether there is

Not very sure, just checked tune2fs, and found them in manual, guessing that
there came demand from user who want to disable some feature in a formatted
partition?

> any encrypted file.
> 
>>
>>>
>>> Agreed to your suggestion where:
>>> 1. feature set
>>>   - enable system quota
>>> 2. extension list
>>> 3. multi device name -- which may be really big trial
>>
>> So what's our plan now? fill those features into fsck when we need them?
> 
> No. If you want to add tune.f2fs, I'd like to see some demand, or very useful
> features like this. I just want to avoid introducing an (almost) empty tool.

Yeah, I see.

Maybe we can support below options except feature/extension_list/device_name.
-Q quota-options	set,clear user/group/prjquota sysfile inode.
-U UUID			set,clear uuid
-L volume-label		set,clear volume name

Thanks,

> 
> Thanks,
> 
>>
>> Thanks,
>>
>>>
>>>>
>>>> Using fsck.f2fs to tune parameter, IMO, maybe a little confuse for user to
>>>> understand the tool's functionality.
>>>>
>>>> Thanks,
>>>
>>> .
>>>
> 
> .
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot