From mboxrd@z Thu Jan 1 00:00:00 1970 From: Goldwyn Rodrigues Subject: Re: [PATCH v11 10/63] xarray: Add xa_for_each Date: Sun, 22 Apr 2018 15:33:23 -0500 Message-ID: <3c759f62-a1fa-9bdd-9b02-7c4e1d2b3adb@suse.de> References: <20180414141316.7167-1-willy@infradead.org> <20180414141316.7167-11-willy@infradead.org> <35a3318d-69d7-a10c-1515-98ea6b59fb99@suse.de> <20180421013406.GM10788@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fALg2-0004hc-St for linux-f2fs-devel@lists.sourceforge.net; Sun, 22 Apr 2018 20:33:38 +0000 Received: from mx2.suse.de ([195.135.220.15]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1:ECDHE-RSA-AES256-SHA:256) (Exim 4.90_1) id 1fALg0-00ArNS-Gz for linux-f2fs-devel@lists.sourceforge.net; Sun, 22 Apr 2018 20:33:38 +0000 In-Reply-To: <20180421013406.GM10788@bombadil.infradead.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Matthew Wilcox Cc: linux-nilfs@vger.kernel.org, Jan Kara , Jeff Layton , Matthew Wilcox , James Simmons , Jaegeuk Kim , Andreas Dilger , Nicholas Piggin , linux-f2fs-devel@lists.sourceforge.net, Oleg Drokin , linux-mm@kvack.org, Ryusuke Konishi , linux-fsdevel@vger.kernel.org, Lukas Czerner , Ross Zwisler , Christoph Hellwig , Mike Kravetz On 04/20/2018 08:34 PM, Matthew Wilcox wrote: > On Fri, Apr 20, 2018 at 07:00:47AM -0500, Goldwyn Rodrigues wrote: >> This function name sounds like you are performing the operation for each >> tag. >> >> Can it be called xas_for_each_tagged() or xas_tag_for_each() instead? > > I hadn't thought of that interpretation. Yes, that makes sense. > Should we also rename xas_find_tag -> xas_find_tagged and xas_next_tag > -> xas_next_tagged? Yup. The family of functions that work with one tag should be renamed. I am fine with the names suggested. -- Goldwyn ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot