From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE9FC4338F for ; Tue, 3 Aug 2021 01:01:10 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5087C6023F; Tue, 3 Aug 2021 01:01:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5087C6023F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1mAint-00067o-65; Tue, 03 Aug 2021 01:01:09 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mAinr-00067h-UU for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Aug 2021 01:01:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NQE2afWb4kVx2qNabUk7BxANEE8EWsT9Ja5tmgHf5fc=; b=JRWObp/nSuywmGUbukaT6EQjeV IFZyadbZdQgPPMfLNYAitaI3d7P7eeJIN7tYysxtkF6Weqxu1UBm14xyaIpjG+OWiagEByuGZqM3B IPTT+SG8sqdMNXml7acc+lqLdvJQCFDf1NdaHzcpvY+wcqFqRR+uSoAG04cveUiwxwy4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NQE2afWb4kVx2qNabUk7BxANEE8EWsT9Ja5tmgHf5fc=; b=X7/nu3pus4UQCr8D2p1K/n7Z7m OlS1JG4AEiyM3kHHPbqrtMu39W27ZBO5fYkmRox2z7vLXjtUUvNtcNcVkPvBNG+dtT2YkQ9Yt/VQz Zq+gH/hdN9vRRatDAi0R2v/Cu+82C/lzmTPoz3jSWV1p1BlIijNhEJ+7fi6JkvZ1X9jg=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mAino-00AgVv-Kh for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Aug 2021 01:01:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 82D1F6023F; Tue, 3 Aug 2021 01:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627952458; bh=07UiOBm70AqBSviL4tUxOYvDv/m1dWzDfeaIuqRX+X0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=i5pOBM3LhdrWSMotAIVIaSJktxkkqPWgqur222gSoFrFE4gVQwU7xpvTpMkqemBBM Q1ID8sk9gtLNIIBfYw2TtCevJWLC1ekPapsPuZWNxl4ptfX6qGC4eUj9skalpo4Oi4 13SZvg4iEv5JpGEQg84LKeSQUOthGTcgLwZyUFvQ18a4NNEfbOlan03tOKxvEezauV lEb2lFW9G0CcJqUtgMIIldXvc85bynPVmVc1xjAzsmxVsSpOPCCW6qSrY/uyWN+QYt SDDo189jPgPffjXVVRp2XRMyfQ4P0IzUB1XfF9JM3IAwy6mjPzG2BBF00aP7ivdPbd 1z55Q+NPWUE9g== To: Jaegeuk Kim References: <20210427082106.2755-1-frank.li@vivo.com> <12ae52df-bc5e-82c3-4f78-1eafe7723f93@huawei.com> <5f37995c-2390-e8ca-d002-3639ad39e0d3@kernel.org> <8d2e3a63-72f9-bcb2-24e5-dddd84136001@kernel.org> <355ac2ff-f1f1-b9ea-bd8c-139cb24a03fb@kernel.org> From: Chao Yu Message-ID: <3d3ef5c9-fbb6-df85-26f7-e493da594b22@kernel.org> Date: Tue, 3 Aug 2021 09:00:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Headers-End: 1mAino-00AgVv-Kh Subject: Re: [f2fs-dev] [PATCH] f2fs: reset free segment to prefree status when do_checkpoint() fail X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Yangtao Li Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/8/3 1:59, Jaegeuk Kim wrote: > On 08/01, Chao Yu wrote: >> On 2021/7/31 6:18, Jaegeuk Kim wrote: >>> On 07/20, Chao Yu wrote: >>>> On 2021/7/20 2:25, Jaegeuk Kim wrote: >>>>> On 07/19, Chao Yu wrote: >>>>>> On 2021/4/27 20:37, Chao Yu wrote: >>>>>>> I think just reverting dirty/free bitmap is not enough if checkpoint fails, >>>>>>> due to we have updated sbi->cur_cp_pack and nat/sit bitmap, next CP tries >>>>>>> to overwrite last valid meta/node/data, then filesystem will be corrupted. >>>>>>> >>>>>>> So I suggest to set cp_error if do_checkpoint() fails until we can handle >>>>>>> all cases, which is not so easy. >>>>>>> >>>>>>> How do you think? >>>>>> >>>>>> Let's add below patch first before you figure out the patch which covers all >>>>>> things. >>>>>> >>>>>> From 3af957c98e9e04259f8bb93ca0b74ba164f3f27e Mon Sep 17 00:00:00 2001 >>>>>> From: Chao Yu >>>>>> Date: Mon, 19 Jul 2021 16:37:44 +0800 >>>>>> Subject: [PATCH] f2fs: fix to stop filesystem update once CP failed >>>>>> >>>>>> During f2fs_write_checkpoint(), once we failed in >>>>>> f2fs_flush_nat_entries() or do_checkpoint(), metadata of filesystem >>>>>> such as prefree bitmap, nat/sit version bitmap won't be recovered, >>>>>> it may cause f2fs image to be inconsistent, let's just set CP error >>>>>> flag to avoid further updates until we figure out a scheme to rollback >>>>>> all metadatas in such condition. >>>>>> >>>>>> Reported-by: Yangtao Li >>>>>> Signed-off-by: Yangtao Li >>>>>> Signed-off-by: Chao Yu >>>>>> --- >>>>>> fs/f2fs/checkpoint.c | 10 +++++++--- >>>>>> 1 file changed, 7 insertions(+), 3 deletions(-) >>>>>> >>>>>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c >>>>>> index 6c208108d69c..096c85022f62 100644 >>>>>> --- a/fs/f2fs/checkpoint.c >>>>>> +++ b/fs/f2fs/checkpoint.c >>>>>> @@ -1639,8 +1639,10 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) >>>>>> >>>>>> /* write cached NAT/SIT entries to NAT/SIT area */ >>>>>> err = f2fs_flush_nat_entries(sbi, cpc); >>>>>> - if (err) >>>>>> + if (err) { >>>>>> + f2fs_stop_checkpoint(sbi, false); >>>>> >>>>> I think we should abuse this, since we can get any known ENOMEM as well. >>>> >>>> Yup, but one critical issue here is it can break A/B update of NAT area, >>>> so, in order to fix this hole, how about using NOFAIL memory allocation >>>> in f2fs_flush_nat_entries() first until we figure out the finial scheme? >>> >>> NOFAIL is risky, so how about adding a retry logic on ENOMEM with a message >>> and then giving up if we can't get the memory? BTW, what about EIO or other >>> family? >> >> How about this? > > Hmm, it seems we won't get ENOMEM. > > __flush_nat_entry_set > -> get_next_nat_page > -> ... > -> __get_meta_page > -> repeat on ENOMEM, but stop_checkpoint on EIO Correct, I missed to check __get_meta_page() and f2fs_get_meta_page_retry(). > > If we have an error here, we should have stopped checkpoint. Have you seen other > issue? Still we should fix the case from below path? - f2fs_write_checkpoint - do_checkpoint - f2fs_flush_device_cache failed Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel