From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Liu <chaoliu719@gmail.com>
Cc: Chao Liu <liuchao@coolpad.com>,
Wayne Zhang <zhangwen@coolpad.com>, Yue Hu <huyue2@coolpad.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks
Date: Tue, 12 Jul 2022 11:20:22 +0800 [thread overview]
Message-ID: <3ee4ce0d-2f50-ca7d-14a9-2368b9db7d13@kernel.org> (raw)
In-Reply-To: <YszQD8Pk3YTvPgpn@google.com>
On 2022/7/12 9:36, Jaegeuk Kim wrote:
> On 07/07, Chao Liu wrote:
>> From: Chao Liu <liuchao@coolpad.com>
>>
>> Files created by truncate(1) have a size but no blocks, so
>> they can be allowed to enable compression.
>>
>> Signed-off-by: Chao Liu <liuchao@coolpad.com>
>> ---
>> v2:
>> - update commit message: truncate -> truncate(1)
>>
>> fs/f2fs/file.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
>> index 0f29af7876a6..f7a82858486a 100644
>> --- a/fs/f2fs/file.c
>> +++ b/fs/f2fs/file.c
>> @@ -1879,7 +1879,7 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask)
>> if (iflags & F2FS_COMPR_FL) {
>> if (!f2fs_may_compress(inode))
>> return -EINVAL;
>> - if (S_ISREG(inode->i_mode) && inode->i_size)
>> + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode))
>
> What about inline_data case?
How about fixing this w/ a separated patch?
f2fs: fix to check inline_data during compressed inode conversion
Thanks,
>
>> return -EINVAL;
>>
>> set_compress_context(inode);
>> --
>> 2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
prev parent reply other threads:[~2022-07-12 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 9:09 [f2fs-dev] [PATCH v2] f2fs: allow compression of files without blocks Chao Liu
2022-07-07 13:32 ` Chao Yu
2022-07-12 1:36 ` Jaegeuk Kim
2022-07-12 3:20 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ee4ce0d-2f50-ca7d-14a9-2368b9db7d13@kernel.org \
--to=chao@kernel.org \
--cc=chaoliu719@gmail.com \
--cc=huyue2@coolpad.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liuchao@coolpad.com \
--cc=zhangwen@coolpad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).