From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2991BEFCE57 for ; Thu, 5 Mar 2026 01:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MD+euFygxpjeVI1vSLbdDwI8rD3RESZVoqIZen0NpHA=; b=VxsND5cGAkHmRVdoc4Nes8DcUx p+0loj30Hp+BBmR6wYXsLvElP7zL2wOQdyqH+vMSoSMXpGrtlgJObl1B5xI4kkg+i/1CWF1o4iQUN ue7usxW5z8RyDoFHOvuD0MiRRTr/YDYdliL7GV9TABHgVjZzUAFsl7IMtKEdMySRSpbc=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxxfx-0004L2-Ma; Thu, 05 Mar 2026 01:38:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxxfw-0004Kw-HA for linux-f2fs-devel@lists.sourceforge.net; Thu, 05 Mar 2026 01:38:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LlTTDibpb7AYr0S8nV5wKxtitwNJ5fGjqmgKlGdNCi4=; b=RWzUhxfZSewIpoGtcTQiVAwAU2 k8Io9wWu+g1ut36nsngPnEqdepupT1SZsS2xHuVx9oOj8kS2PjiYGUehIZycSzq+6Cd/r3ZuJajBq I2wgWJibQb3zizSlDxImax7o6nbsDsbl9VJ1xeM/KXQ5z2hPb4Yw3A9dC5LcEtSAAlL8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=LlTTDibpb7AYr0S8nV5wKxtitwNJ5fGjqmgKlGdNCi4=; b=hF9yTgZfICxCY3fQ4stavR5lum gvvwPPMpgVvY7om3zDzOmxBzaps8cU28vWtfAwm3r0F+RQqqM0pIQE03bW75qRCBTDbcFpJ2+Txm9 Z39uAfE/J0IN+rfLgLTU1NNkC9YGFiMBCwHGTvH8CzceHAxguJab2UO/3SwtrBO0a5PU=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vxxfw-0002kD-08 for linux-f2fs-devel@lists.sourceforge.net; Thu, 05 Mar 2026 01:38:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 700DF44525; Thu, 5 Mar 2026 01:38:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 839E7C4CEF7; Thu, 5 Mar 2026 01:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772674721; bh=PC0x8rLLQccI9BVwFZh3mpYbi/GIUaRDVYCDGHFylsk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=jG/CbIB9m5fUWW35CPG1wUpqV2q5g7gMA36Kuqu/tp41UL4w4UTo8QT2/VaqbuRn2 1xjuzDRnMwkbVq/3ist5dGJMz3P39F9AfyvXhnLf9dvd7zAVsMzhkr03Kp7EqUn+2L /VPloSsKC9Smceza4iCrELvVGVMbtsUkx1texR1SxdvB8n70mG+LmSQc6nsNrHAR58 7pvLkjYU/Yrlx+U6DDC7h9u3eFGlvLlCqpdajF0A8yLhB3hG/WdkyPx6uIr2uA7/c1 EL0FWT88KZ49zehQeCMUApxMeMX3B9FjtJ/7IattIonWHoOgz6zi+yCrVBbWKf4NPJ FhLgzIMX6nQ6g== Message-ID: <40f2718e-73b7-415f-9ea1-fb478b987ffe@kernel.org> Date: Thu, 5 Mar 2026 09:38:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Jianan Huang , linux-f2fs-devel@lists.sourceforge.net, jaegeuk@kernel.org References: <20260305011810.4189655-1-huangjianan@xiaomi.com> Content-Language: en-US In-Reply-To: <20260305011810.4189655-1-huangjianan@xiaomi.com> X-Headers-End: 1vxxfw-0002kD-08 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: avoid reading already updated pages during GC X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: Sheng Yong , linux-kernel@vger.kernel.org, wanghui33@xiaomi.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2026/3/5 09:18, Jianan Huang wrote: > We found the following issue during fuzz testing: > > page: refcount:3 mapcount:0 mapping:00000000b6e89c65 index:0x18b2dc pfn:0x161ba9 > memcg:f8ffff800e269c00 > aops:f2fs_meta_aops ino:2 > flags: 0x52880000000080a9(locked|waiters|uptodate|lru|private|zone=1|kasantag=0x4a) > raw: 52880000000080a9 fffffffec6e17588 fffffffec0ccc088 a7ffff8067063618 > raw: 000000000018b2dc 0000000000000009 00000003ffffffff f8ffff800e269c00 > page dumped because: VM_BUG_ON_FOLIO(folio_test_uptodate(folio)) > page_owner tracks the page as allocated > post_alloc_hook+0x58c/0x5ec > prep_new_page+0x34/0x284 > get_page_from_freelist+0x2dcc/0x2e8c > __alloc_pages_noprof+0x280/0x76c > __folio_alloc_noprof+0x18/0xac > __filemap_get_folio+0x6bc/0xdc4 > pagecache_get_page+0x3c/0x104 > do_garbage_collect+0x5c78/0x77a4 > f2fs_gc+0xd74/0x25f0 > gc_thread_func+0xb28/0x2930 > kthread+0x464/0x5d8 > ret_from_fork+0x10/0x20 > ------------[ cut here ]------------ > kernel BUG at mm/filemap.c:1563! > folio_end_read+0x140/0x168 > f2fs_finish_read_bio+0x5c4/0xb80 > f2fs_read_end_io+0x64c/0x708 > bio_endio+0x85c/0x8c0 > blk_update_request+0x690/0x127c > scsi_end_request+0x9c/0xb8c > scsi_io_completion+0xf0/0x250 > scsi_finish_command+0x430/0x45c > scsi_complete+0x178/0x6d4 > blk_mq_complete_request+0xcc/0x104 > scsi_done_internal+0x214/0x454 > scsi_done+0x24/0x34 > > which is similar to the problem reported by syzbot: > https://syzkaller.appspot.com/bug?extid=3686758660f980b402dc > > This case is consistent with the description in commit 9bf1a3f > ("f2fs: avoid GC causing encrypted file corrupted"): > Page 1 is moved from blkaddr A to blkaddr B by move_data_block, and after > being written it is marked as uptodate. Then, Page 1 is moved from blkaddr > B to blkaddr C, VM_BUG_ON_FOLIO was triggered in the endio initiated by > ra_data_block. > > There is no need to read Page 1 again from blkaddr B, since it has already > been updated. Therefore, avoid initiating I/O in this case. > > Fixes: 6aa58d8ad20a ("f2fs: readahead encrypted block during GC") > Signed-off-by: Jianan Huang > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel