From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D87EC2D0A3 for ; Thu, 12 Nov 2020 08:30:50 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D172D20870; Thu, 12 Nov 2020 08:30:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="DgiDVBqa"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="LXpTYk9l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oaquZcLq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D172D20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kd80G-0006F2-VW; Thu, 12 Nov 2020 08:30:48 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kd80F-0006Eu-LT for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 Nov 2020 08:30:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TLFN/LATVHz0Otz4gum8L+XUbArBA5q5q9A2rFFljIc=; b=DgiDVBqaK7kmrqRiqG0GbqsuAn jvuaIvNf1dqtSP21cDWWFK+ks5/ue0pot4/MdyPWfOgZa2URYJMZCnlrE7JMGShPaz9J1IWKTHe2W FLL3UWt9/UNyA60JvXvZkOYClAISnC/lbvbpG4Z1BaUmJu3LuA/YhT4eBtTY4q4/RdNU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TLFN/LATVHz0Otz4gum8L+XUbArBA5q5q9A2rFFljIc=; b=LXpTYk9l/wlqsoKakdhjdTwY9L d9FDe5IWR+lxEFXWHD4XpdaOOzL0EaVb3GZadBdw5tDy4n9JCAPNOqENji0DunC9yroSdJ7evWC26 NYvdanGXp6PtCcNH5TLzQyCMefs5qF1akdsvdS6aAHy+UH9dfdBHUxW0MTFsJzZeinEo=; Received: from mail-pl1-f195.google.com ([209.85.214.195]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1kd809-000GgF-Il for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 Nov 2020 08:30:47 +0000 Received: by mail-pl1-f195.google.com with SMTP id g11so2396735pll.13 for ; Thu, 12 Nov 2020 00:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=TLFN/LATVHz0Otz4gum8L+XUbArBA5q5q9A2rFFljIc=; b=oaquZcLqDAsF+rz7+8RuM46hMW+J4ezejO51YSSW+wSDYfj0ayzKCuWUuEMYy0Z7vI HCAdHB0rKQYHaaCitTqAWElzyqYOs9yCP3kG7X2wQYShEd4iUqP8J31Cg2wU7z2Wbc9V cZb9v6k4A7U4VrGzEiebCyFuYka+EFVRMRWWFNziFXXkP7zxCtAo4KHlQaav/fk4SyuI i0qDZn56JZ2rvoxYr/AUOVd1j6eAyVQ6+MU4chF8fkTV2068AT1DLmLiniMJzYzA8vBl JiMap8RqFLfCUG2+c8pbx6sxVDxu6JKuh2VZ9QjJ2AOBsSlsW62KMr0VTZUhrASMHmdM ui9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=TLFN/LATVHz0Otz4gum8L+XUbArBA5q5q9A2rFFljIc=; b=lh48gMoRbU7DfXuDIBcFTbkvrk4OwxnoCRa4dQRlL/hocEoKs8CmEtqGh6sS2Qg7PN zT5DJregP27MeLGNqjDSzjKF/VYuT2vxOUoHZYKFMCHryCZkpCfSw8Mpcr/ft9npvOXH UZu7YbWYaV5b8j01p0z6/5xeflsI42LZ9chaFq1/yN9QoelQ3rIKMZcMj/tls0xRu2Ke FjMfLFlo+TgFPAPTCzC5Z1QrUEAyRIBZs5RsIBnNSoHYq21XP/b3Hr15BWImFUdh04ou jO1C+iKOPboI8XkDO5RsVDNzqNFLIU/Qzej6o7j1C7raTdTyCM6eFF7QNf7ue9C5IaiE AKXA== X-Gm-Message-State: AOAM533Qv+UVOlps4Tw5rck2GesMl+rTVTGALEsV+UqSCggCoQ+w2a+e 1IVLSy8rEytA8OAOhpC8LPw= X-Google-Smtp-Source: ABdhPJzIvGCoCaoEpnMCFNMhuT6+gAIR5opIOPmp1IFU3GqBM+iWYWMqOcn1M3IZ4y9AQ6Us88i2tQ== X-Received: by 2002:a17:902:a9c7:b029:d6:da66:253c with SMTP id b7-20020a170902a9c7b02900d6da66253cmr1550636plr.19.1605169835994; Thu, 12 Nov 2020 00:30:35 -0800 (PST) Received: from [192.168.0.12] ([125.186.151.199]) by smtp.googlemail.com with ESMTPSA id n68sm5349463pfn.161.2020.11.12.00.30.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2020 00:30:35 -0800 (PST) To: Eric Biggers References: <20201112080201.149359-1-hyeongseok@gmail.com> From: hyeongseok Message-ID: <41c4c6ac-ccde-1fb9-28bb-b22f8e1c34cb@gmail.com> Date: Thu, 12 Nov 2020 17:30:31 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: ko-KR X-Headers-End: 1kd809-000GgF-Il Subject: Re: [f2fs-dev] [PATCH] f2fs: fix double free of unicode map X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Rosenberg , hyeongseok.kim@lge.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 11/12/20 5:17 PM, Eric Biggers wrote: > On Thu, Nov 12, 2020 at 05:02:01PM +0900, Hyeongseok Kim wrote: >> In case of retrying fill_super with skip_recovery, >> s_encoding for casefold would not be loaded again even though it's >> already been freed because it's not NULL. >> Set NULL after free to prevent double freeing when unmount. >> >> Signed-off-by: Hyeongseok Kim >> --- >> fs/f2fs/super.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index 00eff2f51807..fef22e476c52 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -3918,6 +3918,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent) >> >> #ifdef CONFIG_UNICODE >> utf8_unload(sb->s_encoding); >> + sb->s_encoding = NULL; >> #endif >> free_options: >> #ifdef CONFIG_QUOTA >> -- > This is: > > Fixes: eca4873ee1b6 ("f2fs: Use generic casefolding support") > > Right? > > - Eric > Right. Should I add "Fixes" tag and send v2? _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel