From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80B8C8300A for ; Thu, 30 Apr 2020 10:07:23 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85D0C2173E; Thu, 30 Apr 2020 10:07:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="SN2PHbaV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="RpFrUsqI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Rv0DAMMr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85D0C2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jU66D-0004fo-9y; Thu, 30 Apr 2020 10:07:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jU66B-0004fR-Ta for linux-f2fs-devel@lists.sourceforge.net; Thu, 30 Apr 2020 10:07:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J1aAaLwfymtTSJ5DCuryIxkiQKiJb3MkkpGzHGgV1tA=; b=SN2PHbaVssbrilSLwCuf+9FHqd y7s0JHxSTgQewiUHaXJfU/xIjxe1RqX51UmKRq6hwA3FeUwZppLLbszmhwAlFEBad3OXJQVaHny1b 3EivAdL5rYBAx/Zzyvd1aXLeneVRULPW/tUaSdRiRe9oufgMqxqZvCfa2RN/ZqUDOneI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=J1aAaLwfymtTSJ5DCuryIxkiQKiJb3MkkpGzHGgV1tA=; b=RpFrUsqID11LxJ1s+SY8uCpG0m mWVqY5G4w2Drmi2/OD7dwZ/tAhtRE1JC7cG/xHnZfyg+6ERgW+6HfbM6e2aBTQtBEX1trp9EpOexI uGZru91WMUsNkOZveMYp/o5x5Ef03yhQf7x4IxWYc1mEjXq1pxchs3tNJXrT8QN3AT3U=; Received: from mail27.static.mailgun.info ([104.130.122.27]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jU662-0056F1-JI for linux-f2fs-devel@lists.sourceforge.net; Thu, 30 Apr 2020 10:07:19 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588241233; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=J1aAaLwfymtTSJ5DCuryIxkiQKiJb3MkkpGzHGgV1tA=; b=Rv0DAMMr4bub+575MC8gE0KxfvjI2Dn/q+4GvTo0xtdQwf2tUVQYFoMowyT5MIEz7dIt0ln1 kdAX1WxZZ4F7h3rSQISwX5w5BjSgVOuY3pm2PdKQsynPwOkERn0gC+8bYHhejwQp2E+VwVYg h5P/+af7VXbDsjq3NbvCQzI9UZA= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI2M2Y4ZiIsICJsaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldCIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eaaa338.7f0124d50538-smtp-out-n01; Thu, 30 Apr 2020 10:06:48 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6F9D4C433F2; Thu, 30 Apr 2020 10:06:47 +0000 (UTC) Received: from [192.168.0.103] (unknown [183.83.143.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sayalil) by smtp.codeaurora.org (Postfix) with ESMTPSA id 37D3CC433D2; Thu, 30 Apr 2020 10:06:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 37D3CC433D2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=sayalil@codeaurora.org To: Chao Yu , jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1588179630-22819-1-git-send-email-sayalil@codeaurora.org> <7c68cd6d-d858-f80c-f258-e5e1340b9aa3@huawei.com> From: Sayali Lokhande Message-ID: <4a601e70-8738-df5b-c642-7fd1800026cc@codeaurora.org> Date: Thu, 30 Apr 2020 15:36:42 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <7c68cd6d-d858-f80c-f258-e5e1340b9aa3@huawei.com> Content-Language: en-US X-Headers-End: 1jU662-0056F1-JI Subject: Re: [f2fs-dev] [PATCH V3] f2fs: Avoid double lock for cp_rwsem during checkpoint X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 4/30/2020 6:41 AM, Chao Yu wrote: > On 2020/4/30 1:00, Sayali Lokhande wrote: >> There could be a scenario where f2fs_sync_node_pages gets >> called during checkpoint, which in turn tries to flush >> inline data and calls iput(). This results in deadlock as >> iput() tries to hold cp_rwsem, which is already held at the >> beginning by checkpoint->block_operations(). >> >> Call stack : >> >> Thread A Thread B >> f2fs_write_checkpoint() >> - block_operations(sbi) >> - f2fs_lock_all(sbi); >> - down_write(&sbi->cp_rwsem); >> >> - open() >> - igrab() >> - write() write inline data >> - unlink() >> - f2fs_sync_node_pages() >> - if (is_inline_node(page)) >> - flush_inline_data() >> - ilookup() >> page = f2fs_pagecache_get_page() >> if (!page) >> goto iput_out; >> iput_out: >> -close() >> -iput() >> iput(inode); >> - f2fs_evict_inode() >> - f2fs_truncate_blocks() >> - f2fs_lock_op() >> - down_read(&sbi->cp_rwsem); >> >> Fixes: 399368372ed9 ("f2fs: introduce a new global lock scheme") > IMO, it should be > > 2049d4fcb057 ("f2fs: avoid multiple node page writes due to inline_data") > > It brings iput() to checkpoint process for the first time. > > Thanks, Agreed. will update it. >> Signed-off-by: Sayali Lokhande >> --- >> fs/f2fs/checkpoint.c | 10 ++++------ >> 1 file changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c >> index 5ba649e..97b6378 100644 >> --- a/fs/f2fs/checkpoint.c >> +++ b/fs/f2fs/checkpoint.c >> @@ -1219,21 +1219,19 @@ static int block_operations(struct f2fs_sb_info *sbi) >> goto retry_flush_quotas; >> } >> >> -retry_flush_nodes: >> down_write(&sbi->node_write); >> >> if (get_pages(sbi, F2FS_DIRTY_NODES)) { >> up_write(&sbi->node_write); >> + up_write(&sbi->node_change); >> + f2fs_unlock_all(sbi); >> atomic_inc(&sbi->wb_sync_req[NODE]); >> err = f2fs_sync_node_pages(sbi, &wbc, false, FS_CP_NODE_IO); >> atomic_dec(&sbi->wb_sync_req[NODE]); >> - if (err) { >> - up_write(&sbi->node_change); >> - f2fs_unlock_all(sbi); >> + if (err) >> goto out; >> - } >> cond_resched(); >> - goto retry_flush_nodes; >> + goto retry_flush_quotas; >> } >> >> /* >> _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel