From: Chao Yu <chao@kernel.org>
To: Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org
Cc: kernel test robot <lkp@intel.com>,
Dan Carpenter <error27@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3 1/2] f2fs: fix to avoid potential memory corruption in __update_iostat_latency()
Date: Tue, 31 Jan 2023 09:40:16 +0800 [thread overview]
Message-ID: <4e0f4781-06ce-49e2-0bd5-031057e88888@kernel.org> (raw)
In-Reply-To: <20230120161656.70308-1-frank.li@vivo.com>
On 2023/1/21 0:16, Yangtao Li wrote:
> Add iotype sanity check to avoid potential memory corruption.
> This is to fix the compile error below:
>
> fs/f2fs/iostat.c:231 __update_iostat_latency() error: buffer overflow
> 'io_lat->peak_lat[type]' 3 <= 3
>
> vim +228 fs/f2fs/iostat.c
>
> 211 static inline void __update_iostat_latency(struct bio_iostat_ctx
> *iostat_ctx,
> 212 enum iostat_lat_type type)
> 213 {
> 214 unsigned long ts_diff;
> 215 unsigned int page_type = iostat_ctx->type;
> 216 struct f2fs_sb_info *sbi = iostat_ctx->sbi;
> 217 struct iostat_lat_info *io_lat = sbi->iostat_io_lat;
> 218 unsigned long flags;
> 219
> 220 if (!sbi->iostat_enable)
> 221 return;
> 222
> 223 ts_diff = jiffies - iostat_ctx->submit_ts;
> 224 if (page_type >= META_FLUSH)
> ^^^^^^^^^^
>
> 225 page_type = META;
> 226
> 227 spin_lock_irqsave(&sbi->iostat_lat_lock, flags);
> @228 io_lat->sum_lat[type][page_type] += ts_diff;
> ^^^^^^^^^
> Mixup between META_FLUSH and NR_PAGE_TYPE leads to memory corruption.
>
> Fixes: a4b6817625e7 ("f2fs: introduce periodic iostat io latency traces")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Suggested-by: Chao Yu <chao@kernel.org>
> Suggested-by: Jaegeuk Kim <jaegeuk@kernel.org>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-01-31 1:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 16:16 [f2fs-dev] [PATCH v3 1/2] f2fs: fix to avoid potential memory corruption in __update_iostat_latency() Yangtao Li via Linux-f2fs-devel
2023-01-20 16:16 ` [f2fs-dev] [PATCH v3 2/2] f2fs: use iostat_lat_type directly as a parameter in the iostat_update_and_unbind_ctx() Yangtao Li via Linux-f2fs-devel
2023-01-31 1:55 ` Chao Yu
2023-01-31 18:53 ` Jaegeuk Kim
2023-01-31 1:40 ` Chao Yu [this message]
2023-01-31 19:10 ` [f2fs-dev] [PATCH v3 1/2] f2fs: fix to avoid potential memory corruption in __update_iostat_latency() patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0f4781-06ce-49e2-0bd5-031057e88888@kernel.org \
--to=chao@kernel.org \
--cc=error27@gmail.com \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).