From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 979A5C00E86 for ; Wed, 20 Sep 2023 15:30:06 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qiz9Q-0005cs-Nr; Wed, 20 Sep 2023 15:30:05 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qiz9O-0005cm-Jt for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 Sep 2023 15:30:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=MIME-Version:Content-Transfer-Encoding:Content-Type :References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=shQOY5YSFRPH4MYjqUKwyU+DkSv5sjGrh2VkaY95KB0=; b=WWx6wymvJ2MC8ET3g+LrUiCHfb RukaeUocRapooCmem4/AwK6cjAYym69Skhpw0diKlQzdiHd/Sm0SIJrMYfw4HnGHItGufiPS+bERu E8tcy3YyajnydNGCGOGV33C7s0znZnKhQ0tuumVnknkiwpZCujfwSX9/695ElRBOANvg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=shQOY5YSFRPH4MYjqUKwyU+DkSv5sjGrh2VkaY95KB0=; b=EO2DBb+PTkO65lYfdEv0zfhd59 wrkXDOYfFMWKl8bjL4bzG79WheW0cHfnYIMzdBJZinDKBPlKRTdJpmEJ33H5DqMkk21OpAxKJ008J MUy8ojU5UXwDtiHgKJh6XtOONikoSaJKwpJfQXqomxHGuzr8zocRCm3lORdMCocuw84w=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qiz9M-00Gts2-W1 for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 Sep 2023 15:30:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CB0C3CE168E; Wed, 20 Sep 2023 15:29:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E996C433C7; Wed, 20 Sep 2023 15:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695223789; bh=shQOY5YSFRPH4MYjqUKwyU+DkSv5sjGrh2VkaY95KB0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=k1nl+EUmAYscMk0MAMW2wOdy5tjaXvnpQu2mWSR498aox4xq7L28RDznbIZh6rShu bXVpJ07+Dr4X3NpXfTZ0f+3K8zQ8Zd6GU7TcRKgE2VVsNXC3Y08ZZyb7CwubbNshsl rm6wzJ/+k25k/ioraZ+0GeLOcb5AuV3QTsiMjdD7WPv7IhViBMRoyEFjeAf8ki2Aj8 W8ZdClpH4+zgGo/wL79cSK2jQ4cXV/iem14axjymtw8/HBVWpvEmqX0RCWhOZdTah7 KQG1SBOFHqTYAzExj0EvSsQ5z8MaqVyH0lewm2ewDy4wd3OYa7pYLYkwfk2fAVqddy kVlr1oQs66e8A== Message-ID: <4e6b2d3addc34619e5d2e35ccbd798362a1fb95a.camel@kernel.org> From: Jeff Layton To: Christian Brauner , Chuck Lever III , Jan Kara Date: Wed, 20 Sep 2023 11:29:41 -0400 In-Reply-To: <20230920-keine-eile-c9755b5825db@brauner> References: <20230807-mgctime-v7-0-d1dec143a704@kernel.org> <20230919110457.7fnmzo4nqsi43yqq@quack3> <1f29102c09c60661758c5376018eac43f774c462.camel@kernel.org> <4511209.uG2h0Jr0uP@nimes> <08b5c6fd3b08b87fa564bb562d89381dd4e05b6a.camel@kernel.org> <20230920-leerung-krokodil-52ec6cb44707@brauner> <20230920101731.ym6pahcvkl57guto@quack3> <317d84b1b909b6c6519a2406fcb302ce22dafa41.camel@kernel.org> <20230920-raser-teehaus-029cafd5a6e4@brauner> <57C103E1-1AD2-4D86-926C-481BC6BDB191@oracle.com> <20230920-keine-eile-c9755b5825db@brauner> User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Headers-End: 1qiz9M-00Gts2-W1 Subject: Re: [f2fs-dev] [PATCH v7 12/13] ext4: switch to multigrain timestamps X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Martin Brandenburg , Konstantin Komarov , "linux-xfs@vger.kernel.org" , "Darrick J. Wong" , Dominique Martinet , Christian Schoenebeck , "linux-unionfs@vger.kernel.org" , David Howells , Chris Mason , Andreas Dilger , Hans de Goede , Marc Dionne , "codalist@coda.cs.cmu.edu" , "linux-afs@lists.infradead.org" , "linux-mtd@lists.infradead.org" , Mike Marshall , Paulo Alcantara , Amir Goldstein , Eric Van Hensbergen , "bug-gnulib@gnu.org" , Andreas Gruenbacher , Miklos Szeredi , Richard Weinberger , Mark Fasheh , Hugh Dickins , Benjamin Coddington , Tyler Hicks , "cluster-devel@redhat.com" , "coda@cs.cmu.edu" , "linux-mm@kvack.org" , Gao Xiang , Iurii Zaikin , Namjae Jeon , Trond Myklebust , Xi Ruoyao , Shyam Prasad N , "ecryptfs@vger.kernel.org" , Kees Cook , "ocfs2-devel@lists.linux.dev" , "linux-cifs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , Josef Bacik , Tom Talpey , Tejun Heo , Yue Hu , Al Viro , Ronnie Sahlberg , David Sterba , Jaegeuk Kim , "ceph-devel@vger.kernel.org" , Xiubo Li , Ilya Dryomov , OGAWA Hirofumi , Jan Harkes , Linux NFS Mailing List , "linux-ext4@vger.kernel.org" , Theodore Ts'o , Joseph Qi , Greg Kroah-Hartman , "v9fs@lists.linux.dev" , "ntfs3@lists.linux.dev" , "samba-technical@lists.samba.org" , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , Steve French , Sergey Senozhatsky , Luis Chamberlain , Jeffle Xu , "devel@lists.orangefs.org" , Anna Schumaker , Jan Kara , Bo b Peterson , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Sungjong Seo , Bruno Haible , "linux-btrfs@vger.kernel.org" , Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, 2023-09-20 at 16:53 +0200, Christian Brauner wrote: > > You could put it behind an EXPERIMENTAL Kconfig option so that the > > code stays in and can be used by the brave or foolish while it is > > still being refined. > > Given that the discussion has now fully gone back to the drawing board > and this is a regression the honest thing to do is to revert the five > patches that introduce the infrastructure: > > ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") > d48c33972916 ("tmpfs: add support for multigrain timestamps") > e44df2664746 ("xfs: switch to multigrain timestamps") > 0269b585868e ("ext4: switch to multigrain timestamps") > 50e9ceef1d4f ("btrfs: convert to multigrain timestamps") > > The conversion to helpers and cleanups are sane and should stay and can > be used for any solution that gets built on top of it. > > I'd appreciate a look at the branch here: > git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.ctime.revert > > survives xfstests. I think that's probably the wisest course of action. I need some time to ponder the options for this series anyway, and another cycle in next wouldn't hurt. The branch itself looks fine, but you might want to reverse the order of the patches in case someone lands there in the middle of a bisect. IOW, I think you want to revert the "convert to multigrain" patches before you revert the infrastructure. -- Jeff Layton _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel