From: Chao Yu <chao@kernel.org>
To: Jakob Koschel <jakobkoschel@gmail.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, "Bos, H.J." <h.j.bos@vu.nl>,
Brian Johannesmeyer <bjohannesmeyer@gmail.com>,
Cristiano Giuffrida <c.giuffrida@vu.nl>,
linux-f2fs-devel@lists.sourceforge.net,
Mike Rapoport <rppt@kernel.org>
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: replace usage of found with dedicated list iterator variable
Date: Tue, 12 Apr 2022 17:41:51 +0800 [thread overview]
Message-ID: <4fe435c4-6b6f-0223-66b8-45f9549cdc52@kernel.org> (raw)
In-Reply-To: <20220331221650.891790-2-jakobkoschel@gmail.com>
On 2022/4/1 6:16, Jakob Koschel wrote:
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-04-12 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 22:16 [f2fs-dev] [PATCH 1/2] f2fs: use separate list iterator variable to call list_move_tail() Jakob Koschel
2022-03-31 22:16 ` [f2fs-dev] [PATCH 2/2] f2fs: replace usage of found with dedicated list iterator variable Jakob Koschel
2022-04-12 9:41 ` Chao Yu [this message]
2022-04-12 9:40 ` [f2fs-dev] [PATCH 1/2] f2fs: use separate list iterator variable to call list_move_tail() Chao Yu
2022-04-12 11:02 ` Jakob Koschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe435c4-6b6f-0223-66b8-45f9549cdc52@kernel.org \
--to=chao@kernel.org \
--cc=bjohannesmeyer@gmail.com \
--cc=c.giuffrida@vu.nl \
--cc=h.j.bos@vu.nl \
--cc=jaegeuk@kernel.org \
--cc=jakobkoschel@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).