* [f2fs-dev] [PATCH] f2fs: Remove the unused argument "sbi" of func destroy_fsync_dnodes()
@ 2013-06-26 9:58 Gu Zheng
2013-06-26 23:21 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Gu Zheng @ 2013-06-26 9:58 UTC (permalink / raw)
To: jaegeuk.kim; +Cc: linux-f2fs-devel
Destroy_fsync_dnodes() is a simple list-cleanup func, so delete the unused and unrelated f2fs_sb_info argument of it.
Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
---
fs/f2fs/recovery.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 9db8239..d56d951 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -192,8 +192,7 @@ out:
return err;
}
-static void destroy_fsync_dnodes(struct f2fs_sb_info *sbi,
- struct list_head *head)
+static void destroy_fsync_dnodes(struct list_head *head)
{
struct fsync_inode_entry *entry, *tmp;
@@ -438,7 +437,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
err = recover_data(sbi, &inode_list, CURSEG_WARM_NODE);
BUG_ON(!list_empty(&inode_list));
out:
- destroy_fsync_dnodes(sbi, &inode_list);
+ destroy_fsync_dnodes(&inode_list);
kmem_cache_destroy(fsync_entry_slab);
sbi->por_doing = 0;
if (!err)
--
1.7.7
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: Remove the unused argument "sbi" of func destroy_fsync_dnodes()
2013-06-26 9:58 [f2fs-dev] [PATCH] f2fs: Remove the unused argument "sbi" of func destroy_fsync_dnodes() Gu Zheng
@ 2013-06-26 23:21 ` Jaegeuk Kim
2013-06-27 1:12 ` Gu Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2013-06-26 23:21 UTC (permalink / raw)
To: Gu Zheng; +Cc: linux-f2fs-devel
Hi Gu,
Could you check your email environment?
I can't merge your patch, since all the indentations consist of white
spaces.
And also, please check 80 characters limit per line.
Thanks,
2013-06-26 (수), 17:58 +0800, Gu Zheng:
> Destroy_fsync_dnodes() is a simple list-cleanup func, so delete the unused and unrelated f2fs_sb_info argument of it.
>
>
> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> ---
> fs/f2fs/recovery.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index 9db8239..d56d951 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -192,8 +192,7 @@ out:
> return err;
> }
>
> -static void destroy_fsync_dnodes(struct f2fs_sb_info *sbi,
> - struct list_head *head)
> +static void destroy_fsync_dnodes(struct list_head *head)
> {
> struct fsync_inode_entry *entry, *tmp;
>
> @@ -438,7 +437,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
> err = recover_data(sbi, &inode_list, CURSEG_WARM_NODE);
> BUG_ON(!list_empty(&inode_list));
> out:
> - destroy_fsync_dnodes(sbi, &inode_list);
> + destroy_fsync_dnodes(&inode_list);
> kmem_cache_destroy(fsync_entry_slab);
> sbi->por_doing = 0;
> if (!err)
--
Jaegeuk Kim
Samsung
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: Remove the unused argument "sbi" of func destroy_fsync_dnodes()
2013-06-26 23:21 ` Jaegeuk Kim
@ 2013-06-27 1:12 ` Gu Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Gu Zheng @ 2013-06-27 1:12 UTC (permalink / raw)
To: jaegeuk.kim; +Cc: linux-f2fs-devel
On 06/27/2013 07:21 AM, Jaegeuk Kim wrote:
> Hi Gu,
>
> Could you check your email environment?
> I can't merge your patch, since all the indentations consist of white
> spaces.
> And also, please check 80 characters limit per line.
> Thanks,
OK, thanks for your reminder.
Regards,
Gu
>
> 2013-06-26 (수), 17:58 +0800, Gu Zheng:
>> Destroy_fsync_dnodes() is a simple list-cleanup func, so delete the unused and unrelated f2fs_sb_info argument of it.
>>
>>
>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>> ---
>> fs/f2fs/recovery.c | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
>> index 9db8239..d56d951 100644
>> --- a/fs/f2fs/recovery.c
>> +++ b/fs/f2fs/recovery.c
>> @@ -192,8 +192,7 @@ out:
>> return err;
>> }
>>
>> -static void destroy_fsync_dnodes(struct f2fs_sb_info *sbi,
>> - struct list_head *head)
>> +static void destroy_fsync_dnodes(struct list_head *head)
>> {
>> struct fsync_inode_entry *entry, *tmp;
>>
>> @@ -438,7 +437,7 @@ int recover_fsync_data(struct f2fs_sb_info *sbi)
>> err = recover_data(sbi, &inode_list, CURSEG_WARM_NODE);
>> BUG_ON(!list_empty(&inode_list));
>> out:
>> - destroy_fsync_dnodes(sbi, &inode_list);
>> + destroy_fsync_dnodes(&inode_list);
>> kmem_cache_destroy(fsync_entry_slab);
>> sbi->por_doing = 0;
>> if (!err)
>
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-27 1:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-26 9:58 [f2fs-dev] [PATCH] f2fs: Remove the unused argument "sbi" of func destroy_fsync_dnodes() Gu Zheng
2013-06-26 23:21 ` Jaegeuk Kim
2013-06-27 1:12 ` Gu Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).