linux-f2fs-devel.lists.sourceforge.net archive mirror
 help / color / mirror / Atom feed
From: Gu Zheng <guz.fnst@cn.fujitsu.com>
To: jaegeuk.kim@samsung.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	f2fs <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes()
Date: Tue, 23 Jul 2013 09:24:06 +0800	[thread overview]
Message-ID: <51EDDB36.8020904@cn.fujitsu.com> (raw)
In-Reply-To: <1374497479.26443.20.camel@kjgkr>

On 07/22/2013 08:51 PM, Jaegeuk Kim wrote:

> Hi,
> 
> 2013-07-19 (금), 16:18 +0800, Gu Zheng:
>> After writing orphan inode entry in jornal block, we need to delete each
>> entry from the orphan entry list, and release them.
>>
>>
>> Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
>> ---
>>  fs/f2fs/checkpoint.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c
>> index 66a6b85..290db04 100644
>> --- a/fs/f2fs/checkpoint.c
>> +++ b/fs/f2fs/checkpoint.c
>> @@ -337,6 +337,10 @@ static void write_orphan_inodes(struct f2fs_sb_info *sbi, block_t start_blk)
>>  		memset(orphan_blk, 0, sizeof(*orphan_blk));
>>  page_exist:
>>  		orphan_blk->ino[nentries++] = cpu_to_le32(orphan->ino);
>> +
>> +		list_del(&orphan->list);
>> +		kmem_cache_free(orphan_entry_slab, orphan);
>> +		sbi->n_orphans--;
> 
> NAK.
> We should not release them here.
> Only f2fs_evict_inode can do it. 

Yeah, f2fs_evict_inode can do this job safely, sorry for my mistake,
please ignore this patch.:)

Regards,
Gu 

> 
>>  	}
>>  	if (!page)
>>  		goto end;
> 



------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

      reply	other threads:[~2013-07-23  1:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-19  8:18 [PATCH] f2fs: add the missing delection of orphan inode entry in write_orphan_inodes() Gu Zheng
2013-07-22 12:51 ` [f2fs-dev] " Jaegeuk Kim
2013-07-23  1:24   ` Gu Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51EDDB36.8020904@cn.fujitsu.com \
    --to=guz.fnst@cn.fujitsu.com \
    --cc=jaegeuk.kim@samsung.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).