From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chandan Rajendra Subject: Re: [PATCH 05/13] fscrypt: introduce fscrypt_encrypt_block_inplace() Date: Mon, 06 May 2019 14:07:31 +0530 Message-ID: <5212233.NpK8FDItVt@dhcp-9-109-212-164> References: <20190501224515.43059-1-ebiggers@kernel.org> <20190501224515.43059-6-ebiggers@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hNbt7-0003ce-5x for linux-f2fs-devel@lists.sourceforge.net; Mon, 06 May 2019 11:34:29 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hNbt3-007eYp-17 for linux-f2fs-devel@lists.sourceforge.net; Mon, 06 May 2019 11:34:29 +0000 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x46BXu4o129264 for ; Mon, 6 May 2019 07:34:19 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sajd249em-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 May 2019 07:34:17 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 May 2019 12:33:37 +0100 In-Reply-To: <20190501224515.43059-6-ebiggers@kernel.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Eric Biggers Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mtd@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net On Thursday, May 2, 2019 4:15:07 AM IST Eric Biggers wrote: > From: Eric Biggers > > fscrypt_encrypt_page() behaves very differently depending on whether the > filesystem set FS_CFLG_OWN_PAGES in its fscrypt_operations. This makes > the function difficult to understand and document. It also makes it so > that all callers have to provide inode and lblk_num, when fscrypt could > determine these itself for pagecache pages. > > Therefore, move the FS_CFLG_OWN_PAGES behavior into a new function > fscrypt_encrypt_block_inplace(). Looks good to me, Reviewed-by: Chandan Rajendra -- chandan