From mboxrd@z Thu Jan 1 00:00:00 1970 From: Younger Liu Subject: [PATCH 0/2] f2fs: remove debufs dir if debugfs_create_file() failed Date: Mon, 02 Dec 2013 21:16:08 +0800 Message-ID: <529C8818.2090002@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VnTMJ-00012g-HQ for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Dec 2013 13:16:19 +0000 Received: from mail-pb0-f49.google.com ([209.85.160.49]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1VnTMI-0004Yc-N8 for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Dec 2013 13:16:19 +0000 Received: by mail-pb0-f49.google.com with SMTP id jt11so18639885pbb.8 for ; Mon, 02 Dec 2013 05:16:12 -0800 (PST) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Jaegeuk Kim Cc: fs-devel , kernel , f2fs From: Younger Liu When debugfs_create_file() failed in f2fs_create_root_stats(), debugfs_root should be removed. Signed-off-by: Younger Liu Cc: Younger Liu Cc: Jaegeuk Kim --- fs/f2fs/debug.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index a84b0a8..d27b689 100644 --- a/fs/f2fs/debug.c +++ b/fs/f2fs/debug.c @@ -340,10 +340,24 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi) void __init f2fs_create_root_stats(void) { + struct dentry *file; + debugfs_root = debugfs_create_dir("f2fs", NULL); - if (debugfs_root) - debugfs_create_file("status", S_IRUGO, debugfs_root, - NULL, &stat_fops); + if (!debugfs_root) + goto bail; + + file = debugfs_create_file("status", S_IRUGO, + debugfs_root, NULL, &stat_fops); + if (!file) + goto free_debugfs_dir; + + return; + +free_debugfs_dir: + debugfs_remove(debugfs_root); + +bail: + return; } void f2fs_destroy_root_stats(void) -- 1.7.9.5 ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk