From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gu Zheng Subject: Re: f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall Date: Thu, 13 Feb 2014 17:48:00 +0800 Message-ID: <52FC94D0.2050705@cn.fujitsu.com> References: <52F320FC.50803@ispras.ru> <1391666564.25542.78.camel@kjgkr> <52F37D67.208@ispras.ru> <1391734185.25542.80.camel@kjgkr> <1391749933.25542.83.camel@kjgkr> <52F9DF85.7040402@ispras.ru> <52FC832F.6000103@cn.fujitsu.com> <52FC9315.2090707@ispras.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1WDt1y-0003JH-JC for linux-f2fs-devel@lists.sourceforge.net; Thu, 13 Feb 2014 09:56:30 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1WDt1x-0008Rm-2G for linux-f2fs-devel@lists.sourceforge.net; Thu, 13 Feb 2014 09:56:30 +0000 In-Reply-To: <52FC9315.2090707@ispras.ru> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Andrey Tsyvarev Cc: linux-kernel , linux-f2fs-devel@lists.sourceforge.net Hi, On 02/13/2014 05:40 PM, Andrey Tsyvarev wrote: > Hi, > >> BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path >> of init_inode_metadata? >> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c >> index e095a4f..d5a2c9e 100644 >> --- a/fs/f2fs/dir.c >> +++ b/fs/f2fs/dir.c >> @@ -375,6 +375,7 @@ put_error: >> /* once the failed inode becomes a bad inode, i_mode is S_IFREG */ >> truncate_inode_pages(&inode->i_data, 0); >> truncate_blocks(inode, 0); >> + remove_dirty_dir_inode(inode); >> error: >> remove_inode_page(inode); >> return ERR_PTR(err); > Yes, i have tested that case. Fail in init_inode_metadata has been processed correctly. Thanks. If no other regressions, maybe you can send out the fix patch about this issue.:) Thanks, Gu > ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk