From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F704C433F5 for ; Tue, 2 Nov 2021 01:29:13 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5156E610A0; Tue, 2 Nov 2021 01:29:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5156E610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1mhibv-00011S-L4; Tue, 02 Nov 2021 01:29:11 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mhibu-00011M-Bl for linux-f2fs-devel@lists.sourceforge.net; Tue, 02 Nov 2021 01:29:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=C4UxcBOoOLIfAKidKnB1PH6RINBgvBnrzOhJNj+/kG0=; b=gpsjEMzmwfRVMChBhnYtVSAtAP pE6TNRUrx0vQFg3JqZFVV0xiUKmxn/OMwn/NrPnknmwpjWUQWNLdIu8pJAb8pKqbz5CpyhD4Gr0sQ LdFxNAeTaZ7nPPKcZhONvK5gjB3DkxvOVC+oy+bdZvtQzOn+hAcm4sgTvOKowV6riGy8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C4UxcBOoOLIfAKidKnB1PH6RINBgvBnrzOhJNj+/kG0=; b=k49uGVJOWlK2T9pR+bDRX0wVPw 8Gr/gN4d5RQ13YTlAAkvkkTsOHV5jcY1lOhXtyB72ZEo0U7OvCvRBdNH61iBbm7shpvYs29Ts3Hv2 zEXiLGCLJZdMZiyh4LT3uOIGS9n2xYjhjylnHs3Xe9DQ633pFmMNFV8FuXE7QlvendzA=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mhibs-00033E-Lw for linux-f2fs-devel@lists.sourceforge.net; Tue, 02 Nov 2021 01:29:10 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8100E610CC; Tue, 2 Nov 2021 01:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635816538; bh=U4ZfHBCoy7l0t3Jy95ZI7OxQi81CBShvutclXQmAFT0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=h3e/wPN49mFL+g6AWga1fecsxgMNYCRZpqscSnDcjjDs+1bnHGvZNIDMocr78L448 XJeP3J6z4+6AhonbxwIiX3Q3hJXdlQwKivUvTvDgMX7VxPVHjDtzHCHRT2UFWSb8Hh dEnyUc42UULcpm/Ta19CFsa5Kxz/Y82qR5hWODdnJybgS8fpUFBslyoc438CZMpOCI KG/QAUqYWU+mxLCt+SFA4RrGrdrnPMpqkNwlPSpyJGdyPDlGM8rCgXC7Y8HOCStydp LLkgxU1TvVVHc4l3Qi6G8O3RuvUfMYd8oOoZPrhk5BJehbuuWSNNxAAqWdSHu9O6HM eWFfYFvG0qrZA== Message-ID: <56b09503-e545-919b-b86b-d90d9b84fbae@kernel.org> Date: Tue, 2 Nov 2021 09:28:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Content-Language: en-US To: Hyeong-Jun Kim , Jaegeuk Kim References: <20211101084634.38727-1-hj514.kim@samsung.com> From: Chao Yu In-Reply-To: <20211101084634.38727-1-hj514.kim@samsung.com> X-Headers-End: 1mhibs-00033E-Lw Subject: Re: [f2fs-dev] [PATCH v2] F2FS: invalidate META_MAPPING before IPU/DIO write X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/11/1 16:46, Hyeong-Jun Kim wrote: > Encrypted pages during GC are read and cached in META_MAPPING. > However, due to cached pages in META_MAPPING, there is an issue where > newly written pages are lost by IPU or DIO writes. > > Thread A - f2fs_gc() Thread B > /* phase 3 */ > down_write(i_gc_rwsem) > ra_data_block() ---- (a) > up_write(i_gc_rwsem) > f2fs_direct_IO() : > - down_read(i_gc_rwsem) > - __blockdev_direct_io() > - get_data_block_dio_write() > - f2fs_dio_submit_bio() ---- (b) > - up_read(i_gc_rwsem) > /* phase 4 */ > down_write(i_gc_rwsem) > move_data_block() ---- (c) > up_write(i_gc_rwsem) > > (a) In phase 3 of f2fs_gc(), up-to-date page is read from storage and > cached in META_MAPPING. > (b) In thread B, writing new data by IPU or DIO write on same blkaddr as > read in (a). cached page in META_MAPPING become out-dated. > (c) In phase 4 of f2fs_gc(), out-dated page in META_MAPPING is copied to > new blkaddr. In conclusion, the newly written data in (b) is lost. > > To address this issue, invalidating pages in META_MAPPING before IPU or > DIO write. > > Fixes: 6aa58d8ad20a ("f2fs: readahead encrypted block during GC") > Signed-off-by: Hyeong-Jun Kim Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel