From: Chao Yu <chao@kernel.org>
To: Yunlong Song <yunlong.song@huawei.com>,
jaegeuk@kernel.org, cm224.lee@samsung.com, yuchao0@huawei.com,
sylinux@163.com
Cc: bintian.wang@huawei.com, houpengyang@huawei.com,
heyunlei@huawei.com, liushuoran@huawei.com, shiguojun@huawei.com,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix to return 0 if err == -ENOENT in f2fs_readdir
Date: Wed, 27 Apr 2016 21:25:09 +0800 [thread overview]
Message-ID: <5720BDB5.9000106@kernel.org> (raw)
In-Reply-To: <1461760357-13882-1-git-send-email-yunlong.song@huawei.com>
On 2016/4/27 20:32, Yunlong Song wrote:
> Commit 57b62d29ad5b384775974973087d47755a8c6fcc ("f2fs: fix to report
> error in f2fs_readdir") causes f2fs_readdir to return -ENOENT when
> get_lock_data_page returns -ENOENT. However, the original logic is to
> continue when get_lock_data_page returns -ENOENT, but it forgets to
> reset err to 0.
>
> This will cause getdents64 incorretly return -ENOENT when lastdirent is
> NULL in getdents64. This will lead to a wrong return value for syscall
> caller.
>
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
prev parent reply other threads:[~2016-04-27 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 12:32 [PATCH] f2fs: fix to return 0 if err == -ENOENT in f2fs_readdir Yunlong Song
2016-04-27 13:25 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720BDB5.9000106@kernel.org \
--to=chao@kernel.org \
--cc=bintian.wang@huawei.com \
--cc=cm224.lee@samsung.com \
--cc=heyunlei@huawei.com \
--cc=houpengyang@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liushuoran@huawei.com \
--cc=shiguojun@huawei.com \
--cc=sylinux@163.com \
--cc=yuchao0@huawei.com \
--cc=yunlong.song@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).