From: Sheng Yong <shengyong1@huawei.com>
To: Kinglong Mee <kinglongmee@gmail.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] mkfs.f2fs: fix bad assignment of total_sectors for f2fs_configuration
Date: Tue, 24 Jan 2017 11:06:56 +0800 [thread overview]
Message-ID: <5886C4D0.8040601@huawei.com> (raw)
In-Reply-To: <130c919b-def1-33b1-0e16-e18e8de28d5c@gmail.com>
Hi, Kinglong
On 1/24/2017 10:42 AM, Kinglong Mee wrote:
> wanted_total_sectors is introduced instead total_sectors,
> so that, the initialize is a fault, drop it.
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
> mkfs/f2fs_format_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
> index db1dc94..5bb1faf 100644
> --- a/mkfs/f2fs_format_main.c
> +++ b/mkfs/f2fs_format_main.c
> @@ -151,9 +151,6 @@ static void f2fs_parse_options(int argc, char *argv[])
> c.wanted_total_sectors = atoll(argv[optind+1]);
> }
>
> - if ((optind + 1) < argc)
> - c.total_sectors = atoll(argv[optind+1]);
> -
Here we get the number of sectors specified by user, so that we could
create an image based on a specific size. There seems no fault. Could
you please give more detail :)
thanks,
Sheng
> if (c.zoned_mode)
> c.feature |= cpu_to_le32(F2FS_FEATURE_BLKZONED);
> }
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-01-24 3:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 2:42 [PATCH] mkfs.f2fs: fix bad assignment of total_sectors for f2fs_configuration Kinglong Mee
2017-01-24 3:06 ` Sheng Yong [this message]
2017-02-03 8:08 ` Kinglong Mee
2017-02-03 9:40 ` Sheng Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5886C4D0.8040601@huawei.com \
--to=shengyong1@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=kinglongmee@gmail.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).