From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9D6FC433EF for ; Fri, 13 May 2022 03:20:41 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1npLr6-0003PF-9l; Fri, 13 May 2022 03:20:38 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1npLr4-0003P9-Td for linux-f2fs-devel@lists.sourceforge.net; Fri, 13 May 2022 03:20:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t7MVnkthwOMUtxUG7u6NwMn/z03/xnF2WGs+kPzPugU=; b=ZAqkGY9C3hlZWkgk5hahse6785 RdL2ibMrxqUjRTWz3b1W3c6hjpadaLb3h5bZPwM9iqSwcKbUfz4vS8Q3llSkdqI/ai11c4sn/4091 eFvDyKULbnlS4LchNrPmX/MwMLnmPFHxtZHnbdiFVum1KRea2XR2LuTI6m+8Pv4+RvUg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=t7MVnkthwOMUtxUG7u6NwMn/z03/xnF2WGs+kPzPugU=; b=lbFkTHtvRRwAtQ1BKb0wWxw+Es OoLT2YZo6LIz9T3bqS7Lpi855tPjI6Lz+BRQ2psFbevATTwzeGgQQ3e1HNy0Qe4UXatk+qERxazYF NVDgJYOC7WDLyzZK7BnLWPISOnFbbD/IVlH3rADHV646LtQRt19j1M3CnENZvqtM8PaU=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1npLr2-00ASnR-J9 for linux-f2fs-devel@lists.sourceforge.net; Fri, 13 May 2022 03:20:37 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 802C060DDA; Fri, 13 May 2022 03:20:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE96BC34114; Fri, 13 May 2022 03:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652412022; bh=hdMV5sPfTunSBVCwaFuDJWydnVmvnF5pcYL4ULj4sKM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IuiJthlPFvC30uiUWY5IFhJjePaSVjBThf2n0N7YYPToe3kUTyEZs37sjVkX8OLH8 /gVYsRLvPCsHT961rv+kbdkopwtQ28zhMqmeOyCakCoPubmB5UHt6//I+On8zZ0iKA y63aWmAqVxN5LjZ+IhMuNwrYquYRX5R+rW4t8O/HSz7Wg7toVcmYODXm4KavK/R5ta 08cY0H038rLW1zvilm1Xu48oqpOf+PmD3y7Eh1mgg1uH8C1pQEgXiTI0UJRYdKMd2n pD4pL8QQO9v/sNAivlgHCedbMEKV86iq2o2P+KeAXegLV+JftuqM7y+3sbXscQfMS3 akdb8Q1V3A4rw== Message-ID: <59d77fcb-bc82-c1d2-0a71-eef3b0140506@kernel.org> Date: Fri, 13 May 2022 11:20:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Jaegeuk Kim References: <20220512082116.2991611-1-chao@kernel.org> From: Chao Yu In-Reply-To: X-Headers-End: 1npLr2-00ASnR-J9 Subject: Re: [f2fs-dev] [PATCH] f2fs: separate NOCoW and pinfile semantics X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2022/5/13 5:57, Jaegeuk Kim wrote: > On 05/12, Chao Yu wrote: >> Pinning a file is heavy, because skipping pinned files make GC >> running with heavy load or no effect. >> >> So that this patch proposes to separate nocow and pinfile semantics: >> - NOCoW flag can only be set on regular file. >> - NOCoW file will only trigger IPU at common writeback/flush. >> - NOCow file will do OPU during GC. >> >> This flag can satisfying the demand of: >> 1) avoiding fragment of file's physical block >> 2) userspace doesn't want to pin file's physical address >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/data.c | 3 ++- >> fs/f2fs/f2fs.h | 1 + >> fs/f2fs/file.c | 25 ++++++++++++++++++++++++- >> 3 files changed, 27 insertions(+), 2 deletions(-) >> >> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c >> index 54a7a8ad994d..c8eab78f7d89 100644 >> --- a/fs/f2fs/data.c >> +++ b/fs/f2fs/data.c >> @@ -2495,7 +2495,8 @@ bool f2fs_should_update_inplace(struct inode *inode, struct f2fs_io_info *fio) >> if (is_inode_flag_set(inode, FI_ALIGNED_WRITE)) >> return false; >> >> - if (f2fs_is_pinned_file(inode)) >> + if (f2fs_is_pinned_file(inode) || >> + F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) >> return true; >> >> /* if this is cold file, we should overwrite to avoid fragmentation */ >> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h >> index 492af5b96de1..e91ece55f5e8 100644 >> --- a/fs/f2fs/f2fs.h >> +++ b/fs/f2fs/f2fs.h >> @@ -2916,6 +2916,7 @@ static inline void f2fs_change_bit(unsigned int nr, char *addr) >> #define F2FS_NOCOMP_FL 0x00000400 /* Don't compress */ >> #define F2FS_INDEX_FL 0x00001000 /* hash-indexed directory */ >> #define F2FS_DIRSYNC_FL 0x00010000 /* dirsync behaviour (directories only) */ >> +#define F2FS_NOCOW_FL 0x00800000 /* Do not cow file */ >> #define F2FS_PROJINHERIT_FL 0x20000000 /* Create with parents projid */ >> #define F2FS_CASEFOLD_FL 0x40000000 /* Casefolded file */ >> >> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c >> index 09287876dbb7..7f92a3a157f7 100644 >> --- a/fs/f2fs/file.c >> +++ b/fs/f2fs/file.c >> @@ -1851,6 +1851,20 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) >> if (IS_NOQUOTA(inode)) >> return -EPERM; >> >> + if ((iflags ^ masked_flags) & F2FS_NOCOW_FL) { >> + int ret; >> + >> + if (!S_ISREG(inode->i_mode)) >> + return -EINVAL; >> + if (f2fs_should_update_outplace(inode, NULL)) >> + return -EINVAL; >> + if (f2fs_is_pinned_file(inode)) >> + return -EINVAL; >> + ret = f2fs_convert_inline_inode(inode); >> + if (ret) >> + return ret; >> + } >> + >> if ((iflags ^ masked_flags) & F2FS_CASEFOLD_FL) { >> if (!f2fs_sb_has_casefold(F2FS_I_SB(inode))) >> return -EOPNOTSUPP; >> @@ -1926,6 +1940,7 @@ static const struct { >> { F2FS_NOCOMP_FL, FS_NOCOMP_FL }, >> { F2FS_INDEX_FL, FS_INDEX_FL }, >> { F2FS_DIRSYNC_FL, FS_DIRSYNC_FL }, >> + { F2FS_NOCOW_FL, FS_NOCOW_FL }, >> { F2FS_PROJINHERIT_FL, FS_PROJINHERIT_FL }, >> { F2FS_CASEFOLD_FL, FS_CASEFOLD_FL }, >> }; >> @@ -1957,7 +1972,8 @@ static const struct { >> FS_NOCOMP_FL | \ >> FS_DIRSYNC_FL | \ >> FS_PROJINHERIT_FL | \ >> - FS_CASEFOLD_FL) >> + FS_CASEFOLD_FL | \ >> + FS_NOCOW_FL) >> >> /* Convert f2fs on-disk i_flags to FS_IOC_{GET,SET}FLAGS flags */ >> static inline u32 f2fs_iflags_to_fsflags(u32 iflags) >> @@ -3081,6 +3097,13 @@ static int f2fs_ioc_set_pin_file(struct file *filp, unsigned long arg) >> >> inode_lock(inode); >> >> + if (F2FS_I(inode)->i_flags & F2FS_NOCOW_FL) { >> + f2fs_info(F2FS_I_SB(inode), "inode (%lu) is already NOCOW one", >> + inode->i_ino); >> + ret = -EINVAL; > > Why rejecting this? We can pin the file to get 2MB-aligned allocation on the > NOCOW file. I try to separate these two flag completely, but, seems it can't, because after commit 5d539245cb18 ("f2fs: export FS_NOCOW_FL flag to user"), these two flags have already been twined closely.... @@ -1651,6 +1651,8 @@ static int f2fs_ioc_getflags(struct file *filp, unsigned long arg) flags |= F2FS_ENCRYPT_FL; if (f2fs_has_inline_data(inode) || f2fs_has_inline_dentry(inode)) flags |= F2FS_INLINE_DATA_FL; + if (is_inode_flag_set(inode, FI_PIN_FILE)) + flags |= F2FS_NOCOW_FL; How about: f2fs_ioc_set_pin_file/f2fs_fileattr_set logic: pinfile nocow set set pinfile | nocow set nocow clear clear pinfile | nocow clear nocow Behaviors: w/ pinfile, w/ nocow: use pinfile semantics w/ pinfile, w/o nocow: use pinfile semantics w/o pinfile, w/ nocow: use nocow semantics w/o pinfile, w/o nocow: no pinfile or nocow semantics Thanks, > >> + goto out; >> + } >> + >> if (!pin) { >> clear_inode_flag(inode, FI_PIN_FILE); >> f2fs_i_gc_failures_write(inode, 0); >> -- >> 2.25.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel