From: Chao Yu <chao@kernel.org>
To: Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: drop useless initializer and unneeded local variable
Date: Wed, 11 Jan 2023 21:25:51 +0800 [thread overview]
Message-ID: <59f19f5f-dcde-6042-cbc1-eee4b3d2469b@kernel.org> (raw)
In-Reply-To: <20221222081855.81553-1-frank.li@vivo.com>
On 2022/12/22 16:18, Yangtao Li wrote:
> No need to initialize idx twice. BTW, remove the unnecessary cnt variable.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/f2fs/iostat.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/fs/f2fs/iostat.c b/fs/f2fs/iostat.c
> index 3166a8939ed4..335b055ffe7d 100644
> --- a/fs/f2fs/iostat.c
> +++ b/fs/f2fs/iostat.c
> @@ -97,8 +97,7 @@ int __maybe_unused iostat_info_seq_show(struct seq_file *seq, void *offset)
>
> static inline void __record_iostat_latency(struct f2fs_sb_info *sbi)
> {
> - int io, idx = 0;
> - unsigned int cnt;
> + int io, idx;
> struct f2fs_iostat_latency iostat_lat[MAX_IO_TYPE][NR_PAGE_TYPE];
> struct iostat_lat_info *io_lat = sbi->iostat_io_lat;
> unsigned long flags;
> @@ -106,12 +105,11 @@ static inline void __record_iostat_latency(struct f2fs_sb_info *sbi)
> spin_lock_irqsave(&sbi->iostat_lat_lock, flags);
> for (idx = 0; idx < MAX_IO_TYPE; idx++) {
> for (io = 0; io < NR_PAGE_TYPE; io++) {
> - cnt = io_lat->bio_cnt[idx][io];
> iostat_lat[idx][io].peak_lat =
> jiffies_to_msecs(io_lat->peak_lat[idx][io]);
> - iostat_lat[idx][io].cnt = cnt;
> - iostat_lat[idx][io].avg_lat = cnt ?
> - jiffies_to_msecs(io_lat->sum_lat[idx][io]) / cnt : 0;
> + iostat_lat[idx][io].cnt = io_lat->bio_cnt[idx][io];
> + iostat_lat[idx][io].avg_lat = iostat_lat[idx][io].cnt ?
> + jiffies_to_msecs(io_lat->sum_lat[idx][io]) / iostat_lat[idx][io].cnt : 0;
exceed 80 column?
Thanks,
> io_lat->sum_lat[idx][io] = 0;
> io_lat->peak_lat[idx][io] = 0;
> io_lat->bio_cnt[idx][io] = 0;
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2023-01-11 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 8:18 [f2fs-dev] [PATCH] f2fs: drop useless initializer and unneeded local variable Yangtao Li via Linux-f2fs-devel
2023-01-11 13:25 ` Chao Yu [this message]
2023-01-12 14:46 ` Yangtao Li via Linux-f2fs-devel
2023-01-30 23:00 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59f19f5f-dcde-6042-cbc1-eee4b3d2469b@kernel.org \
--to=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).