* [PATCH] f2fs: avoid the global name 'fault_name'
@ 2018-06-30 15:57 Gao Xiang
2018-06-30 16:06 ` Gao Xiang
2018-07-01 2:23 ` Chao Yu
0 siblings, 2 replies; 4+ messages in thread
From: Gao Xiang @ 2018-06-30 15:57 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: Gao Xiang, linux-f2fs-devel, linux-kernel
Non-prefix global name 'fault_name' will pollute global
namespace, fix it.
Refer to:
https://lists.01.org/pipermail/kbuild-all/2018-June/049660.html
To: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
---
fs/f2fs/f2fs.h | 4 ++--
fs/f2fs/super.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 4d8b1de..11a2e09 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -65,7 +65,7 @@ struct f2fs_fault_info {
unsigned int inject_type;
};
-extern char *fault_name[FAULT_MAX];
+extern char *f2fs_fault_name[FAULT_MAX];
#define IS_FAULT_SET(fi, type) ((fi)->inject_type & (1 << (type)))
#endif
@@ -1279,7 +1279,7 @@ struct f2fs_sb_info {
#ifdef CONFIG_F2FS_FAULT_INJECTION
#define f2fs_show_injection_info(type) \
printk("%sF2FS-fs : inject %s in %s of %pF\n", \
- KERN_INFO, fault_name[type], \
+ KERN_INFO, f2fs_fault_name[type], \
__func__, __builtin_return_address(0))
static inline bool time_to_inject(struct f2fs_sb_info *sbi, int type)
{
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 3995e92..df12dcd 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -41,7 +41,7 @@
#ifdef CONFIG_F2FS_FAULT_INJECTION
-char *fault_name[FAULT_MAX] = {
+char *f2fs_fault_name[FAULT_MAX] = {
[FAULT_KMALLOC] = "kmalloc",
[FAULT_KVMALLOC] = "kvmalloc",
[FAULT_PAGE_ALLOC] = "page alloc",
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] f2fs: avoid the global name 'fault_name'
2018-06-30 15:57 [PATCH] f2fs: avoid the global name 'fault_name' Gao Xiang
@ 2018-06-30 16:06 ` Gao Xiang
2018-07-01 2:25 ` [f2fs-dev] " Chao Yu
2018-07-01 2:23 ` Chao Yu
1 sibling, 1 reply; 4+ messages in thread
From: Gao Xiang @ 2018-06-30 16:06 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: linux-kernel, linux-f2fs-devel
Oh, I just found the same patch written by Chao at:
https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?h=f2fs-dev
I just fixed the erofs name conflicts, so fixed f2fs as well.
Please ignore this one.
Thanks,
Gao Xiang
On 2018/6/30 23:57, Gao Xiang wrote:
> Non-prefix global name 'fault_name' will pollute global
> namespace, fix it.
>
> Refer to:
> https://lists.01.org/pipermail/kbuild-all/2018-June/049660.html
>
> To: Jaegeuk Kim <jaegeuk@kernel.org>
> To: Chao Yu <yuchao0@huawei.com>
> Cc: linux-f2fs-devel@lists.sourceforge.net
> Cc: linux-kernel@vger.kernel.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
> ---
> fs/f2fs/f2fs.h | 4 ++--
> fs/f2fs/super.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 4d8b1de..11a2e09 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -65,7 +65,7 @@ struct f2fs_fault_info {
> unsigned int inject_type;
> };
>
> -extern char *fault_name[FAULT_MAX];
> +extern char *f2fs_fault_name[FAULT_MAX];
> #define IS_FAULT_SET(fi, type) ((fi)->inject_type & (1 << (type)))
> #endif
>
> @@ -1279,7 +1279,7 @@ struct f2fs_sb_info {
> #ifdef CONFIG_F2FS_FAULT_INJECTION
> #define f2fs_show_injection_info(type) \
> printk("%sF2FS-fs : inject %s in %s of %pF\n", \
> - KERN_INFO, fault_name[type], \
> + KERN_INFO, f2fs_fault_name[type], \
> __func__, __builtin_return_address(0))
> static inline bool time_to_inject(struct f2fs_sb_info *sbi, int type)
> {
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 3995e92..df12dcd 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -41,7 +41,7 @@
>
> #ifdef CONFIG_F2FS_FAULT_INJECTION
>
> -char *fault_name[FAULT_MAX] = {
> +char *f2fs_fault_name[FAULT_MAX] = {
> [FAULT_KMALLOC] = "kmalloc",
> [FAULT_KVMALLOC] = "kvmalloc",
> [FAULT_PAGE_ALLOC] = "page alloc",
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [f2fs-dev] [PATCH] f2fs: avoid the global name 'fault_name'
2018-06-30 16:06 ` Gao Xiang
@ 2018-07-01 2:25 ` Chao Yu
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2018-07-01 2:25 UTC (permalink / raw)
To: Gao Xiang, Jaegeuk Kim, Chao Yu; +Cc: linux-kernel, linux-f2fs-devel
On 2018/7/1 0:06, Gao Xiang wrote:
>
> Oh, I just found the same patch written by Chao at:
> https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?h=f2fs-dev
>
> I just fixed the erofs name conflicts, so fixed f2fs as well.
> Please ignore this one.
I didn't send it out, I think merging yours will be fine to me. :)
Thanks,
>
> Thanks,
> Gao Xiang
>
> On 2018/6/30 23:57, Gao Xiang wrote:
>> Non-prefix global name 'fault_name' will pollute global
>> namespace, fix it.
>>
>> Refer to:
>> https://lists.01.org/pipermail/kbuild-all/2018-June/049660.html
>>
>> To: Jaegeuk Kim <jaegeuk@kernel.org>
>> To: Chao Yu <yuchao0@huawei.com>
>> Cc: linux-f2fs-devel@lists.sourceforge.net
>> Cc: linux-kernel@vger.kernel.org
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
>> ---
>> fs/f2fs/f2fs.h | 4 ++--
>> fs/f2fs/super.c | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
>> index 4d8b1de..11a2e09 100644
>> --- a/fs/f2fs/f2fs.h
>> +++ b/fs/f2fs/f2fs.h
>> @@ -65,7 +65,7 @@ struct f2fs_fault_info {
>> unsigned int inject_type;
>> };
>>
>> -extern char *fault_name[FAULT_MAX];
>> +extern char *f2fs_fault_name[FAULT_MAX];
>> #define IS_FAULT_SET(fi, type) ((fi)->inject_type & (1 << (type)))
>> #endif
>>
>> @@ -1279,7 +1279,7 @@ struct f2fs_sb_info {
>> #ifdef CONFIG_F2FS_FAULT_INJECTION
>> #define f2fs_show_injection_info(type) \
>> printk("%sF2FS-fs : inject %s in %s of %pF\n", \
>> - KERN_INFO, fault_name[type], \
>> + KERN_INFO, f2fs_fault_name[type], \
>> __func__, __builtin_return_address(0))
>> static inline bool time_to_inject(struct f2fs_sb_info *sbi, int type)
>> {
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index 3995e92..df12dcd 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -41,7 +41,7 @@
>>
>> #ifdef CONFIG_F2FS_FAULT_INJECTION
>>
>> -char *fault_name[FAULT_MAX] = {
>> +char *f2fs_fault_name[FAULT_MAX] = {
>> [FAULT_KMALLOC] = "kmalloc",
>> [FAULT_KVMALLOC] = "kvmalloc",
>> [FAULT_PAGE_ALLOC] = "page alloc",
>>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: avoid the global name 'fault_name'
2018-06-30 15:57 [PATCH] f2fs: avoid the global name 'fault_name' Gao Xiang
2018-06-30 16:06 ` Gao Xiang
@ 2018-07-01 2:23 ` Chao Yu
1 sibling, 0 replies; 4+ messages in thread
From: Chao Yu @ 2018-07-01 2:23 UTC (permalink / raw)
To: Gao Xiang, Jaegeuk Kim, Chao Yu; +Cc: linux-kernel, linux-f2fs-devel
On 2018/6/30 23:57, Gao Xiang wrote:
> Non-prefix global name 'fault_name' will pollute global
> namespace, fix it.
>
> Refer to:
> https://lists.01.org/pipermail/kbuild-all/2018-June/049660.html
>
> To: Jaegeuk Kim <jaegeuk@kernel.org>
> To: Chao Yu <yuchao0@huawei.com>
> Cc: linux-f2fs-devel@lists.sourceforge.net
> Cc: linux-kernel@vger.kernel.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-01 2:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-30 15:57 [PATCH] f2fs: avoid the global name 'fault_name' Gao Xiang
2018-06-30 16:06 ` Gao Xiang
2018-07-01 2:25 ` [f2fs-dev] " Chao Yu
2018-07-01 2:23 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).