From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 912D4EE49A6 for ; Mon, 21 Aug 2023 00:43:16 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1qXt0k-0001qv-PV; Mon, 21 Aug 2023 00:43:13 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qXt0i-0001qd-L0 for linux-f2fs-devel@lists.sourceforge.net; Mon, 21 Aug 2023 00:43:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zZwpSOWwQ3VPAvSwlBCiDjuCLAoK3M8oruqWne4uRWk=; b=EnBy1vvduj447miGlDOBZyI9wC 5859pOCiuGpQcztLXhp/oOZjTD5CuVKTUYndviX5vrELmnVbptqUAx3sTW6PjR9GfbCspnexKcT0O 3QzpjDyGuQLwSdDGBhEEvtaqpL998U05U1PpGTF0SqyCvIHhS1jlJFih6SgetVLpVGW0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zZwpSOWwQ3VPAvSwlBCiDjuCLAoK3M8oruqWne4uRWk=; b=HATW/THPwDTbnWqaAJr718NPVP wlB4UtGRad3fpd76vqOe5G3zZyhoes4pflIig2haT3pLPmEJ1M8E8/uRkskn6EjMJdA3eVy1Nlx5t qzmvbtGF7f65t29bRbQ9wBs78+9IgX+MhjVATG08rfF0fCpgYYTuBr5K10qyomt6pxJY=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1qXt0g-00078X-KS for linux-f2fs-devel@lists.sourceforge.net; Mon, 21 Aug 2023 00:43:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2BA40611C1; Mon, 21 Aug 2023 00:43:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 825BCC433C7; Mon, 21 Aug 2023 00:43:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692578583; bh=WtS4/Vqr9KgvbVTQNwzz4UGJYF/XOrLdJxcAlDH7rY8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=leKct9eM/b5mU2ZmpcS/6p/mndjZlK3eTqyvk7RZpWD9taVio7ZlRwe6y1Ukd30nw Q/bVaFkGbhz36z+SWR2fN33/telBPGOUwX2ejbwOf93eskM4KC6MvMWveXBOOZoX2H ZVAemA8NaAqnB+kM/ktT+kC9sw7HcQ0YRt3tO/6V4QCJjogk87COsi03UgK7tepGnE apP1bnIDO6ZcZVtGdr4XaUrFgSmCmpcqBkQG0nI1Kd1HmeLfKWO8fHIc/BGaslgI3X 8SDglCdZqZAKFpYWKdd7aTCfDR3tV7evDoCRmQQPyfijsUxli1YOajg0/qrHFotj1p l5bQgHcaY9URQ== Message-ID: <608462ac-5a26-bc14-4a74-ed133eb5cdca@kernel.org> Date: Mon, 21 Aug 2023 08:42:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20230819003012.3473675-1-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20230819003012.3473675-1-jaegeuk@kernel.org> X-Headers-End: 1qXt0g-00078X-KS Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid false alarm of circular locking X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syzbot+e5600587fa9cbf8e3826@syzkaller.appspotmail.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2023/8/19 8:30, Jaegeuk Kim wrote: > ====================================================== > WARNING: possible circular locking dependency detected > 6.5.0-rc5-syzkaller-00353-gae545c3283dc #0 Not tainted > ------------------------------------------------------ > syz-executor273/5027 is trying to acquire lock: > ffff888077fe1fb0 (&fi->i_sem){+.+.}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2133 [inline] > ffff888077fe1fb0 (&fi->i_sem){+.+.}-{3:3}, at: f2fs_add_inline_entry+0x300/0x6f0 fs/f2fs/inline.c:644 > > but task is already holding lock: > ffff888077fe07c8 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] > ffff888077fe07c8 (&fi->i_xattr_sem){.+.+}-{3:3}, at: f2fs_add_dentry+0x92/0x230 fs/f2fs/dir.c:783 > > which lock already depends on the new lock. > > the existing dependency chain (in reverse order) is: > > -> #1 (&fi->i_xattr_sem){.+.+}-{3:3}: > down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 > f2fs_down_read fs/f2fs/f2fs.h:2108 [inline] > f2fs_getxattr+0xb1e/0x12c0 fs/f2fs/xattr.c:532 > __f2fs_get_acl+0x5a/0x900 fs/f2fs/acl.c:179 > f2fs_acl_create fs/f2fs/acl.c:377 [inline] > f2fs_init_acl+0x15c/0xb30 fs/f2fs/acl.c:420 > f2fs_init_inode_metadata+0x159/0x1290 fs/f2fs/dir.c:558 > f2fs_add_regular_entry+0x79e/0xb90 fs/f2fs/dir.c:740 > f2fs_add_dentry+0x1de/0x230 fs/f2fs/dir.c:788 > f2fs_do_add_link+0x190/0x280 fs/f2fs/dir.c:827 > f2fs_add_link fs/f2fs/f2fs.h:3554 [inline] > f2fs_mkdir+0x377/0x620 fs/f2fs/namei.c:781 > vfs_mkdir+0x532/0x7e0 fs/namei.c:4117 > do_mkdirat+0x2a9/0x330 fs/namei.c:4140 > __do_sys_mkdir fs/namei.c:4160 [inline] > __se_sys_mkdir fs/namei.c:4158 [inline] > __x64_sys_mkdir+0xf2/0x140 fs/namei.c:4158 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > -> #0 (&fi->i_sem){+.+.}-{3:3}: > check_prev_add kernel/locking/lockdep.c:3142 [inline] > check_prevs_add kernel/locking/lockdep.c:3261 [inline] > validate_chain kernel/locking/lockdep.c:3876 [inline] > __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5144 > lock_acquire kernel/locking/lockdep.c:5761 [inline] > lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5726 > down_write+0x93/0x200 kernel/locking/rwsem.c:1573 > f2fs_down_write fs/f2fs/f2fs.h:2133 [inline] > f2fs_add_inline_entry+0x300/0x6f0 fs/f2fs/inline.c:644 > f2fs_add_dentry+0xa6/0x230 fs/f2fs/dir.c:784 > f2fs_do_add_link+0x190/0x280 fs/f2fs/dir.c:827 > f2fs_add_link fs/f2fs/f2fs.h:3554 [inline] > f2fs_mkdir+0x377/0x620 fs/f2fs/namei.c:781 > vfs_mkdir+0x532/0x7e0 fs/namei.c:4117 > ovl_do_mkdir fs/overlayfs/overlayfs.h:196 [inline] > ovl_mkdir_real+0xb5/0x370 fs/overlayfs/dir.c:146 > ovl_workdir_create+0x3de/0x820 fs/overlayfs/super.c:309 > ovl_make_workdir fs/overlayfs/super.c:711 [inline] > ovl_get_workdir fs/overlayfs/super.c:864 [inline] > ovl_fill_super+0xdab/0x6180 fs/overlayfs/super.c:1400 > vfs_get_super+0xf9/0x290 fs/super.c:1152 > vfs_get_tree+0x88/0x350 fs/super.c:1519 > do_new_mount fs/namespace.c:3335 [inline] > path_mount+0x1492/0x1ed0 fs/namespace.c:3662 > do_mount fs/namespace.c:3675 [inline] > __do_sys_mount fs/namespace.c:3884 [inline] > __se_sys_mount fs/namespace.c:3861 [inline] > __x64_sys_mount+0x293/0x310 fs/namespace.c:3861 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > other info that might help us debug this: > > Possible unsafe locking scenario: > > CPU0 CPU1 > ---- ---- > rlock(&fi->i_xattr_sem); > lock(&fi->i_sem); > lock(&fi->i_xattr_sem); > lock(&fi->i_sem); > > Reported-and-tested-by: syzbot+e5600587fa9cbf8e3826@syzkaller.appspotmail.com > Fixes: 5eda1ad1aaff "f2fs: fix deadlock in i_xattr_sem and inode page lock" > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel