From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 358C6C433ED for ; Tue, 27 Apr 2021 10:09:45 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACFB560C3D for ; Tue, 27 Apr 2021 10:09:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACFB560C3D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1lbKf0-0003Um-EQ; Tue, 27 Apr 2021 10:09:42 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lbKey-0003Ua-2m for linux-f2fs-devel@lists.sourceforge.net; Tue, 27 Apr 2021 10:09:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZaN9vMeEZox5P/HMHTULt+eqTww8w2Zv5/Kb6l0lGW8=; b=YVqXukJfkDXtyESY/2u1ORHG3Y +3g9MjV/vL6ePMjQPigEuVIF5Ly/ZHSO4du5bQimKDhEkRwZOmZfKyw0Di5B/x0aQIdzoGRbPGSfJ gs4+UCRfC0Qlts1dRL0kXQk5huCZhw6L0fw97MBwMGj27GVH6FStDfZl8El0eLNLVFt0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZaN9vMeEZox5P/HMHTULt+eqTww8w2Zv5/Kb6l0lGW8=; b=CFTxqamgQkY9UZWCFQccfknoKn cA+Eh5eFSjXi1zSPLRQ1zHhIeIkpH28EIahP95KiKXFEXtAZx+6dNmEJSzd5kzSDq5RL2uLt/342v 4oplXhmcGg5bqAcu2IF8HBXy/Wb6CIbMkS7nF+REJ4dBWcWq7BzvqG8/rQapN72qajlQ=; Received: from bhuna.collabora.co.uk ([46.235.227.227]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lbKen-0007G6-OH for linux-f2fs-devel@lists.sourceforge.net; Tue, 27 Apr 2021 10:09:39 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: shreeya) with ESMTPSA id AA8EE1F425CB To: Christoph Hellwig References: <20210423205136.1015456-1-shreeya.patel@collabora.com> <20210423205136.1015456-5-shreeya.patel@collabora.com> <20210427062907.GA1564326@infradead.org> From: Shreeya Patel Message-ID: <61d85255-d23e-7016-7fb5-7ab0a6b4b39f@collabora.com> Date: Tue, 27 Apr 2021 15:39:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210427062907.GA1564326@infradead.org> Content-Language: en-US X-Headers-End: 1lbKen-0007G6-OH Subject: Re: [f2fs-dev] [PATCH v8 4/4] fs: unicode: Add utf8 module and a unicode layer X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tytso@mit.edu, drosen@google.com, ebiggers@google.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, ebiggers@kernel.org, kernel@collabora.com, adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, andre.almeida@collabora.com, linux-ext4@vger.kernel.org, krisman@collabora.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 27/04/21 11:59 am, Christoph Hellwig wrote: > On Sat, Apr 24, 2021 at 02:21:36AM +0530, Shreeya Patel wrote: >> utf8data.h_shipped has a large database table which is an auto-generated >> decodification trie for the unicode normalization functions. >> We can avoid carrying this large table in the kernel unless it is required >> by the filesystem during boot process. >> >> Hence, make UTF-8 encoding loadable by converting it into a module and >> also add built-in UTF-8 support option for compiling it into the >> kernel whenever required by the filesystem. > The way this is implemement looks rather awkward. > > Given that the large memory usage is for a data table and not for code, > why not treat is as a firmware blob and load it using request_firmware? utf8 module not just has the data table but also has some kernel code. The big part that we are trying to keep out of the kernel is a tree structure that gets traversed based on a key that is the file name. This is done when issuing a lookup in the filesystem, which has to be very fast. So maybe it would not be so good to use request_firmware for such a core feature. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel